[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e512688376c: [clang-tidy] performance-* checks: Also allow allow member expressions to be… (authored by shivam-amd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 ___ cfe-commits mailing list

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543307. xgupta added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:523 +- Improved :doc:`performance-for-range-copy + ` sort them by name, performance checks are before readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543300. xgupta marked 2 inline comments as done. xgupta added a comment. minor update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files:

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543299. xgupta added a comment. Update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:523 +- Improved :doc:`performance-unnecessary-copy-initialization + `, PiotrZSL wrote: > Split it multiple entry's, 1 per check, keep in alphabetical order. > and maybe keep

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:523 +- Improved :doc:`performance-unnecessary-copy-initialization + `, Split it multiple entry's, 1 per check, keep in alphabetical order. and maybe keep it in format;

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543287. xgupta added a comment. Added release note and fix unit test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files:

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added a comment. Some release notes would be nice, looks like impacted checks are: performance-unnecessary-copy-initialization, performance-inefficient-vector-operation, performance-unnecessary-value-param, performance-for-range-copy. Some info about "Improved XYZ check by handling

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543282. xgupta added a comment. Rebase and address one last comment. I think now it will be fine to commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files:

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, but with a very minor nit. Comment at: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp:49 declRefExpr(to(varDecl(equalsNode(.bind("declRef"); +

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx added a comment. Could someone take a look at this patch? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 ___ cfe-commits mailing list

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx added a comment. Could someone take a look at this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 ___ cfe-commits mailing list

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx added a comment. Hi, could someone please take a look at this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 ___ cfe-commits mailing list

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx updated this revision to Diff 326798. flx added a comment. Add tests for PerformanceUnnecssaryCopyInitialization check which actually uses decl_ref_expr::isOnlyUsedAsConst(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx created this revision. flx added reviewers: aaron.ballman, sbenza. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Until now when determining all the const uses of a VarDecl we only considered