[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

2021-06-09 Thread Sven van Haastregt via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8866793b4e0a: [OpenCL] Add OpenCL builtin test generator (authored by svenvh). Herald added a subscriber: ldrumm. Herald added a project: clang.

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

2021-06-09 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added a comment. In D97869#2807654 , @svenvh wrote: > In D97869#2807627 , @azabaznov wrote: > >> @svenvh, are you going to add header-like output emitting? > > Yes, I can add that if there is interest. I

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

2021-06-09 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. In D97869#2807627 , @azabaznov wrote: > @svenvh, are you going to add header-like output emitting? Yes, I can add that if there is interest. I already have it on a local branch, so if there is interest (and it seems there is?

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

2021-06-09 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added a comment. @svenvh, are you going to add header-like output emitting? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

2021-06-09 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 ___ cfe-commits mailing list

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

2021-06-07 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:969 + +void OpenCLBuiltinTestEmitter::getTypeLists( +Record *Type, TypeFlags , std::vector , Anastasia wrote: > I would add a documentation for this function, it is

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

2021-06-07 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh updated this revision to Diff 350314. svenvh marked an inline comment as done. svenvh retitled this revision from "[OpenCL][Draft] Add OpenCL builtin test generator" to "[OpenCL] Add OpenCL builtin test generator". svenvh added a comment. Improve comments. CHANGES SINCE LAST ACTION