[PATCH] D97993: [Driver] Suppress GCC detection under -B

malharJ added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. Hi, Has anything been done to address this bug (related to COMPILER_PATH no longer being supported) ? https://bugs.llvm.org/show_bug.cgi?id=52009 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay added a comment. In D97993#2644664 , @thakis wrote: > Also broke something in chromium: > https://bugs.chromium.org/p/chromium/issues/detail?id=1191244 (since fixed by > switching something from `-B` to `--gcc-toolchain`. This only landed 4 days

[PATCH] D97993: [Driver] Suppress GCC detection under -B

thakis added a comment. Also broke something in chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1191244 (since fixed by switching something from `-B` to `--gcc-toolchain`. This only landed 4 days ago and already broke a lot of things (see above) -- chances are it's going to

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay added a comment. In D97993#2643318 , @vvereschaka wrote: > `CHECK: "-internal-isystem" "/usr/local/include"` didn't break the test on > the cross builders before. > > Also, the `// CHECK: >

[PATCH] D97993: [Driver] Suppress GCC detection under -B

vvereschaka added a comment. `CHECK: "-internal-isystem" "/usr/local/include"` didn't break the test on the cross builders before. Also, the `// CHECK: "-L[[TOOLCHAIN]]/usr/lib/i386-linux-gnu/gcc/i686-linux-gnu/4.5/../../../.."` check now is failing also (line 31). I tried to temporary

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay added a comment. In D97993#2639844 , @vvereschaka wrote: > Hi @MaskRay, > > sorry, but these changes break the `Clang::gcc-toolchain.cpp` test on the > ARMv7/AArch64 cross builders: > > - https://lab.llvm.org/buildbot/#/builders/119/builds/2807

[PATCH] D97993: [Driver] Suppress GCC detection under -B

vvereschaka added a comment. Hi @MaskRay, sorry, but these changes break the `Clang::gcc-toolchain.cpp` test on the ARMv7/AArch64 cross builders: - https://lab.llvm.org/buildbot/#/builders/119/builds/2807 (Aarch64) - https://lab.llvm.org/buildbot/#/builders/60/builds/2416 (ARMv7) Repository:

[PATCH] D97993: [Driver] Suppress GCC detection under -B

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c2da8641087: [Driver] Suppress GCC detection under -B (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:76-77 +- ``-B `` (when ``>`` is a directory) used to detect GCC + installations under . This behavior is incompatible with GCC, + causes interop issues with ``--gcc-toolchain``, and is thus dropped.

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay updated this revision to Diff 331736. MaskRay marked 5 inline comments as done. MaskRay retitled this revision from "[Driver] Suppress GCC detection under -B for non-Android" to "[Driver] Suppress GCC detection under -B". MaskRay edited the summary of this revision. MaskRay added a

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. Let's drop the Android part, too? Update the description (commit message), too? I checked our oldest supported kernel version, and we don't use `-B` either:

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.org/D97993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added a comment. @tstellar :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.org/D97993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1911 + SmallVector Prefixes; + if (TargetTriple.isAndroid()) +Prefixes.assign(D.PrefixDirs.begin(), D.PrefixDirs.end()); srhines wrote: > danalbert wrote: > > I'm not entirely

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay updated this revision to Diff 328836. MaskRay added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.org/D97993 Files: clang/docs/ReleaseNotes.rst

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

srhines added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1911 + SmallVector Prefixes; + if (TargetTriple.isAndroid()) +Prefixes.assign(D.PrefixDirs.begin(), D.PrefixDirs.end()); danalbert wrote: > I'm not entirely sure what

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

danalbert added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1911 + SmallVector Prefixes; + if (TargetTriple.isAndroid()) +Prefixes.assign(D.PrefixDirs.begin(), D.PrefixDirs.end()); I'm not entirely sure what `D.PrefixDirs` represents

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

manojgupta added a subscriber: tstellar. manojgupta added a comment. Thanks for the clarification. I do not have any objections but I feel that am not the right person to approve this change. @tstellar can you please review it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added a comment. In D97993#2607523 , @manojgupta wrote: > Another concern is people generally want clang to work out of box without any > special arguments. As a user, after installing clang's distro package or > building from source, I expect

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

manojgupta added a comment. Another concern is people generally want clang to work out of box without any special arguments. As a user, after installing clang's distro package or building from source, I expect that basic compilation should work out-of-box which includes gcc detection. i.e.

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

manojgupta added a comment. Thanks for explaining that it only affects "-B". While I believe that this change won't affect us in Chrome OS, I think it should be reviewed and approved by a few Linux distro contributors since there is already known reliance e.g. Android on the current behavior.

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added a comment. In D97993#2605157 , @manojgupta wrote: > I am not sure of the rationale or upside of this change and why do we want to > drop gcc detection? GCC does not need to do the GCC detection because it has > the needed information at

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

manojgupta added a comment. I am not sure of the rationale or upside of this change and why do we want to drop gcc detection? GCC does not need to do the GCC detection because it has the needed information at configure time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay created this revision. MaskRay added reviewers: hubert.reinterpretcast, manojgupta, nickdesaulniers, phosek. Herald added a subscriber: danielkiss. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In GCC, if `-B $prefix` is