This revision was automatically updated to reflect the committed changes.
njames93 marked an inline comment as done.
Closed by commit rG02d7ef3181dd: [clang-tidy] Fix mpi checks when running
multiple TUs per clang-tidy process (authored by njames93).
Repository:
rG LLVM Github Monorepo
njames93 marked 2 inline comments as done.
njames93 added inline comments.
Comment at: clang-tools-extra/clang-tidy/mpi/BufferDerefCheck.cpp:29-30
+ if (!FuncClassifier)
+FuncClassifier.emplace(*Result.Context);
+
aaron.ballman wrote:
> njames93 wrote:
>
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/mpi/BufferDerefCheck.cpp:29-30
+ if (!FuncClassifier)
+FuncClassifier.emplace(*Result.Context);
+
njames93 wrote:
> aaron.ballman wrote:
> > This is racy, but I don't think we
njames93 marked an inline comment as done.
njames93 added inline comments.
Comment at: clang-tools-extra/clang-tidy/mpi/BufferDerefCheck.cpp:29-30
+ if (!FuncClassifier)
+FuncClassifier.emplace(*Result.Context);
+
aaron.ballman wrote:
> This is racy, but
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: clang-tools-extra/clang-tidy/mpi/BufferDerefCheck.cpp:29-30
+ if (!FuncClassifier)
+FuncClassifier.emplace(*Result.Context);
+
njames93 added a comment.
Herald added a project: clang-tools-extra.
Ping?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98275/new/
https://reviews.llvm.org/D98275
___
cfe-commits mailing list
njames93 created this revision.
njames93 added reviewers: alexfh, aaron.ballman.
Herald added a subscriber: xazax.hun.
njames93 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Both the mpi-type-mismatch and mpi-buffer-deref check make use
