This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9bcf0eff99a0: [clangd] Optionally add reflection for
clangd-index-server (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES
kbobyrev updated this revision to Diff 330772.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Resolve post-LGTM comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98404/new/
https://reviews.llvm.org/D98404
Files:
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/CMakeLists.txt:190
option(CLANGD_ENABLE_REMOTE "Use gRPC library to enable remote index support
for Clangd" OFF)
kbobyrev updated this revision to Diff 330675.
kbobyrev added a comment.
Add explicit CMake option.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98404/new/
https://reviews.llvm.org/D98404
Files:
clang-tools-extra/clangd/CMakeLists.txt
kbobyrev updated this revision to Diff 330592.
kbobyrev added a comment.
Include Features.inc in Server.cpp.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98404/new/
https://reviews.llvm.org/D98404
Files:
clang-tools-extra/clangd/CMakeLists.txt
kbobyrev updated this revision to Diff 330589.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Resolve review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98404/new/
https://reviews.llvm.org/D98404
Files:
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12
+if (ENABLE_GRPC_REFLECTION)
+ set(REFLECTION_LIBRARY grpc++_reflection)
kadircet wrote:
> kbobyrev wrote:
> > kadircet wrote:
> > > can we move this
kbobyrev updated this revision to Diff 330573.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Herald added a project: clang-tools-extra.
Add the variable to Features.inc.in and canonicalize.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12
+if (ENABLE_GRPC_REFLECTION)
+ set(REFLECTION_LIBRARY grpc++_reflection)
kbobyrev wrote:
> kadircet wrote:
> > can we move this piece into
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12
+if (ENABLE_GRPC_REFLECTION)
+ set(REFLECTION_LIBRARY grpc++_reflection)
kadircet wrote:
> can we move this piece into FindGRPC.cmake instead?
Yes, but
kbobyrev updated this revision to Diff 329913.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98404/new/
https://reviews.llvm.org/D98404
Files:
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12
+if (ENABLE_GRPC_REFLECTION)
+ set(REFLECTION_LIBRARY grpc++_reflection)
can we move this piece into FindGRPC.cmake instead?
Comment
kbobyrev created this revision.
kbobyrev added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, mgorny.
kbobyrev requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, MaskRay, ilya-biryukov.
Herald added projects: clang, LLVM.
This was
13 matches
Mail list logo
