[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6268 + auto *FTy = llvm::FunctionType::get(SamplerT, {C->getType()}, false); + auto *Call = CGF.Builder.CreateCall( + CreateRuntimeFunction(FTy, "__translate_sampler_initializer"), {C});

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6268 + auto *FTy = llvm::FunctionType::get(SamplerT, {C->getType()}, false); + auto *Call = CGF.Builder.CreateCall( + CreateRuntimeFunction(FTy, "__translate_sampler_initializer"), {C});

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a comment. In D98411#2628592 , @Anastasia wrote: > In D98411#2626613 , @ldrumm wrote: > >> Given this fixes a runtime crash bug, should it be backported to the >> relevant release branch? > > Sure,

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

Anastasia added a comment. In D98411#2626613 , @ldrumm wrote: > Given this fixes a runtime crash bug, should it be backported to the relevant > release branch? Sure, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a comment. Given this fixes a runtime crash bug, should it be backported to the relevant release branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/ https://reviews.llvm.org/D98411

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcfd3fda7190: [OpenCL] Respect calling convention for builtin (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

svenvh accepted this revision. svenvh added a comment. In D98411#2621736 , @ldrumm wrote: > @Anastasia @svenvh is this already covered by https://reviews.llvm.org/D98039 > ? D98039 adds the calling convention for OpenCL

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a subscriber: svenvh. ldrumm added a comment. @Anastasia @svenvh is this already covered by https://reviews.llvm.org/D98039 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/ https://reviews.llvm.org/D98411

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Thanks! LGTM. I think we should consider deprecating `spir_func` calling convention in favor of default calling convention. I don't much value in having it today. Repository: rG LLVM Github

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm created this revision. ldrumm added reviewers: Anastasia, mibintc, bader, yaxunl. ldrumm added a project: clang. Herald added a subscriber: wenlei. ldrumm requested review of this revision. `__translate_sampler_initializer` has a calling convention of `spir_func`, but clang generated calls