[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

2021-03-15 Thread Amy Huang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5352dd9dab1: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms. (authored by akhuang). Repository: rG LLVM Github Monorepo

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

2021-03-15 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 330826. akhuang marked an inline comment as done. akhuang added a comment. add CHECK line to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98472/new/ https://reviews.llvm.org/D98472 Files:

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

2021-03-15 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm w nit Comment at: clang/test/CodeGen/wmemchr.c:7 +const wchar_t *wmemchr_test(const wchar_t *s, const wchar_t c, size_t n) { + // CHECK: [[S:%.*]] = load + // CHECK:

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

2021-03-11 Thread Amy Huang via Phabricator via cfe-commits
akhuang created this revision. akhuang added a reviewer: rnk. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The MSVC runtime library doesn't have a definition for wmemchr, so provide an inline implementation. Repository: rG