[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG678241795c95: [RISCV] Dont emit #undef BUILTIN from RISCVVEmitter.cpp (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98682/new/ https://reviews.llvm.org/D98682 ___ cfe-commits mailing

[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

Jim updated this revision to Diff 330888. Jim added a comment. Address @craig.topper 's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98682/new/ https://reviews.llvm.org/D98682 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/utils/TableGen/RISCVVEmitter.cpp

[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:20 +#undef BUILTIN Can you undef TARGET_BUILTIN here too? I missed that when I added it on line 15. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98682: [RISCV] Don't emit #undef BUILTIN from RISCVVEmitter.cpp

Jim created this revision. Jim added reviewers: khchen, craig.topper. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,