[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

2021-03-22 Thread Zakk Chen via Phabricator via cfe-commits
khchen added a comment. In D99082#2643322 , @jrtc27 wrote: > Most likely because you're adding assembly tests in Clang, which won't work > if the backend isn't present (and needs a REQUIRES line). Assembly tests in > Clang are generally bad practice and

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

2021-03-22 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. Most likely because you're adding assembly tests in Clang, which won't work if the backend isn't present (and needs a REQUIRES line). Assembly tests in Clang are generally bad practice and best avoided for that reason. If you do want them it's probably best to split

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

2021-03-22 Thread Zakk Chen via Phabricator via cfe-commits
khchen added a comment. I need to take a look why Buildbot run failed: https://lab.llvm.org/buildbot/#/builders/139/builds/1615 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/ https://reviews.llvm.org/D99082

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

2021-03-22 Thread Zakk Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGab082b582dd0: [RISCV][NFC] Fix RVV intrinsic tests. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

2021-03-22 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/ https://reviews.llvm.org/D99082

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

2021-03-22 Thread Zakk Chen via Phabricator via cfe-commits
khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy. Herald added subscribers: vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng,