[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. usaxena95 marked an inline comment as done. Closed by commit rGaa979084dffb: [clang][Syntax] Optimize expandedTokens for token ranges. (authored by usaxena95).

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 44. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99086/new/ https://reviews.llvm.org/D99086 Files:

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Just doc nits - I think maybe there's some confusion on what a token range is. Code looks good though! Comment at: clang-tools-extra/clangd/ParsedAST.cpp:426

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 333052. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99086/new/ https://reviews.llvm.org/D99086 Files: clang-tools-extra/clangd/ParsedAST.cpp

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 333045. usaxena95 marked 6 inline comments as done. usaxena95 edited the summary of this revision. usaxena95 added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. Made the optimization an 'opt-in'. Created

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; sammccall wrote: > kadircet wrote: > >

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

sammccall added a comment. Thanks for finding and working on this hotspot. (I'm curious *why* `isBeforeInTranslationUnit` is slow if you have any insight - it has sad worst-case but I thought we'd hit the one-element cache often enough in practice). I don't see a better way to optimize this,

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; usaxena95 wrote: > kadircet wrote: > > this

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; kadircet wrote: > this definitely makes

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; this definitely makes sense, but most of the

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 created this revision. usaxena95 added reviewers: kadircet, sammccall. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. `expandedTokens(SourceRange)` used to do a binary search to get the expanded tokens