[clang] [AST] Print the separator "," for template arguments in ConceptReference::print (PR #91750)

2024-05-10 Thread via cfe-commits
@@ -106,9 +106,15 @@ void ConceptReference::print(llvm::raw_ostream , ConceptName.printName(OS, Policy); if (hasExplicitTemplateArgs()) { OS << "<"; +bool First = true; // FIXME: Find corresponding parameter for argument -for (auto :

[clang] [AST] Print the separator "," for template arguments in ConceptReference::print (PR #91750)

2024-05-10 Thread Younan Zhang via cfe-commits
@@ -24,6 +24,7 @@ add_clang_unittest(ASTTests CommentLexer.cpp CommentParser.cpp CommentTextTest.cpp + ConceptPrinterTest.cpp zyn0217 wrote: Note: we probably want to update the gn build as well:

[clang] [AST] Print the separator "," for template arguments in ConceptReference::print (PR #91750)

2024-05-10 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks! I'm surprised that this part was missing previously... https://github.com/llvm/llvm-project/pull/91750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [AST] Print the separator "," for template arguments in ConceptReference::print (PR #91750)

2024-05-10 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/91750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Print the separator "," for template arguments in ConceptReference::print (PR #91750)

2024-05-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/91750.diff 3 Files Affected: - (modified) clang/lib/AST/ASTConcept.cpp (+7-1) - (modified) clang/unittests/AST/CMakeLists.txt (+1) - (added)

[clang] [AST] Print the separator "," for template arguments in ConceptReference::print (PR #91750)

2024-05-10 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/91750 None >From e7b23e02e9b4c98d9e24dd1debcdefada7a16004 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 10 May 2024 16:31:20 +0200 Subject: [PATCH] [AST] Print the separator , for template arguments in