[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin closed https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

yronglin wrote: Thanks for your review! The CI did passed(https://buildkite.com/llvm-project/github-pull-requests/builds/66630) but not shown on github for whatever reason. https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/steakhal approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/91879 >From f7b2ae00eebb272e0e5e221608ec3a36146a5d21 Mon Sep 17 00:00:00 2001 From: yronglin Date: Sun, 12 May 2024 14:42:09 +0800 Subject: [PATCH 1/5] [Analyzer][CFG] Correctly handle rebuilted default arg and

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1114,17 +1114,16 @@ void fCXX11MemberInitTest1() { CXX11MemberInitTest1(); } +#ifdef PEDANTIC yronglin wrote: done https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1964,39 +1964,55 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred, case Stmt::CXXDefaultArgExprClass: case Stmt::CXXDefaultInitExprClass: { Bldr.takeNodes(Pred); - ExplodedNodeSet PreVisit; -

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1964,39 +1964,55 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred, case Stmt::CXXDefaultArgExprClass: case Stmt::CXXDefaultInitExprClass: { Bldr.takeNodes(Pred); - ExplodedNodeSet PreVisit; -

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1964,39 +1964,55 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred, case Stmt::CXXDefaultArgExprClass: case Stmt::CXXDefaultInitExprClass: { Bldr.takeNodes(Pred); - ExplodedNodeSet PreVisit; -

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/91879 >From f7b2ae00eebb272e0e5e221608ec3a36146a5d21 Mon Sep 17 00:00:00 2001 From: yronglin Date: Sun, 12 May 2024 14:42:09 +0800 Subject: [PATCH 1/4] [Analyzer][CFG] Correctly handle rebuilted default arg and

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -5905,7 +5907,7 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation Loc, FieldDecl *Field) { return CXXDefaultInitExpr::Create(Context, InitializationContext->Loc, Field, InitializationContext->Context, -

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

yronglin wrote: @steakhal Thanks for your review and sorry for the late reply! https://github.com/llvm/llvm-project/pull/87933 has been revert due to regression, I've a new PR to reapply CWG1815(https://github.com/llvm/llvm-project/pull/92527). I'll continue cook this PR once

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1,4 +1,4 @@ -// RUN: %clang_analyze_cc1 -std=c++14 -verify %s \ +// RUN: %clang_analyze_cc1 -std=c++14 -verify=expected,pedantic %s \ yronglin wrote: It's used like the `pedantic-warning`, I'll remove this to address previous comments.

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1964,39 +1964,55 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred, case Stmt::CXXDefaultArgExprClass: case Stmt::CXXDefaultInitExprClass: { Bldr.takeNodes(Pred); - ExplodedNodeSet PreVisit; -

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1114,17 +1114,16 @@ void fCXX11MemberInitTest1() { CXX11MemberInitTest1(); } +#ifdef PEDANTIC yronglin wrote: Agree! https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1964,39 +1964,55 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred, case Stmt::CXXDefaultArgExprClass: case Stmt::CXXDefaultInitExprClass: { Bldr.takeNodes(Pred); - ExplodedNodeSet PreVisit; -

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1,4 +1,4 @@ -// RUN: %clang_analyze_cc1 -std=c++14 -verify %s \ +// RUN: %clang_analyze_cc1 -std=c++14 -verify=expected,pedantic %s \ steakhal wrote: You introduced the `pedantic` verify prefix, but never actually used it.

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1964,39 +1964,55 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred, case Stmt::CXXDefaultArgExprClass: case Stmt::CXXDefaultInitExprClass: { Bldr.takeNodes(Pred); - ExplodedNodeSet PreVisit; -

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1114,17 +1114,16 @@ void fCXX11MemberInitTest1() { CXX11MemberInitTest1(); } +#ifdef PEDANTIC steakhal wrote: I don't think you need to guard this section of code if you were using `// pedantic-note {{...}}` and `// pedantic-warning {{...}}` in the

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/steakhal commented: In general, this PR looks good to me. I only have some nits inline. If it didn't break anything, it should be good to go. https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1964,39 +1964,55 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred, case Stmt::CXXDefaultArgExprClass: case Stmt::CXXDefaultInitExprClass: { Bldr.takeNodes(Pred); - ExplodedNodeSet PreVisit; -

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -1964,39 +1964,55 @@ void ExprEngine::Visit(const Stmt *S, ExplodedNode *Pred, case Stmt::CXXDefaultArgExprClass: case Stmt::CXXDefaultInitExprClass: { Bldr.takeNodes(Pred); - ExplodedNodeSet PreVisit; -

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/91879 >From 6969f06f39363deda92d473ec14a08663c71f3b1 Mon Sep 17 00:00:00 2001 From: yronglin Date: Sun, 12 May 2024 14:42:09 +0800 Subject: [PATCH 1/3] [Analyzer][CFG] Correctly handle rebuilted default arg and

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -2433,6 +2429,30 @@ CFGBlock *CFGBuilder::VisitChildren(Stmt *S) { return B; } +CFGBlock *CFGBuilder::VisitCXXDefaultArgExpr(CXXDefaultArgExpr *Arg, + AddStmtChoice asc) { + if (Arg->hasRewrittenInit()) { +if

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: None (yronglin) Changes Depends on https://github.com/llvm/llvm-project/pull/87933 Clang now support the following: - Extending lifetime of object bound to reference members of aggregates, that are created from default

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (yronglin) Changes Depends on https://github.com/llvm/llvm-project/pull/87933 Clang now support the following: - Extending lifetime of object bound to reference members of aggregates, that are created from default member

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin ready_for_review https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/91879 >From 6969f06f39363deda92d473ec14a08663c71f3b1 Mon Sep 17 00:00:00 2001 From: yronglin Date: Sun, 12 May 2024 14:42:09 +0800 Subject: [PATCH 1/2] [Analyzer][CFG] Correctly handle rebuilted default arg and

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/91879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/91879 >From 6969f06f39363deda92d473ec14a08663c71f3b1 Mon Sep 17 00:00:00 2001 From: yronglin Date: Sun, 12 May 2024 14:42:09 +0800 Subject: [PATCH] [Analyzer][CFG] Correctly handle rebuilted default arg and default

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -2433,6 +2429,30 @@ CFGBlock *CFGBuilder::VisitChildren(Stmt *S) { return B; } +CFGBlock *CFGBuilder::VisitCXXDefaultArgExpr(CXXDefaultArgExpr *Arg, + AddStmtChoice asc) { + if (Arg->hasRewrittenInit()) { +if

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -2433,6 +2429,30 @@ CFGBlock *CFGBuilder::VisitChildren(Stmt *S) { return B; } +CFGBlock *CFGBuilder::VisitCXXDefaultArgExpr(CXXDefaultArgExpr *Arg, + AddStmtChoice asc) { + if (Arg->hasRewrittenInit()) { +if

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

@@ -2433,6 +2429,30 @@ CFGBlock *CFGBuilder::VisitChildren(Stmt *S) { return B; } +CFGBlock *CFGBuilder::VisitCXXDefaultArgExpr(CXXDefaultArgExpr *Arg, + AddStmtChoice asc) { + if (Arg->hasRewrittenInit()) { +if

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 23fe1fc6b78b7643a801ce3eb53d14b47b1dd0ff 6969f06f39363deda92d473ec14a08663c71f3b1 --

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #91879)

https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/91879 Depends on https://github.com/llvm/llvm-project/pull/87933 Clang now support the following: - Extending lifetime of object bound to reference members of aggregates, that are created from default member