https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/85565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13714,6 +13714,12 @@ TreeTransform::TransformLambdaExpr(LambdaExpr
*E) {
// Capturing 'this' is trivial.
if (C->capturesThis()) {
+ // We need ThisType when build capture in CheckCXXThisCapture.
jcsxky wrote:
Thanks for your patience!
Sirraide wrote:
CI for the docs seems to be broken because of something clang-format related;
the changes to the docs here are trivial, so we should just be able to ignore
that.
https://github.com/llvm/llvm-project/pull/85565
___
cfe-commits mailing
https://github.com/Sirraide approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/85565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13714,6 +13714,12 @@ TreeTransform::TransformLambdaExpr(LambdaExpr
*E) {
// Capturing 'this' is trivial.
if (C->capturesThis()) {
+ // We need ThisType when build capture in CheckCXXThisCapture.
Sirraide wrote:
No problem—writing
@@ -13714,6 +13714,12 @@ TreeTransform::TransformLambdaExpr(LambdaExpr
*E) {
// Capturing 'this' is trivial.
if (C->capturesThis()) {
+ // We need ThisType when build capture in CheckCXXThisCapture.
jcsxky wrote:
Ah, I see. I didn't realize to
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/85565
>From b286dcfb2ae59d650e6b49fee97f159e2e958dcc Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 17 Mar 2024 17:48:05 +0800
Subject: [PATCH] [Clang][Sema] Fix a crash in lambda instantiation
---
@@ -13714,6 +13714,12 @@ TreeTransform::TransformLambdaExpr(LambdaExpr
*E) {
// Capturing 'this' is trivial.
if (C->capturesThis()) {
+ // We need ThisType when build capture in CheckCXXThisCapture.
Sirraide wrote:
```suggestion
// If
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/85565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide requested changes to this pull request.
LGTM except that the comment could still be worded a bit better—especially
since I had to take another look at how this here works exactly, but I believe
that this is correct: `CXXThisScopeRAII` does nothing if the context
jcsxky wrote:
@Sirraide Very thankful for your comments and it really makes the description
more clear and easy to be understood! I have updated this patch following your
suggestion and please take another look.
https://github.com/llvm/llvm-project/pull/85565
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/85565
>From e94505fa77155cb0bbdf3ef92a426ef070cb3833 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 17 Mar 2024 17:48:05 +0800
Subject: [PATCH] [Clang][Sema] Fix a crash in lambda instantiation
---
@@ -13714,6 +13714,12 @@ TreeTransform::TransformLambdaExpr(LambdaExpr
*E) {
// Capturing 'this' is trivial.
if (C->capturesThis()) {
+ // We need ThisType here.
+ Sema::CXXThisScopeRAII ThisScope(
+ getSema(),
+ dyn_cast_or_null(
@@ -394,6 +394,7 @@ Bug Fixes to C++ Support
expression references to an entity declared outside of the lambda. (#GH64808)
- Clang's __builtin_bit_cast will now produce a constant value for records
with empty bases. See:
(#GH82383)
+- Fix a crash in lambda instantiation
@@ -13714,6 +13714,12 @@ TreeTransform::TransformLambdaExpr(LambdaExpr
*E) {
// Capturing 'this' is trivial.
if (C->capturesThis()) {
+ // We need ThisType here.
Sirraide wrote:
This comment doesn’t really explain anything. I’d suggest
@@ -394,6 +394,7 @@ Bug Fixes to C++ Support
expression references to an entity declared outside of the lambda. (#GH64808)
- Clang's __builtin_bit_cast will now produce a constant value for records
with empty bases. See:
(#GH82383)
+- Fix a crash in lambda instantiation
https://github.com/Sirraide requested changes to this pull request.
Looks fine to me apart from a few minor things.
https://github.com/llvm/llvm-project/pull/85565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/85565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/85565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/85565
>From 535617d786799c7657155e6e2cfa34fd3070f840 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 17 Mar 2024 17:48:05 +0800
Subject: [PATCH] [Clang][Sema] Fix a crash in lambda instantiation
---
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/85565
>From 6aebe68afc9930b080d5a5690799a3689de2d055 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 17 Mar 2024 17:48:05 +0800
Subject: [PATCH] [Clang][Sema] Fix a crash in lambda instantiation
---
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/85565
>From edaea6b244e9e35998421e551fb757e6ba099668 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 17 Mar 2024 17:48:05 +0800
Subject: [PATCH] [Clang][Sema] Fix a crash in lambda instantiation
---
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/85565
>From f6338c5674ad7ca9ad7595a6fbce2526fcc3f055 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 17 Mar 2024 17:48:05 +0800
Subject: [PATCH] [Clang][Sema] Fix a crash in lambda instantiation
---
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qizhi Hu (jcsxky)
Changes
Fix https://github.com/llvm/llvm-project/issues/85343
When build lambda expression in lambda instantiation, `ThisType` is required in
`Sema::BuildCaptureInit`. Set it in `Sema::InstantiateFunctionDefinition` when
https://github.com/jcsxky created
https://github.com/llvm/llvm-project/pull/85565
Fix https://github.com/llvm/llvm-project/issues/85343
When build lambda expression in lambda instantiation, `ThisType` is required in
`Sema::BuildCaptureInit`. Set it in `Sema::InstantiateFunctionDefinition` when
25 matches
Mail list logo
