[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91841)

2024-05-11 Thread via cfe-commits
Sirraide wrote: I’d recommend just adding the tests to wherever the `[[assume]]` attribute is already being tested; that’d be somewhere in `test/SemaCXX` https://github.com/llvm/llvm-project/pull/91841 ___ cfe-commits mailing list

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91841)

2024-05-11 Thread Azmat Yusuf via cfe-commits
azmat-y wrote: Would I be correct in assuming that the test would be somewhat similar to this. llvm-project/clang/test/Sema/unroll-template-value-crash.cpp ``` // RUN: %clang_cc1 -x c++ -verify %s // expected-no-diagnostics template void foo() { #pragma unroll Unroll for (int i = 0; i <

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91841)

2024-05-11 Thread via cfe-commits
https://github.com/Sirraide commented: This needs tests to make sure this is actually doing what it’s supposed to do. https://github.com/llvm/llvm-project/pull/91841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91841)

2024-05-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Azmat Yusuf (azmat-y) Changes Added check for unexpanded parameter pack in attribute [[assume]]. This solves #91232. --- Full diff: https://github.com/llvm/llvm-project/pull/91841.diff 1 Files Affected: - (modified)

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91841)

2024-05-10 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [Clang] Added check for unexpanded pack in attribute [[assume]] (PR #91841)

2024-05-10 Thread Azmat Yusuf via cfe-commits
https://github.com/azmat-y created https://github.com/llvm/llvm-project/pull/91841 Added check for unexpanded parameter pack in attribute [[assume]]. This solves #91232. >From c9f0887b5af64387938e0d80a4210af296e68f31 Mon Sep 17 00:00:00 2001 From: Azmat Yusuf Date: Sat, 11 May 2024 09:56:02