RKSimon wrote:
@sdesmalen-arm This appears to be failing on some buildbots:
https://lab.llvm.org/buildbot/#/builders/176/builds/8232
```
llvm-lit:
/home/tcwg-buildbot/worker/clang-aarch64-sve-vls-2stage/llvm/llvm/utils/lit/lit/TestingConfig.py:152:
fatal: unable to parse config file
https://github.com/sdesmalen-arm closed
https://github.com/llvm/llvm-project/pull/77941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdesmalen-arm updated
https://github.com/llvm/llvm-project/pull/77941
>From c02435b095996fba3f34b13fad20b01849cee8e6 Mon Sep 17 00:00:00 2001
From: Sander de Smalen
Date: Thu, 4 Jan 2024 14:03:04 +
Subject: [PATCH 1/3] [Clang] Amend SME attributes with support for ZT0.
https://github.com/sdesmalen-arm updated
https://github.com/llvm/llvm-project/pull/77941
>From 34da3f6446c826ec1d2c7f6eb8020d1c18146b51 Mon Sep 17 00:00:00 2001
From: Sander de Smalen
Date: Thu, 4 Jan 2024 14:03:04 +
Subject: [PATCH 1/3] [Clang] Amend SME attributes with support for ZT0.
https://github.com/erichkeane approved this pull request.
I'm ok with this now.
https://github.com/llvm/llvm-project/pull/77941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
There should be a release note for the new functionality, but otherwise the
changes LGTM. Please wait a bit in case @erichkeane has any other concerns.
https://github.com/llvm/llvm-project/pull/77941
sdesmalen-arm wrote:
[rebased patch on top of #78424]
With the contentious part of adding new bits addressed in #78424 and
@rsandifo-arm having reviewed and informally accepted the Arm/ZT0 side of the
changes in this pull-request, are you happy to formally accept this PR
@erichkeane /
https://github.com/sdesmalen-arm updated
https://github.com/llvm/llvm-project/pull/77941
>From 3be3f5f3a0176ec704c516961e1eff0d3713b084 Mon Sep 17 00:00:00 2001
From: Sander de Smalen
Date: Thu, 4 Jan 2024 14:03:04 +
Subject: [PATCH 1/2] [Clang] Amend SME attributes with support for ZT0.
@@ -4253,7 +4260,7 @@ class FunctionProtoType final
FunctionType::ExtInfo ExtInfo;
unsigned Variadic : 1;
unsigned HasTrailingReturn : 1;
-unsigned AArch64SMEAttributes : 6;
sdesmalen-arm wrote:
Thanks for both your input! The Arm attributes
@@ -4068,7 +4075,7 @@ class FunctionType : public Type {
/// Any AArch64 SME ACLE type attributes that need to be propagated
/// on declarations and function pointers.
-unsigned AArch64SMEAttributes : 6;
+unsigned AArch64SMEAttributes : 8;
@@ -4068,7 +4075,7 @@ class FunctionType : public Type {
/// Any AArch64 SME ACLE type attributes that need to be propagated
/// on declarations and function pointers.
-unsigned AArch64SMEAttributes : 6;
+unsigned AArch64SMEAttributes : 8;
@@ -4253,7 +4260,7 @@ class FunctionProtoType final
FunctionType::ExtInfo ExtInfo;
unsigned Variadic : 1;
unsigned HasTrailingReturn : 1;
-unsigned AArch64SMEAttributes : 6;
AaronBallman wrote:
Looking through the review which started
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/77941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/77941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4253,7 +4260,7 @@ class FunctionProtoType final
FunctionType::ExtInfo ExtInfo;
unsigned Variadic : 1;
unsigned HasTrailingReturn : 1;
-unsigned AArch64SMEAttributes : 6;
erichkeane wrote:
Note that thanks to bitfield packing, this is
https://github.com/erichkeane commented:
The additional size of ExtProtoInfo and FunctionType are both, IMO,
problematic, we should be shrinking these.
>This also make me wonder if we should be reserving some extra bits for future
>state that may need adding?
The point is to minimize the
https://github.com/sdesmalen-arm updated
https://github.com/llvm/llvm-project/pull/77941
>From 764e7aaecffb758e7a311c17a189ee605c623246 Mon Sep 17 00:00:00 2001
From: Sander de Smalen
Date: Thu, 4 Jan 2024 14:03:04 +
Subject: [PATCH 1/2] [Clang] Amend SME attributes with support for ZT0.
sdesmalen-arm wrote:
> I won't approve because of the growth in FunctionProtoType — someone more
> qualified than me should sign off on that.
@AaronBallman or @erichkeane, would you be happy to sign off on this patch?
I think previously you raised concerns about the size of `ExtProtoInfo`
https://github.com/sdesmalen-arm edited
https://github.com/llvm/llvm-project/pull/77941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Sander de Smalen (sdesmalen-arm)
Changes
This patch builds on top of #76971 and implements support for:
* __arm_new("zt0")
* __arm_in("zt0")
* __arm_out("zt0")
* __arm_inout("zt0")
* __arm_preserves("zt0")
I'll rebase this patch
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sander de Smalen (sdesmalen-arm)
Changes
This patch builds on top of #76971 and implements support for:
* __arm_new("zt0")
* __arm_in("zt0")
* __arm_out("zt0")
* __arm_inout("zt0")
* __arm_preserves("zt0")
I'll rebase this patch after I
https://github.com/sdesmalen-arm updated
https://github.com/llvm/llvm-project/pull/77941
>From 764e7aaecffb758e7a311c17a189ee605c623246 Mon Sep 17 00:00:00 2001
From: Sander de Smalen
Date: Thu, 4 Jan 2024 14:03:04 +
Subject: [PATCH] [Clang] Amend SME attributes with support for ZT0.
This
rsandifo-arm wrote:
LGTM from a spec point of view, although it might be worth having some tests
that have different ZA state from ZT0. (But maybe not, since the code to
handle ZA and ZT0 is mostly orthogonal.)
I won't approve because of the growth in `FunctionProtoType` — someone more
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9803de0e8e3abbbc94a4265d5847db435897a384
6b8d1c8cc772a14a820ab1fdcd6d368b0117d170 --
24 matches
Mail list logo
