[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: Actually that is more like a quick fix, we can live with it. More proper way would be simply to split those tests into pre-c++20 and universal. https://github.com/llvm/llvm-project/pull/73105 ___ cfe-commits mailing list

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread via cfe-commits
cor3ntin wrote: @PiotrZSL You beat me to it, thanks a lot! https://github.com/llvm/llvm-project/pull/73105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread via cfe-commits
dyung wrote: @cor3ntin Your commit seems to be causing 2 test failures in the clang-tools-extra tests, can you try to fix them or revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/54467 https://github.com/llvm/llvm-project/pull/73105

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/73105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/73105 >From e18309057cb6977b665ba2d7fcbd313a578eaad5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 22 Nov 2023 12:25:20 +0100 Subject: [PATCH] [Clang] Implement P28646R2 Remove Deprecated Arithmetic

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/73105 >From a835d36f3051daf4d7e20493860a7a104c9640b5 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 22 Nov 2023 12:25:20 +0100 Subject: [PATCH] [Clang] Implement P28646R2 Remove Deprecated Arithmetic

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM -- I'm a bit worried about breaking working code, but the user has to explicitly opt into C++26 mode and so it's only slightly unreasonable for them to have to change their previously correct, working code because of this. I say

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread Aaron Ballman via cfe-commits
@@ -182,6 +182,9 @@ C++2c Feature Support This is applied to both C++ standard attributes, and other attributes supported by Clang. This completes the implementation of `P2361R6 Unevaluated Strings `_ +- Implemented `P2864R2 Remove Deprecated

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/73105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on… (PR #73105)

2023-11-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/73105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits