[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-11 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-08 Thread Paul T Robinson via cfe-commits
pogo59 wrote: > I think so - we're just losing the extra info about -1/0 or 1/0 result values? That's my understanding. I haven't actually tried regenerating the tooltips to check. https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-08 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: > @RKSimon note this will affect what the tooltips show. Is that okay? I think so - we're just losing the extra info about -1/0 or 1/0 result values? https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits mailing list

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-07 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/83316 >From 2afca3e91d96cc77f43556bbf71b6e60a22e45f2 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Wed, 28 Feb 2024 11:04:41 -0800 Subject: [PATCH 1/3] [Headers][X86] Add specific results to comparisons

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b334664f9f3a098b6f3fd9cfd17b856a9edfe446 1d691620a0ef9632d85e4691dc644352d4abf2b2 --

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-07 Thread Paul T Robinson via cfe-commits
pogo59 wrote: @RKSimon note this will affect what the tooltips show. Is that okay? https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-07 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/83316 >From 2afca3e91d96cc77f43556bbf71b6e60a22e45f2 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Wed, 28 Feb 2024 11:04:41 -0800 Subject: [PATCH 1/2] [Headers][X86] Add specific results to comparisons

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-07 Thread Paul T Robinson via cfe-commits
pogo59 wrote: @RKSimon I was not aware of the comparison intrinsics in emmintrin.h. I will follow that pattern. https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-02 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: @pogo This doesn't match what we did for the various cmp intrinsics in emmintrin.h - should it? ```cpp /// Compares each of the corresponding signed 32-bit values of the ///128-bit integer vectors to determine if the values in the first operand ///are greater than those

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-02-28 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-02-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-x86 Author: Paul T Robinson (pogo59) Changes Comparison intrinsics were described as returning the "result" without specifying how. The "cmp" intrinsics return zero or all 1's in the corresponding elements of a

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-02-28 Thread Paul T Robinson via cfe-commits
pogo59 wrote: Also tag @cflores for your review. https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-02-28 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/83316 Comparison intrinsics were described as returning the "result" without specifying how. The "cmp" intrinsics return zero or all 1's in the corresponding elements of a returned vector; the "com" intrinsics return