@@ -12143,8 +12143,7 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult
, ExprResult ,
auto FXSema = S.Context.getFixedPointSemantics(LHSExprType);
LeftSize = FXSema.getWidth() - (unsigned)FXSema.hasUnsignedPadding();
}
- llvm::APInt
https://github.com/karka228 closed
https://github.com/llvm/llvm-project/pull/69521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/69521
>From db4a254b721eddacf592a647d3de4fd10a8032e0 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Wed, 18 Oct 2023 16:40:53 +0200
Subject: [PATCH] [Sema] Fixed faulty shift count warning
Constant values
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/69521
>From a4a9fb73de9319acd26290ef31d1e17b127c0c3b Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Wed, 18 Oct 2023 16:40:53 +0200
Subject: [PATCH] [Sema] Fixed faulty shift count warning
Constant values
AaronBallman wrote:
> Alright, looks like @shafik isn't going to review this, so I'll just have to
> accept it. LGTM.
FWIW, he was out of town all last week and a bit of the week before that. I
think he's still digging out from under the mountain of email.
Changes LGTM as well!
https://github.com/erichkeane approved this pull request.
Alright, looks like @shafik isn't going to review this, so I'll just have to
accept it. LGTM.
https://github.com/llvm/llvm-project/pull/69521
___
cfe-commits mailing list
karka228 wrote:
Ping
https://github.com/llvm/llvm-project/pull/69521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/69521
>From a9bfc65f6d6b0953cd762f851fb6044e1c4b8ab8 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Wed, 18 Oct 2023 16:40:53 +0200
Subject: [PATCH 1/2] [Sema] Fixed faulty shift count warning
Constant
https://github.com/erichkeane commented:
I think this looks right, but if @shafik would take an additional look, I'd
appreciate it.
Additionally, this needs a release note.
https://github.com/llvm/llvm-project/pull/69521
___
cfe-commits mailing list
@@ -12120,8 +12120,7 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult
, ExprResult ,
auto FXSema = S.Context.getFixedPointSemantics(LHSExprType);
LeftSize = FXSema.getWidth() - (unsigned)FXSema.hasUnsignedPadding();
}
- llvm::APInt
@@ -12120,8 +12120,7 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult
, ExprResult ,
auto FXSema = S.Context.getFixedPointSemantics(LHSExprType);
LeftSize = FXSema.getWidth() - (unsigned)FXSema.hasUnsignedPadding();
}
- llvm::APInt
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Karl-Johan Karlsson (karka228)
Changes
Constant values of _BitInt have the bitwith to exactly fit the constant number.
This patch fix a problem in Sema when building an APInt where the supplied
bitwidth can become too small and simply
https://github.com/karka228 created
https://github.com/llvm/llvm-project/pull/69521
Constant values of _BitInt have the bitwith to exactly fit the constant number.
This patch fix a problem in Sema when building an APInt where the supplied
bitwidth can become too small and simply truncate the
13 matches
Mail list logo
