github-actions[bot] wrote:
@huangqinjin Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/89772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
I think we can land this given it is approved and the CI is green
https://github.com/llvm/llvm-project/pull/89772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
huangqinjin wrote:
> @huangqinjin Try rebasing you changes on top of latest main. Looks like
> Windows CI is passing there including flang commits which are the source
> files that are causing msvc to run out of heap space.
Thanks for the advice. CI green now.
https://github.com/huangqinjin updated
https://github.com/llvm/llvm-project/pull/89772
>From 3c618d95c6144d52954c88b1322fd25d37fb2015 Mon Sep 17 00:00:00 2001
From: huangqinjin
Date: Tue, 23 Apr 2024 22:18:27 +0800
Subject: [PATCH] [clang][driver] Support `-x` for all languages in CL mode
MaxEW707 wrote:
@huangqinjin Try rebasing you changes on top of latest main. Looks like Windows
CI is passing there including flang commits which are the source files that are
causing msvc to run out of heap space.
https://github.com/llvm/llvm-project/pull/89772
huangqinjin wrote:
CI still fails. No idea how to proceed.
https://github.com/llvm/llvm-project/pull/89772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/huangqinjin edited
https://github.com/llvm/llvm-project/pull/89772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/huangqinjin updated
https://github.com/llvm/llvm-project/pull/89772
>From bb5ea14cd2efdb8205a1abf39f8ace279e81aa47 Mon Sep 17 00:00:00 2001
From: huangqinjin
Date: Tue, 23 Apr 2024 22:18:27 +0800
Subject: [PATCH] [clang][driver] Support `-x` for all languages in CL mode
MaxEW707 wrote:
@huangqinjin The error is "fatal error C1060: compiler is out of heap space"
which is unrelated.
I haven't figured out how to resend the event to trigger a build retry without
pushing an empty commit.
I usually just do `git commit -m "rebuild" --allow-empty` and then push that
huangqinjin wrote:
gentle ping. The ci failure looks not relevant.
https://github.com/llvm/llvm-project/pull/89772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/89772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5,7 +5,3 @@
// RUN: %clang -fsyntax-only -xc %s -xc++ -fsyntax-only 2>&1 | FileCheck %s
// RUN: %clang -fsyntax-only %s -xc %s -xc++ -fsyntax-only 2>&1 | FileCheck %s
// CHECK: '-x c++' after last input file has no effect
-
-// RUN: not %clang_cl /WX /clang:-xc /clang:-E
https://github.com/huangqinjin updated
https://github.com/llvm/llvm-project/pull/89772
>From ce57adb26e2badd034037289c443c3b7aa249ba1 Mon Sep 17 00:00:00 2001
From: huangqinjin
Date: Tue, 23 Apr 2024 22:18:27 +0800
Subject: [PATCH] [clang][driver] Support `-x` for all languages in CL mode
@@ -5,7 +5,3 @@
// RUN: %clang -fsyntax-only -xc %s -xc++ -fsyntax-only 2>&1 | FileCheck %s
// RUN: %clang -fsyntax-only %s -xc %s -xc++ -fsyntax-only 2>&1 | FileCheck %s
// CHECK: '-x c++' after last input file has no effect
-
-// RUN: not %clang_cl /WX /clang:-xc /clang:-E
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/89772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/89772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 commented:
It may be better to add a test with `-x c++-module` within CL mode.
https://github.com/llvm/llvm-project/pull/89772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (huangqinjin)
Changes
After https://github.com/llvm/llvm-project/pull/68921, clang-cl gained option
`-x` but only for CUDA/HIP. This commit simply removes the restriction on
parameters to `-x`. Especially, it is able to use `-x
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/huangqinjin created
https://github.com/llvm/llvm-project/pull/89772
After https://github.com/llvm/llvm-project/pull/68921, clang-cl gained option
`-x` but only for CUDA/HIP. This commit simply removes the restriction on
parameters to `-x`. Especially, it is able to use `-x
21 matches
Mail list logo
