https://github.com/steakhal requested changes to this pull request.
Please remove the formatting changes. (Keep only the relevant lines)
Add a test demonstrating that this fixes a false-positive.
To find which file you need to add your test, I'd recommend braking something
inside the checker
https://github.com/soukatch deleted
https://github.com/llvm/llvm-project/pull/91675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -159,8 +159,10 @@ void
UnreachableCodeChecker::checkEndAnalysis(ExplodedGraph ,
SL = DL.asLocation();
if (SR.isInvalid() || !SL.isValid())
continue;
-}
-else
+
+ if (isa(S))
soukatch wrote:
everything besides this if
https://github.com/soukatch deleted
https://github.com/llvm/llvm-project/pull/91675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
soukatch wrote:
@steakhal I believe you're the best person to tag :).
https://github.com/llvm/llvm-project/pull/91675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -159,8 +159,10 @@ void
UnreachableCodeChecker::checkEndAnalysis(ExplodedGraph ,
SL = DL.asLocation();
if (SR.isInvalid() || !SL.isValid())
continue;
-}
-else
+
+ if (isa(S))
soukatch wrote:
everything above this point is
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andrew Sukach (soukatch)
Changes
Fixes #90162. Simplest approach I could come up with was to skip cxxtry
statements. Let me know if you have any suggestions. Thanks!
---
Full diff: https://github.com/llvm/llvm-project/pull/91675.diff
1
https://github.com/soukatch created
https://github.com/llvm/llvm-project/pull/91675
Fixes #90162. Simplest approach I could come up with was to skip cxxtry
statements. Let me know if you have any suggestions. Thanks!
>From e1fcdc37e52189abcdf8ce84ada463491d8b6c04 Mon Sep 17 00:00:00 2001
