https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/90079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12702,7 +12702,7 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/2149.html;>2149
drafting
Brace elision and array length deduction
-Not resolved
+Not
Resolved*
Sirraide wrote:
> CWG index page that
https://github.com/cor3ntin approved this pull request.
I'm happy to approve that as is, I expect additional tests to materialize for
the rest of the paper.
I'm not concerned about the status page, a new core issue list should
materialize any day now
Thanks
@@ -0,0 +1,77 @@
+// RUN: %clang_cc1 -std=c++98 -triple x86_64-unknown-unknown %s
-verify=expected,cxx98 -fexceptions -fcxx-exceptions -pedantic-errors -ast-dump
| FileCheck %s --check-prefixes CXX98
+// RUN: %clang_cc1 -std=c++11 -triple x86_64-unknown-unknown %s
@@ -12702,7 +12702,7 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/2149.html;>2149
drafting
Brace elision and array length deduction
-Not resolved
+Not
Resolved*
Endilll wrote:
As I mentioned in
Sirraide wrote:
> and more tests from the paper would probably be nice
Actually, yeah, now that I think about it the main question that the DR
addresses is already being tested, so it’s probably fine the way it is atm.
https://github.com/llvm/llvm-project/pull/90079
@@ -0,0 +1,77 @@
+// RUN: %clang_cc1 -std=c++98 -triple x86_64-unknown-unknown %s
-verify=expected,cxx98 -fexceptions -fcxx-exceptions -pedantic-errors -ast-dump
| FileCheck %s --check-prefixes CXX98
+// RUN: %clang_cc1 -std=c++11 -triple x86_64-unknown-unknown %s
@@ -12702,7 +12702,7 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/2149.html;>2149
drafting
Brace elision and array length deduction
-Not resolved
+Not
Resolved*
Sirraide wrote:
Still not too familiar
https://github.com/Sirraide commented:
Two questions, and more tests from the paper would probably be nice, as
Corentin already pointed out, but what’s already here lgtm.
https://github.com/llvm/llvm-project/pull/90079
___
cfe-commits mailing list
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/90079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
>Can you add examples 14, 16, 17, 18 of the paper?
I'll add them to conformance test suite in a subsequent PR. They don't belong
here, as the issue is about deducing array length from brace initializer, but
the examples you're listing are focusing on various aspects of how
cor3ntin wrote:
Can you add examples 14, 16, 17, 18 of the paper?
I'd be if they are only tested in C++11+ modes
Then we can mark the paper as implemented (bonus point for finding the oldest
conforming version)
https://github.com/llvm/llvm-project/pull/90079
Endilll wrote:
Status of 2149 changed just yesterday to say DR per 2024 Tokyo straw poll.
That's where the discrepancy between official `cwg_index.html` and CWG GitHub
repo comes (that I link in the description).
https://github.com/llvm/llvm-project/pull/90079
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch adds test for
[CWG2149](https://cplusplus.github.io/CWG/issues/2149.html), following
[P3106R1](https://wg21.link/p3106R1) "Clarifying rules for brace elision in
aggregate initialization"
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/90079
This patch adds test for
[CWG2149](https://cplusplus.github.io/CWG/issues/2149.html), following
[P3106R1](https://wg21.link/p3106R1) "Clarifying rules for brace elision in
aggregate initialization" and a
15 matches
Mail list logo