[clang] [clang] Allow relational comparisons between unequal pointers to `void` in constant expressions (PR #89449)

2024-04-20 Thread via cfe-commits
cor3ntin wrote: @Endilll The issues do not supersede one another , despite concerning the same note. The tests for CWG2526 are in

[clang] [clang] Allow relational comparisons between unequal pointers to `void` in constant expressions (PR #89449)

2024-04-19 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Changes to DR tests look good to me, thank you! Can you send an email to Jens Maurer asking him to mark 2526 as superseded by 2749? I'm also somewhat suspicious of the fact that we check only LHS for being `void*`, but that's what we did previously as

[clang] [clang] Allow relational comparisons between unequal pointers to `void` in constant expressions (PR #89449)

2024-04-19 Thread via cfe-commits
https://github.com/offsetof edited https://github.com/llvm/llvm-project/pull/89449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow relational comparisons between unequal pointers to `void` in constant expressions (PR #89449)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (offsetof) Changes This patch disables the relevant diagnostic in C++17 and later modes. Fixes #45653 --- Full diff: https://github.com/llvm/llvm-project/pull/89449.diff 7 Files Affected: - (modified)

[clang] [clang] Allow relational comparisons between unequal pointers to `void` in constant expressions (PR #89449)

2024-04-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [clang] Allow relational comparisons between unequal pointers to `void` in constant expressions (PR #89449)

2024-04-19 Thread via cfe-commits
https://github.com/offsetof created https://github.com/llvm/llvm-project/pull/89449 This patch disables the relevant diagnostic in C++17 and later modes. Fixes #45653 >From 44e3c7a4ced2ef1f8b78ab8b0009314fbcd05c6f Mon Sep 17 00:00:00 2001 From: offsetof