nico wrote:
Also on the official waterfall, eg here:
https://lab.llvm.org/buildbot/#/builders/188/builds/42935
Can you take a look, and revert for now if it takes a while to fix?
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits
nico wrote:
Looks like the included test still makes clang crash:
http://45.33.8.238/linux/132722/step_7.txt
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/74110
>From 563f86bddc0ec59b63c6aeffee2342f027c09119 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 1 Dec 2023 18:16:36 +0100
Subject: [PATCH 1/2] [clang] Fix crash when declaring invalid lambda member
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/74110
>From 563f86bddc0ec59b63c6aeffee2342f027c09119 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 1 Dec 2023 18:16:36 +0100
Subject: [PATCH 1/2] [clang] Fix crash when declaring invalid lambda member
https://github.com/AaronBallman approved this pull request.
There's a minor nit with a comment in the test file where the comment should be
updated, and the changes need a release note. Otherwise, LGTM
https://github.com/llvm/llvm-project/pull/74110
AaronBallman wrote:
> @AaronBallman Thanks for the review. Sorry for responding so late - I've
> missed your review.
>
> The tests aren't actually unrelated to the path. This is the file where I
> discovered the crash, so I just used it to demonstrate that it's fixed. I'm
> not sure how to
philnik777 wrote:
@AaronBallman Thanks for the review. Sorry for responding so late - I've missed
your review.
The tests aren't actually unrelated to the path. This is the file where I
discovered the crash, so I just used it to demonstrate that it's fixed. I'm not
sure how to split things,
https://github.com/AaronBallman requested changes to this pull request.
Oooh, I see now, there's a new RUN line added to the test and that's where the
new diagnostics are coming from.
The tests are unrelated to the patch and should be split out into a separate
change, and you should add test
@@ -624,22 +626,22 @@ namespace ConversionOperatorDoesNotHaveDeducedReturnType {
template
friend constexpr U::operator ExpectedTypeU() const noexcept;
#else
-friend auto T::operator()(int) const;
+friend auto T::operator()(int) const; // cxx11-error {{'auto'
@@ -624,22 +626,22 @@ namespace ConversionOperatorDoesNotHaveDeducedReturnType {
template
friend constexpr U::operator ExpectedTypeU() const noexcept;
#else
-friend auto T::operator()(int) const;
+friend auto T::operator()(int) const; // cxx11-error {{'auto'
https://github.com/AaronBallman commented:
The changes should come with a release note in clang/docs/ReleaseNotes.rst.
I'm confused -- the patch says that it's fixing a crash, but none of those test
cases crash today. Can you add some new test coverage that demonstrates the
crash? Also, the
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
Ping (@AaronBallman maybe?)
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
ping
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1526,10 +1526,9 @@ bool CXXRecordDecl::isGenericLambda() const {
#ifndef NDEBUG
static bool allLookupResultsAreTheSame(const DeclContext::lookup_result ) {
- for (auto *D : R)
-if (!declaresSameEntity(D, R.front()))
- return false;
- return true;
+ return
philnik777 wrote:
gentle ping
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
> The tests changes look mostly unrelated to this PR
They mostly are. I found this while trying to check C++03 with the test and
noticed that C++11 also crashes, so I updated the test to also run in C++11.
https://github.com/llvm/llvm-project/pull/74110
shafik wrote:
Can you add a little more details in the description on the root cause of the
bug?
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cor3ntin commented:
The tests changes look mostly unrelated to this PR
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nikolas Klauser (philnik777)
Changes
I've come across this while working on implementing lambdas in C++03.
---
Full diff: https://github.com/llvm/llvm-project/pull/74110.diff
2 Files Affected:
- (modified) clang/lib/AST/DeclCXX.cpp
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/74110
I've come across this while working on implementing lambdas in C++03.
>From 563f86bddc0ec59b63c6aeffee2342f027c09119 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 1 Dec 2023 18:16:36 +0100
24 matches
Mail list logo
