https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/90220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/90220
>From b9b17fa34dab666e4c77dad9cd4109f7a88d1c2e Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 26 Apr 2024 18:03:44 +0300
Subject: [PATCH 1/3] [clang] Fix crash when destructor definition is
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
https://github.com/Sirraide requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/90220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3893,9 +3893,12 @@ namespace {
}
void VisitCXXBindTemporaryExpr(const CXXBindTemporaryExpr *E) {
- if (E->getTemporary()->getDestructor()->isTrivial()) {
-Inherited::VisitStmt(E);
-return;
+ if (const CXXDestructorDecl *DtorDecl =
+
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/90220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/90220
>From b9b17fa34dab666e4c77dad9cd4109f7a88d1c2e Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 26 Apr 2024 18:03:44 +0300
Subject: [PATCH 1/2] [clang] Fix crash when destructor definition is
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d74e42acd2479eb9f3bd8077fd3be2f3395aa638
b9b17fa34dab666e4c77dad9cd4109f7a88d1c2e --
Endilll wrote:
I have a vague feeling I might be fixing the symptom instead of the cause.
https://github.com/llvm/llvm-project/pull/90220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
Fixes #89544
---
Full diff: https://github.com/llvm/llvm-project/pull/90220.diff
3 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+3)
- (modified) clang/lib/AST/Expr.cpp (+5-3)
-
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/90220
Fixes #89544
>From b9b17fa34dab666e4c77dad9cd4109f7a88d1c2e Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 26 Apr 2024 18:03:44 +0300
Subject: [PATCH] [clang] Fix crash when destructor definition
17 matches
Mail list logo
