https://github.com/ivanmurashko closed
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ivanmurashko wrote:
Friendly ping
@sam-mccall , @jansvoboda11 , could you look at the diff. It fixes a critical
issue for anyone who wants to use Clang modules with file remapping, for
instance at clangd.
https://github.com/llvm/llvm-project/pull/91645
dexonsmith wrote:
@benlangmuir and @jansvoboda11 might also be good reviewers for this.
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ivanmurashko wrote:
Hi @sam-mccall,
The patch touches some fairly old code that hasn't been modified for a long
time. You are one of the few people who worked on it recently, around two years
ago. I would appreciate any comments and a review of the suggested patch.
https://github.com/ivanmurashko edited
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ivanmurashko edited
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ivanmurashko edited
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Ivan Murashko (ivanmurashko)
Changes
The `FileManager` might create a virtual directory that can be used later as a
search path. If the added record is a real directory that is present on a disk,
we might encounter a false cache
https://github.com/ivanmurashko created
https://github.com/llvm/llvm-project/pull/91645
The `FileManager` might create a virtual directory that can be used later as a
search path. If the added record is a real directory that is present on a disk,
we might encounter a false cache miss and add
10 matches
Mail list logo