owenca wrote:
@dyung I've reverted all relevant commits in commit
1fadb2b0c881ced247931f442fdee6c4ed96dccb.
https://github.com/llvm/llvm-project/pull/91712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dyung wrote:
Hi @owenca, this change is causing a test failure in the sanitizer bot
(https://lab.llvm.org/buildbot/#/builders/5/builds/43303), that is still
failing as of your most recent fix de641e2
(https://lab.llvm.org/buildbot/#/builders/5/builds/43334). Can you please
revert if you need
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/91712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
> I think this will stop people introducing extra arguments to function
>
> ...isCpp,isThis,isThat)
I meant to fix the FIXME after I had langded a8279a8bc541, but my previous
attempts didn't quite work. Now it seems this solution will stick.
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/91712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
I think this will stop people introducing extra arguments to function
...isCpp,isThis,isThat)
LGTM
https://github.com/llvm/llvm-project/pull/91712
___
cfe-commits mailing list
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Remove FormatToken::isSimpleTypeSpecifier() and call
Token::isSimpleTypeSpecifier(LangOpts) instead.
---
Patch is 29.50 KiB, truncated to 20.00 KiB below, full version:
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/91712
Remove FormatToken::isSimpleTypeSpecifier() and call
Token::isSimpleTypeSpecifier(LangOpts) instead.
>From 3e0b10020d15c102e050ad3785622bef01d1c075 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 10 May 2024
