p4vook wrote:
Looking for someone with knowledge of Clang AST, because I can't figure out the
correct context to insert the statement into. Current implementation breaks
"for" loop.
https://github.com/llvm/llvm-project/pull/75547
___
cfe-commits
https://github.com/p4vook updated
https://github.com/llvm/llvm-project/pull/75547
>From 97c3ed6c8a007dbca32416ebb31cf4c3bd52b264 Mon Sep 17 00:00:00 2001
From: Pavel Kalugin
Date: Fri, 15 Dec 2023 03:07:06 +0300
Subject: [PATCH 1/3] [clang-repl] fix top-level statement declaration context
https://github.com/p4vook updated
https://github.com/llvm/llvm-project/pull/75547
>From 97c3ed6c8a007dbca32416ebb31cf4c3bd52b264 Mon Sep 17 00:00:00 2001
From: Pavel Kalugin
Date: Fri, 15 Dec 2023 03:07:06 +0300
Subject: [PATCH 1/2] [clang-repl] fix top-level statement declaration context
p4vook wrote:
Apparently, we should clean up only parts of the PTU that have changed. Dear
reviewers, do you have any idea how that could be implemented?
https://github.com/llvm/llvm-project/pull/75547
___
cfe-commits mailing list
https://github.com/p4vook edited https://github.com/llvm/llvm-project/pull/75547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/p4vook updated
https://github.com/llvm/llvm-project/pull/75547
>From bf1bd0d9618d05ce718a9d834727ff25c3e92a18 Mon Sep 17 00:00:00 2001
From: Pavel Kalugin
Date: Fri, 15 Dec 2023 03:07:06 +0300
Subject: [PATCH 1/4] clang-repl: fix top-level statement declaration context
https://github.com/p4vook updated
https://github.com/llvm/llvm-project/pull/75547
>From bf1bd0d9618d05ce718a9d834727ff25c3e92a18 Mon Sep 17 00:00:00 2001
From: Pavel Kalugin
Date: Fri, 15 Dec 2023 03:07:06 +0300
Subject: [PATCH 1/3] clang-repl: fix top-level statement declaration context
p4vook wrote:
I should probably add a test to fix this behavior, but I haven't figured out
how to run the tests locally yet.
https://github.com/llvm/llvm-project/pull/75547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/p4vook edited https://github.com/llvm/llvm-project/pull/75547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/p4vook updated
https://github.com/llvm/llvm-project/pull/75547
>From bf1bd0d9618d05ce718a9d834727ff25c3e92a18 Mon Sep 17 00:00:00 2001
From: Pavel Kalugin
Date: Fri, 15 Dec 2023 03:07:06 +0300
Subject: [PATCH] clang-repl: fix top-level statement declaration context
Change
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ee2deb4cf70e9468510750070435f29ca7482d02
31273597beb9439f4c78123c48f8ecc9bf366e14 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Pavel Kalugin (p4vook)
Changes
Change the declaration context where we insert top-level statements to
CurrentContext.
Previously, top-level statement declarations were inserted directly into the
translation unit. This is incorrect, as
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/p4vook created
https://github.com/llvm/llvm-project/pull/75547
Change the declaration context where we insert top-level statements to
CurrentContext.
Previously, top-level statement declarations were inserted directly into the
translation unit. This is incorrect, as it
14 matches
Mail list logo
