joker-eph wrote:
> It's a sed s/== None/is None/g - what is there to review?
On my I'm not asking for more reviews, this is why I commented that this should
be **pushed** in multiple commits, I don't even need to see PRs.
Another thing also mentioned above was the problem of reverts.
If there
JDevlieghere wrote:
> It's a `sed s/== None/is None/g` - what is there to review? 10 separate
> commits/PRs for the same exact `sed` costs more in commit noise (and effort
> on the part of @e-kwsm) than one solid, patient, review here.
In addition to what @ftynse said above, the `sed` might
ftynse wrote:
> 10 separate commits/PRs for the same exact sed costs more in commit noise
> (and effort on the part of @e-kwsm) than one solid, patient, review here
Not unless you subscribe only to a subproject. FWIW, I'm not comfortable
blanket approving changes, however trivial, to
https://github.com/makslevental approved this pull request.
There you go - diligently reviewed using GitHub 's fantastic UI.
makslevental wrote:
It's a `sed s/== None/is None/g` - what is there to review? 10 separate PRs for
the same exact `sed` costs more in commit noise (and effort on the part of
@e-kwsm) than one solid, patient, review here.
https://github.com/llvm/llvm-project/pull/91857
https://github.com/joker-eph approved this pull request.
If you can push this to main in separate commits (one per project as it was
mentioned?), that'd be great!
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
https://github.com/JDevlieghere commented:
This should really be broken up into separate PRs per subproject. One large PR
like this makes reviewing harder and causes unnecessary churn in the case that
this gets reverted.
https://github.com/llvm/llvm-project/pull/91857
https://github.com/ChuanqiXu9 approved this pull request.
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/teresajohnson approved this pull request.
compiler-rt changes lgtm
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett approved this pull request.
LLDB changes look good to me.
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DavidSpickett wrote:
LLVM uses a GitHub setting where the PR is squashed, and the commit message is
taken from the PR description rather than the commits themselves. So all you
have to do here is copy the commit message you updated into the PR's
description.
https://github.com/mtrofin approved this pull request.
LGTM for the `ctx_profile` part.
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ftynse approved this pull request.
LGTM for the MLIR part. Please seek approval from relevant reviewers for all
other subprojects.
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
e-kwsm wrote:
Commit message is updated/
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/91857
>From 7cec823d9a87b90bf8d9ae5c975f4492076e0abb Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(python): fix comparison to None
from PEP8
ftynse wrote:
This should be included in the actual commit, not GitHub comments.
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
e-kwsm wrote:
>From [PEP8](https://peps.python.org/pep-0008/#programming-recommendations):
> Comparisons to singletons like None should always be done with `is` or `is
> not`, never the equality operators.
[flake8](https://flake8.pycqa.org/en/latest/) is used here.
ftynse wrote:
Please provide a proper patch description, i.e., why the change is being made.
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-pgo
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Patch is 35.05 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/91857.diff
50 Files Affected:
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Patch is 35.05 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/91857.diff
50 Files Affected:
- (modified)
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/91857
None
>From c450df191a6b96591d7c7a7454b6e15cb925520f Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(python): fix comparison to None
---
22 matches
Mail list logo
