nikic wrote:
@dtcxzyw Auto-upgrade is only for bitcode files, we usually do not upgrade IR
files. Can you regenerate the inputs with the new clang version?
https://github.com/llvm/llvm-project/pull/84341
___
cfe-commits mailing list
dtcxzyw wrote:
> This is a very niche feature, and I don't think trying to upgrade it is
> worthwhile.
It exists in many real-world applications. If you are not willing to implement
the upgrader, I will do this for the original IR files in my benchmark :)
dtcxzyw wrote:
> bin/opt: ../../llvm-opt-benchmark/bench/icu/original/servlkf.ll:776:98:
> error: expected ')' in constantexpr
store ptr getelementptr inbounds ({ [11 x ptr] }, ptr
@_ZTVN6icu_7516LocaleKeyFactoryE, i32 0, inrange i32 0, i32 2), ptr %this1,
align 8
@nikic Do we need an
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/84341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nhaehnle approved this pull request.
https://github.com/llvm/llvm-project/pull/84341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -47,28 +47,66 @@ static bool splitGlobal(GlobalVariable ) {
if (!Init)
return false;
- // Verify that each user of the global is an inrange getelementptr constant.
- // From this it follows that any loads from or stores to that global must use
- // a pointer
@@ -47,28 +47,66 @@ static bool splitGlobal(GlobalVariable ) {
if (!Init)
return false;
- // Verify that each user of the global is an inrange getelementptr constant.
- // From this it follows that any loads from or stores to that global must use
- // a pointer
@@ -23,24 +23,26 @@
@PR23753_b = global ptr getelementptr (i8, ptr @PR23753_a, i64 ptrtoint (ptr
@PR23753_a to i64))
; CHECK: @PR23753_b = global ptr getelementptr (i8, ptr @PR23753_a, i64
ptrtoint (ptr @PR23753_a to i64))
-; Verify that inrange on an index inhibits
@@ -23,24 +23,26 @@
@PR23753_b = global ptr getelementptr (i8, ptr @PR23753_a, i64 ptrtoint (ptr
@PR23753_a to i64))
; CHECK: @PR23753_b = global ptr getelementptr (i8, ptr @PR23753_a, i64
ptrtoint (ptr @PR23753_a to i64))
-; Verify that inrange on an index inhibits
@@ -47,28 +47,66 @@ static bool splitGlobal(GlobalVariable ) {
if (!Init)
return false;
- // Verify that each user of the global is an inrange getelementptr constant.
- // From this it follows that any loads from or stores to that global must use
- // a pointer
https://github.com/nhaehnle commented:
The clang-format complaints look real. (I'm no friend of the alignment of
end-of-line comments because it's super noisy in diffs, but...)
I don't know Clang, but the changes there look reasonable enough to me. One nit
inline, with that fixed the change
https://github.com/nhaehnle edited
https://github.com/llvm/llvm-project/pull/84341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-analysis
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-lld-elf
Author: Nikita Popov (nikic)
Changes
As part of the [migration to
ptradd](https://discourse.llvm.org/t/rfc-replacing-getelementptr-with-ptradd/68699),
we need to change the
llvmbot wrote:
@llvm/pr-subscribers-lld-macho
Author: Nikita Popov (nikic)
Changes
As part of the [migration to
ptradd](https://discourse.llvm.org/t/rfc-replacing-getelementptr-with-ptradd/68699),
we need to change the representation of the `inrange` attribute, which is used
for vtable
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Nikita Popov (nikic)
Changes
As part of the [migration to
ptradd](https://discourse.llvm.org/t/rfc-replacing-getelementptr-with-ptradd/68699),
we need to change the representation of the `inrange` attribute, which is used
for
https://github.com/nikic ready_for_review
https://github.com/llvm/llvm-project/pull/84341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
16 matches
Mail list logo
