[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

https://github.com/lelandjansen closed https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

lelandjansen wrote: `Host linker version: 1015.7` I'm happy to close this PR and debug/reopen the issue if the warning becomes a problem. https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

JDevlieghere wrote: Right, my point is that (I think) that doesn't make sense. AFAIK `addMinVersionArgs` is called exclusively from the code snippet I pasted, which should check the linker version. The version of `ld` in which this changed is much newer than the 520 referenced there. I'd

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

lelandjansen wrote: > How are we ending up in this code path? @JDevlieghere We're trying to build a release on macOS following [these steps](https://github.com/llvm/llvm-project/blob/5e6bb1fb885abec2e8bc85422bbd83fe4ece6d3b/llvm/docs/ReleaseProcess.rst#L54) and are getting a linker warning

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

https://github.com/JDevlieghere requested changes to this pull request. We should be using `-platform-version` for newer versions of the linker. How are we ending up in this code path? https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

https://github.com/jryans commented: AIUI, this is straightforward case of updating tools to use new option names. I suppose there is a chance it triggers failures in e.g. older linkers that don't support the newer names, but I assume on Apple platforms there's less risk of that anyway. Do

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

lelandjansen wrote: @jryans Would you be able to approve this PR? https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

lelandjansen wrote: Ping https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

lelandjansen wrote: > Perhaps good to edit the PR title, it mentions the same flag twice at the > moment. Good catch. Thank you. https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

https://github.com/lelandjansen edited https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits