github-actions[bot] wrote:
@chrisnc Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a
https://github.com/ostannard closed
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chrisnc wrote:
If there's no other feedback, could someone hit the merge button for me?
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smithp35 approved this pull request.
LGTM, thanks for the confirmation.
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/chrisnc edited
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chrisnc wrote:
@smithp35 thanks! Yes, I iterated on the specific direction here after the
feedback about not changing the behavior of `-mcpu=cortex-r52`, but the first
comment in the thread reflects the initial state, so I'll change that. I
believe the cortex-r82 is AArch64-only, and so is
smithp35 wrote:
Apologies I read the comments, rather than go through the code. It looks the
code has already made the v8-r imply a generic CPU.
So it looks like the code is doing what my proposal states so no objections
from me and apologies for the noise.
smithp35 wrote:
I can chime in with an opinion but unfortunately I think it may be different to
everyone elses!
This is a bit of an awkward situation as I think we have to balance several
things:
* Consistency between v8-R and AArch32 (ARM) and AArch64 (more consistent the
better)
*
chrisnc wrote:
Understood. FWIW, `arm-none-eabi-gcc` does not enable any FPU features by
default with `-march=armv8-r` (and will error out if you combine that with
`-mfloat-abi=hard`), which is what the first pass of this PR went for, but I
think where we landed is a decent middle ground.
davemgreen wrote:
> which change? Specifying -mcpu=cortex-r52 will behave the same way as before.
> The original manual for the R52 provided for a no-neon sp-only variant, and
> they exist in the wild, and this lets "architecture-generic" builds
> automatically support both.
I just meant the
chrisnc wrote:
Friendly bump. :) @ostannard @davemgreen
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chrisnc wrote:
@davemgreen which change? Specifying `-mcpu=cortex-r52` will behave the same
way as before. The original manual for the R52 provided for a no-neon sp-only
variant, and they exist in the wild, and this lets "architecture-generic"
builds automatically support both.
One example
davemgreen wrote:
I'm not sure I would make this change, mostly due to it potentially causing a
break for existing users and making performance worse, but can see the
reasoning. I am willing to defer to others if they have an opinion.
https://github.com/llvm/llvm-project/pull/88287
moridinga wrote:
> Another option is to include `FeatureFPARMv8_D16_SP` in `ARMv8r`. The
> R-profile supplement of the Arm manual does say that this is a minimum
> feature requirement (as opposed to just being a variant of the R52).
D16_SP is guaranteed to be supported as minimum FP feature
chrisnc wrote:
Updated to fix the conflict with the ARM.td refactor. Ready for review.
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From 0a3a3c29b599df0cc6e3066b3388151fdb313cc2 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
Specifying
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From 46803a6da62b8348f3eb8759c74ec6abf8693c92 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
Specifying
chrisnc wrote:
Added an item to the release notes and fixed another place where fp64+neon was
being added (the target parser); now I see the expected results when using just
armv8r-none-eabi (sans -mcpu=cortex-r52).
https://github.com/llvm/llvm-project/pull/88287
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From 575128cc6b494fed2065cae07754477426cb1c24 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
Specifying
davemgreen wrote:
As far as I understand this will remove the tuning we do for cortex-r52 when
using armv8r, which will mean a little less performance but the tuning features
in the Arm backend are not handled as well as they could be.
Can you add release note explaining what will change?
chrisnc wrote:
Another option is to include `FeatureFPARMv8_D16_SP` in `ARMv8r`. The R-profile
supplement of the Arm manual does say that this is a minimum feature
requirement (as opposed to just being a variant of the R52).
https://github.com/llvm/llvm-project/pull/88287
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From a4a27e9db447fde7f38952618b877fc1ff741279 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From 65e44d63a0939a4b91d084a2405f8a091329e311 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
chrisnc wrote:
I've updated the PR to use the proposed approach of making `"generic"` the
default CPU for armv8r. Let me know if this is alright. I still need to fix up
a few of the tests to match this new behavior.
https://github.com/llvm/llvm-project/pull/88287
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From 4681c3016a0d035b4b23fa9349125901f6e8e4d8 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b64c69d5b1bfeaf675f25e7598b78e9f3543f241
a021b579f609144c9139d3a8bd0fe87e9d028259 --
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From a021b579f609144c9139d3a8bd0fe87e9d028259 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From ccc30221d11fe137da19c964c75b993368829647 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
chrisnc wrote:
@davemgreen yes, this does change the cortex-r52 default features as well. The
problem is that the cortex-r52 is the "default" CPU for armv8r (probably
because it's the only one), so if I don't reduce the feature set of that CPU,
armv8r will continue to imply features that are
davemgreen wrote:
Does this disable neon by default for cortex-r52? If so I don't think it should
be doing that, it would be a break in the existing behaviour, and should at
least be in the release notes.
The general rule for -mcpu options is that they should (roughly) enable the
maximum set
https://github.com/ostannard approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chrisnc wrote:
ping @ostannard
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From 9317b1750b5208528ff716cee79e8666bebdba05 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From f707f292a6153f9d23734e490720db3abb5c00ac Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From 58f4d1acb3a88ec0b7d623fd7607d355f6dfe2c3 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88287
>From 136ed3311445f498a9314a0feea0302327d5cf85 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
https://github.com/chrisnc edited
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chrisnc edited
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chrisnc edited
https://github.com/llvm/llvm-project/pull/88287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Chris Copeland (chrisnc)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/88287.diff
14 Files Affected:
- (modified) clang/test/Preprocessor/arm-target-features.c (+1-1)
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-llvm-analysis
@llvm/pr-subscribers-backend-arm
Author: Chris Copeland (chrisnc)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/88287.diff
14 Files Affected:
- (modified) clang/test/Preprocessor/arm-target-features.c (+1-1)
-
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/chrisnc created
https://github.com/llvm/llvm-project/pull/88287
None
>From 23ca20716ce1401c0f7b7e07bd817f3f9a925784 Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 5 Apr 2024 22:40:46 -0700
Subject: [PATCH] [ARM] Armv8-R does not require fp64 or neon.
---
43 matches
Mail list logo
