https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/81331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/81331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
> Add to release notes?
Done
https://github.com/llvm/llvm-project/pull/81331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81331
>From 4a0ee4be9690e0665ca93d63ffdd2dea404fd72d Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Fri, 9 Feb 2024 16:13:42 -0600
Subject: [PATCH] [LLVM] Add `__builtin_readsteadycounter` intrinsic and
buiiltin
https://github.com/arsenm commented:
Add to release notes?
https://github.com/llvm/llvm-project/pull/81331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -104,6 +104,7 @@ std::string SDNode::getOperationName(const SelectionDAG *G)
const {
case ISD::ATOMIC_STORE: return "AtomicStore";
case ISD::PCMARKER: return "PCMarker";
case ISD::READCYCLECOUNTER: return "ReadCycleCounter";
@@ -2764,6 +2764,37 @@ Query for this feature with
``__has_builtin(__builtin_readcyclecounter)``. Note
that even if present, its use may depend on run-time privilege or other OS
controlled state.
+``__builtin_readsteadycounter``
+--
+
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81331
>From 50c0bacb8c33ff0c3caf5554bd198904839a2d2c Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Fri, 9 Feb 2024 16:13:42 -0600
Subject: [PATCH] [WIP][LLVM] Add `__builtin_readsteadycounter` intrinsic and
@@ -104,6 +104,7 @@ std::string SDNode::getOperationName(const SelectionDAG *G)
const {
case ISD::ATOMIC_STORE: return "AtomicStore";
case ISD::PCMARKER: return "PCMarker";
case ISD::READCYCLECOUNTER: return "ReadCycleCounter";
@@ -2764,6 +2764,37 @@ Query for this feature with
``__has_builtin(__builtin_readcyclecounter)``. Note
that even if present, its use may depend on run-time privilege or other OS
controlled state.
+``__builtin_readsteadycounter``
+--
+
https://github.com/Artem-B commented:
LGTM with few nits for general and NVPTX parts.
https://github.com/llvm/llvm-project/pull/81331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B edited
https://github.com/llvm/llvm-project/pull/81331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
> New intrinsic sounds right - a constant frequency counter is a different
> thing to a variable frequency counter.
>
> "Steady" implies unchanging, so I'd agree with `readfixedfreqtimer` or
> similar.
I think `steady` has sufficient context here, (i.e.
JonChesterfield wrote:
New intrinsic sounds right - a constant frequency counter is a different thing
to a variable frequency counter.
"Steady" implies unchanging, so I'd agree with `readfixedfreqtimer` or similar.
We can't have a ratio between the two counters since one changes frequency and
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81331
>From 30341079e795c2668588b791f2c97b44006e7a04 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Fri, 9 Feb 2024 16:13:42 -0600
Subject: [PATCH] [WIP][LLVM] Add `__builtin_readsteadycounter` intrinsic and
jhuber6 wrote:
> Are we assuming any particular relationship to __builtin_readcyclecounter in
> terms of scales etc?
>
> __builtin_readsteadycounter could be used to access x86 MPERF clock counters,
> but to access the corresponding APERF clock we'd then need a
>
RKSimon wrote:
Are we assuming any particular relationship to __builtin_readcyclecounter in
terms of scales etc?
__builtin_readsteadycounter could be used to access x86 MPERF clock counters,
but to access the corresponding APERF clock we'd then need a
__builtin_readvariablecounter
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/81331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
18 matches
Mail list logo