https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
perry-ca wrote:
@owenca @mydeveloperday Thanks for testing on Windows and taking the time to
review the PR.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mydeveloperday wrote:
> > We don't normally commit in clang-format with a unit test
>
> I assume you mean "without a unit test". In this case the unit test is the
> existing test cases. Some fail on z/OS because the files are not read in as
> text. It's not really possible to detect this
@@ -413,8 +413,9 @@ static bool format(StringRef FileName, bool
ErrorOnIncompleteFormat = false) {
// On Windows, overwriting a file with an open file mapping doesn't work,
// so read the whole file into memory when formatting in-place.
ErrorOr> CodeOrErr =
-
@@ -413,8 +413,9 @@ static bool format(StringRef FileName, bool
ErrorOnIncompleteFormat = false) {
// On Windows, overwriting a file with an open file mapping doesn't work,
// so read the whole file into memory when formatting in-place.
ErrorOr> CodeOrErr =
-
perry-ca wrote:
> We don't normally commit in clang-format with a unit test
I assume you mean "without a unit test". In this case the unit test is the
existing test cases. Some fail on z/OS because the files are not read in as
text. It's not really possible to detect this issue on other
@@ -413,8 +413,9 @@ static bool format(StringRef FileName, bool
ErrorOnIncompleteFormat = false) {
// On Windows, overwriting a file with an open file mapping doesn't work,
// so read the whole file into memory when formatting in-place.
ErrorOr> CodeOrErr =
-
@@ -413,8 +413,9 @@ static bool format(StringRef FileName, bool
ErrorOnIncompleteFormat = false) {
// On Windows, overwriting a file with an open file mapping doesn't work,
// so read the whole file into memory when formatting in-place.
ErrorOr> CodeOrErr =
-
https://github.com/mydeveloperday edited
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday commented:
We don't normally commit in clang-format with a unit test
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -413,8 +413,9 @@ static bool format(StringRef FileName, bool
ErrorOnIncompleteFormat = false) {
// On Windows, overwriting a file with an open file mapping doesn't work,
// so read the whole file into memory when formatting in-place.
ErrorOr> CodeOrErr =
-
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/90128
>From bf3ed6819301d9fcc7e001b9e6676d5f4ce66c4d Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Thu, 25 Apr 2024 15:58:05 -0500
Subject: [PATCH] treat text files as text files so autoconversion is done
---
perry-ca wrote:
Failed at `FAIL: BOLT :: RISCV/fake-label-no-entry.c` this time. I'll give it
a day or so and try again.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/abhina-sree approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
perry-ca wrote:
> LGTM, but check why the following test in checks failed: `FAIL: BOLT ::
> RISCV/unnamed-sym-no-entry.c`
Looks unrelated. I'm kicking off another build.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/90128
>From 2d7034366547b176f89b076eb60bcb44424fae11 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Thu, 25 Apr 2024 15:58:05 -0500
Subject: [PATCH] treat text files as text files so autoconversion is done
---
https://github.com/zibi2 approved this pull request.
LGTM with clean checks.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zibi2 wrote:
LGTM, but check why the following test in checks failed:
`FAIL: BOLT :: RISCV/unnamed-sym-no-entry.c`
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-testing-tools
Author: Sean Perry (perry-ca)
Changes
To support auto-conversion on z/OS text files need to be opened as text files.
These changes will fix a number of LIT failures due to text files not being
converted to the internal code page.
-
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Sean Perry (perry-ca)
Changes
To support auto-conversion on z/OS text files need to be opened as text files.
These changes will fix a number of LIT failures due to text files not being
converted to the internal code page.
-
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/90128
To support auto-conversion on z/OS text files need to be opened as text files.
These changes will fix a number of LIT failures due to text files not being
converted to the internal code page.
- update a
21 matches
Mail list logo
