[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

@@ -11,6 +11,8 @@ // //===--===// +#include "clang/Config/config.h" perry-ca wrote: That was my preference too except clang/Config/config.h has a clause that it can only be included once

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

@@ -11,6 +11,8 @@ // //===--===// +#include "clang/Config/config.h" MaskRay wrote: If SystemZ.h uses CLANG_SYSTEMZ_DEFAULT_ARCH, that file should have `#include "clang/Config/config.h"` as

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

@@ -11,6 +11,8 @@ // //===--===// +#include "clang/Config/config.h" perry-ca wrote: This is needed for the change in SystemZ.h to replace the hard coded `"z10"` string with the

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

@@ -10,6 +10,8 @@ // //===--===// +#include "clang/Config/config.h" MaskRay wrote: unneeded include https://github.com/llvm/llvm-project/pull/89854

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

@@ -11,6 +11,8 @@ // //===--===// +#include "clang/Config/config.h" MaskRay wrote: unneeded include https://github.com/llvm/llvm-project/pull/89854

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

perry-ca wrote: @MaskRay no worries. This brittle test issue was a reason I trying to keep the default for zLinux unchanged by this. I have posted a new commit that eliminates the cmake variable for z/OS. https://github.com/llvm/llvm-project/pull/89854

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

MaskRay wrote: > @MaskRay Got it. > > The problem with that solution is that if you use --target you won't get the > correct arch. This would be a problem for any cross compilation. For example, > say you cross compile from zLinux (which wouldn't have the config file), the > arch would be

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

perry-ca wrote: I removed the ability to make z/OS default arch configurable at build time. We don't really need it and this makes the code simpler. https://github.com/llvm/llvm-project/pull/89854 ___ cfe-commits mailing list

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

https://github.com/perry-ca updated https://github.com/llvm/llvm-project/pull/89854 >From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001 From: Sean Perry Date: Tue, 23 Apr 2024 20:16:15 -0500 Subject: [PATCH 1/2] Set the default arch for z/OS to be arch10 ---

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

https://github.com/perry-ca updated https://github.com/llvm/llvm-project/pull/89854 >From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001 From: Sean Perry Date: Tue, 23 Apr 2024 20:16:15 -0500 Subject: [PATCH] Set the default arch for z/OS to be arch10 ---

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

perry-ca wrote: ping @MaskRay ^^^ https://github.com/llvm/llvm-project/pull/89854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

perry-ca wrote: @MaskRay Got it. The problem with that solution is that if you use --target you won't get the correct arch. This would be a problem for any cross compilation. For example, say you cross compile from zLinux (which wouldn't have the config file), the arch would be arch8.

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

MaskRay wrote: Clang configuration files https://clang.llvm.org/docs/UsersManual.html#configuration-files cover your use case and the feature is exactly designed to avoid such cmake default configs.

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

perry-ca wrote: ping @MaskRay. Thanks https://github.com/llvm/llvm-project/pull/89854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

https://github.com/perry-ca edited https://github.com/llvm/llvm-project/pull/89854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits