[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK closed https://github.com/llvm/llvm-project/pull/88595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/88595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/88595 >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH 1/7] Carving out -Wformat warning about scoped enums into a

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/88595 >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH 1/6] Carving out -Wformat warning about scoped enums into a

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/AaronBallman commented: Please be sure to add a release note in clang/docs/ReleaseNotes.rst. The code changes themselves LGTM, but there are some issues with the tests. https://github.com/llvm/llvm-project/pull/88595 ___

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

@@ -1,5 +1,5 @@ -// RUN: %clang_cc1 -fsyntax-only -verify -Wformat %s -// RUN: %clang_cc1 -fsyntax-only -fdiagnostics-parseable-fixits -Wformat %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wformat-pedantic %s AaronBallman wrote: We're

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/88595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/88595 >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH 1/5] Carving out -Wformat warning about scoped enums into a

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/88595 >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH 1/4] Carving out -Wformat warning about scoped enums into a

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

@@ -1,5 +1,6 @@ // RUN: %clang_cc1 -fsyntax-only -verify -Wformat %s -// RUN: %clang_cc1 -fsyntax-only -fdiagnostics-parseable-fixits -Wformat %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -fsyntax-only -fdiagnostics-parseable-fixits -Wformat-pedantic %s 2>&1 | FileCheck %s

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

pirama-arumuga-nainar wrote: > Please mention that this fixes #81647 in the patch summary so that the issue > is automatically closed. > > You should also add a release note so that users know about the change (and > link to the issue being closed). This is also pending. The rest of the

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/88595 >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH 1/4] Carving out -Wformat warning about scoped enums into a

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/88595 >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH 1/3] Carving out -Wformat warning about scoped enums into a

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/88595 >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH 1/2] Carving out -Wformat warning about scoped enums into a

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

@@ -12,8 +12,8 @@ // RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -Wformat -verify=okay %s // Verify that -Wformat-signedness with -Wno-format are not reported (gcc compat). AaronBallman wrote: Agreed, that seems like an outstanding

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

@@ -12,8 +12,8 @@ // RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -Wformat -verify=okay %s // Verify that -Wformat-signedness with -Wno-format are not reported (gcc compat). karka228 wrote: That discussion is only about -Wformat

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK edited https://github.com/llvm/llvm-project/pull/88595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/88595 >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH 1/2] Carving out -Wformat warning about scoped enums into a

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/88595 >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH] Carving out -Wformat warning about scoped enums into a subwarning

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/AaronBallman commented: Please mention that this fixes #81647 in the patch summary so that the issue is automatically closed. You should also add a release note so that users know about the change (and link to the issue being closed).

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

@@ -12,8 +12,8 @@ // RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -Wformat -verify=okay %s // Verify that -Wformat-signedness with -Wno-format are not reported (gcc compat). AaronBallman wrote: Yes, this is intentional, see the

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

@@ -218,5 +218,5 @@ void test_printf_unsigned_priX16(uint16_t x) { void test_suppress(int x) karka228 wrote: Same as above about gcc compatibility. The comment need at least to be updated. https://github.com/llvm/llvm-project/pull/88595

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

@@ -12,8 +12,8 @@ // RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -Wformat -verify=okay %s // Verify that -Wformat-signedness with -Wno-format are not reported (gcc compat). karka228 wrote: The -Wformat-signedness warning was

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (ZijunZhaoCCK) Changes Make it part of -Wformat-pedantic. --- Full diff: https://github.com/llvm/llvm-project/pull/88595.diff 3 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+2-2) - (modified)

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

https://github.com/ZijunZhaoCCK created https://github.com/llvm/llvm-project/pull/88595 Make it part of -Wformat-pedantic. >From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001 From: Zijun Date: Sat, 13 Apr 2024 00:53:38 + Subject: [PATCH] Carving out -Wformat warning