[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

@@ -1163,12 +1136,7 @@ class Sema; ConversionSequenceList allocateConversionSequences(unsigned NumConversions) { ImplicitConversionSequence *Conversions = - slabAllocate(NumConversions); - - // Construct the new objects. - for (unsigned I = 0;

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

vitalybuka wrote: have ideas about leak, but not sure what to do with perf regression and #88330 Proposing revert https://github.com/llvm/llvm-project/pull/89006 https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

nikic wrote: This change seems to cause significant compile-time regressions for C++ code (https://llvm-compile-time-tracker.com/compare.php?from=184ba038ac1d444980b3e554b0057f3f30c516ab=4082a7554521572a65a5a0008c4661a534df659d=instructions%3Au). Probably most damning are the times for the

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

vitalybuka wrote: A new memory leak https://lab.llvm.org/buildbot/#/builders/5/builds/42694 https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

@@ -1070,57 +1077,24 @@ class Sema; }; private: -SmallVector Candidates; -llvm::SmallPtrSet Functions; - -// Allocator for ConversionSequenceLists. We store the first few of these -// inline to avoid allocation for small sets. -llvm::BumpPtrAllocator

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

https://github.com/cor3ntin approved this pull request. This was a roller coaster! LGTM https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

@@ -1070,57 +1077,24 @@ class Sema; }; private: -SmallVector Candidates; -llvm::SmallPtrSet Functions; - -// Allocator for ConversionSequenceLists. We store the first few of these -// inline to avoid allocation for small sets. -llvm::BumpPtrAllocator

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

@@ -1070,57 +1077,24 @@ class Sema; }; private: -SmallVector Candidates; -llvm::SmallPtrSet Functions; - -// Allocator for ConversionSequenceLists. We store the first few of these -// inline to avoid allocation for small sets. -llvm::BumpPtrAllocator

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

@@ -1163,7 +1137,7 @@ class Sema; ConversionSequenceList allocateConversionSequences(unsigned NumConversions) { ImplicitConversionSequence *Conversions = - slabAllocate(NumConversions); + Ctx.Allocate(NumConversions); // Construct the

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

AaronBallman wrote: The precommit CI failures are real; I'm still investigating what's going sideways. https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve stack usage to increase recursive initialization depth (PR #88546)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/88546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits