JoverZhang wrote:
> Please add an entry to the release notes here:
>
> https://github.com/llvm/llvm-project/blob/502e77df1fc4aa859db6709e14e93af6207e4dc4/clang-tools-extra/docs/ReleaseNotes.rst?plain=1#L176
>
>
> do note that the entries are sorted by their check names.
> Otherwise looks
https://github.com/JoverZhang updated
https://github.com/llvm/llvm-project/pull/91588
>From 19bf94ca3c093a6904482eab599f8366cad1384e Mon Sep 17 00:00:00 2001
From: Jover Zhang
Date: Thu, 9 May 2024 20:56:51 +0800
Subject: [PATCH 1/3] [clang-tidy] Ignore `if consteval` in else-after-return
---
https://github.com/JoverZhang updated
https://github.com/llvm/llvm-project/pull/91588
>From 19bf94ca3c093a6904482eab599f8366cad1384e Mon Sep 17 00:00:00 2001
From: Jover Zhang
Date: Thu, 9 May 2024 20:56:51 +0800
Subject: [PATCH 1/3] [clang-tidy] Ignore `if consteval` in else-after-return
---
@@ -0,0 +1,17 @@
+// RUN: %check_clang_tidy -std=c++20 %s readability-else-after-return %t
5chmidti wrote:
While `consteval` was added in C++20, `if consteval` is a C++23 feature. Please
use `-std=c++23`
https://github.com/5chmidti commented:
Please add an entry to the release notes here:
https://github.com/llvm/llvm-project/blob/502e77df1fc4aa859db6709e14e93af6207e4dc4/clang-tools-extra/docs/ReleaseNotes.rst?plain=1#L176
do note that the entries are sorted by their check names.
Otherwise
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/91588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-clang-tidy
Author: Jover (JoverZhang)
Changes
Fixes #91561.
---
Full diff: https://github.com/llvm/llvm-project/pull/91588.diff
2 Files Affected:
- (modified)
https://github.com/JoverZhang ready_for_review
https://github.com/llvm/llvm-project/pull/91588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JoverZhang wrote:
> Thanks for your patch! Would you be able to add a test case for this please?
Yes, thanks. I added a test case.
https://github.com/llvm/llvm-project/pull/91588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/JoverZhang updated
https://github.com/llvm/llvm-project/pull/91588
>From 19bf94ca3c093a6904482eab599f8366cad1384e Mon Sep 17 00:00:00 2001
From: Jover Zhang
Date: Thu, 9 May 2024 20:56:51 +0800
Subject: [PATCH 1/2] [clang-tidy] Ignore `if consteval` in else-after-return
---
https://github.com/JoverZhang updated
https://github.com/llvm/llvm-project/pull/91588
>From 19bf94ca3c093a6904482eab599f8366cad1384e Mon Sep 17 00:00:00 2001
From: Jover Zhang
Date: Thu, 9 May 2024 20:56:51 +0800
Subject: [PATCH 1/2] [clang-tidy] Ignore `if consteval` in else-after-return
---
cjdb wrote:
Thanks for your patch! Would you be able to add a test case for this please?
https://github.com/llvm/llvm-project/pull/91588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/JoverZhang created
https://github.com/llvm/llvm-project/pull/91588
Fixes #91561.
>From 19bf94ca3c093a6904482eab599f8366cad1384e Mon Sep 17 00:00:00 2001
From: Jover Zhang
Date: Thu, 9 May 2024 20:56:51 +0800
Subject: [PATCH] [clang-tidy] Ignore `if consteval` in
14 matches
Mail list logo