[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

2024-05-01 Thread Igor Kudrin via cfe-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/90370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

2024-04-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/90370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

2024-04-29 Thread Fangrui Song via cfe-commits
MaskRay wrote: This simplification seems desired. https://reviews.llvm.org/D00#3302749 had a `LLVM_INSTALL_TOOLCHAIN_ONLY` condition, which seems unneeded. https://github.com/llvm/llvm-project/pull/90370 ___ cfe-commits mailing list

[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

2024-04-27 Thread Igor Kudrin via cfe-commits
igorkudrin wrote: > I think out of tree builds of clang-tidy (back in the svn days, when people > did partial checkouts of individual projects) probably needed this to be able > to correctly correctly find the right headers. Maybe standalone builds aren't > permitted anymore? I think I

[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

2024-04-27 Thread Jameson Nash via cfe-commits
vtjnash wrote: I think out of tree builds of clang-tidy (back in the svn days, when people did partial checkouts of individual projects) probably needed this to be able to correctly correctly find the right headers. Maybe standalone builds aren't permitted anymore? I think I mentioned this a

[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

2024-04-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Igor Kudrin (igorkudrin) Changes The only reason for the removed condition was that there was a dependency for `CTTestTidyModule` on the `clang-tidy-headers` target, which was only created under the same `NOT

[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

2024-04-27 Thread Igor Kudrin via cfe-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/90370 The only reason for the removed condition was that there was a dependency for `CTTestTidyModule` on the `clang-tidy-headers` target, which was only created under the same `NOT LLVM_INSTALL_TOOLCHAIN_ONLY`