https://github.com/5chmidti commented:
Thanks for the cleanup, it looks overall good (w.r.t `asyncio`: I only know
about `asyncio` what I read in this pr).
> Only print the filename after completion, not the entire Clang-Tidy
> invocation command. I find this neater but the behavior can
@@ -501,70 +506,72 @@ def main():
# Build up a big regexy filter from all command line arguments.
file_name_re = re.compile("|".join(args.files))
+files = {f for f in files if file_name_re.search(f)}
-return_code = 0
+returncode = 0
try:
-#
@@ -501,70 +506,72 @@ def main():
# Build up a big regexy filter from all command line arguments.
file_name_re = re.compile("|".join(args.files))
+files = {f for f in files if file_name_re.search(f)}
-return_code = 0
+returncode = 0
try:
-#
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/89490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
@nicovank Overall looks fine from functionality point of view.
Problem A)
Getting bunch of
```
task: wait_for=
cb=[as_completed.._on_completion() at
/usr/lib/python3.12/asyncio/tasks.py:618]>
Task was destroyed but it is pending!
```
When CTR+C a script. More graceful
PiotrZSL wrote:
@nicovank I think that code is fine, will re-check it today. We could always
think about something else later.
https://github.com/llvm/llvm-project/pull/89490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nicovank wrote:
Rebased on top of cc54129b983799e1aaea77aa0ff3040dc30cbc8c.
Ping @PiotrZSL, what to do here? I can keep the current flush and separate
stdout/stderr behavior in this PR, it can be changed later.
But I don't think flushing fixes that issue of mis-ordered output lines, IMO
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/89490
>From da3ec0033706609c79216fd2e5360c49304223f4 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sat, 20 Apr 2024 02:58:25 +
Subject: [PATCH] [run-clang-tidy.py] Refactor, add progress indicator, add
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/89490
>From 129187f336bf6351dae4604d690809f4095a2e7e Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sat, 20 Apr 2024 02:58:25 +
Subject: [PATCH] [run-clang-tidy.py] Refactor, add progress indicator, add
nicovank wrote:
Reproduced the buffering issue on my setup, but flushing didn't fix the problem.
I could also reproduce with the current version of this script, which does also
flush after writing.
Python defaults input/output streams to buffered mode when it detects a pipe,
and I don't think
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/89490
>From 85700b3488ceb65adc73469c82137c1c3429b3f4 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sat, 20 Apr 2024 02:58:25 +
Subject: [PATCH] [run-clang-tidy.py] Refactor, add progress indicator, add
@@ -488,70 +493,72 @@ def main():
# Build up a big regexy filter from all command line arguments.
file_name_re = re.compile("|".join(args.files))
+files = {f for f in files if file_name_re.search(f)}
-return_code = 0
+returncode = 0
try:
-#
https://github.com/PiotrZSL commented:
One issue, looks like only stdout is buffered, and when clang-tidy output:
"26035 warnings generated.
Suppressed 26030 warnings (26030 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/89490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/89490
>From e27931b8a77c49f1c4cd47ca076addbe0ed19d87 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sat, 20 Apr 2024 02:58:25 +
Subject: [PATCH] [run-clang-tidy.py] Refactor, add progress indicator, add
nicovank wrote:
> Does it work with Python 3.6?
Actually, it can with one single change. `asyncio,run` was introduced in 3.7,
and can be replaced. I'll just add this change and a comment. It worked on my
3.6 setup. Let me know if you run into any issues.
PiotrZSL wrote:
I'm more or less fine with this change, but didn't had time to test it yet.
Does it work with python 3.6 ?
https://github.com/llvm/llvm-project/pull/89490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nicovank wrote:
@PiotrZSL @carlosgalvezp Any thoughts on this change?
https://github.com/llvm/llvm-project/pull/89490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/89490
>From 8b52200a0ccfa801471e7326859276ef9b46 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sat, 20 Apr 2024 02:58:25 +
Subject: [PATCH] [run-clang-tidy.py] Refactor, add progress indicator, add
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Nicolas van Kempen (nicovank)
Changes
[There is
work](https://discourse.llvm.org/t/rfc-upgrading-llvms-minimum-required-python-version/67571)
to make Python 3.8 the minimum Python version for LLVM.
I edited this script
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Nicolas van Kempen (nicovank)
Changes
[There is
work](https://discourse.llvm.org/t/rfc-upgrading-llvms-minimum-required-python-version/67571)
to make Python 3.8 the minimum Python version for LLVM.
I edited this script because I
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/89490
[There is
work](https://discourse.llvm.org/t/rfc-upgrading-llvms-minimum-required-python-version/67571)
to make Python 3.8 the minimum Python version for LLVM.
I edited this script because I wanted some
22 matches
Mail list logo
