[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

nick added a comment. Is this hack actually needed? I could not reproduce a problem with https://bugs.chromium.org/p/chromium/issues/detail?id=860398#c13 repro, the breakpoint fires for me and I see the variable. The difference with the hack and without, using `clang.exe src.cpp -S

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. > I think you probably need to add new files for the tests, e.g. > `matrix-type-casts.cpp` & `matrix-type-casts.c` and then just add tests for > various valid cast combinations. Is that enough to get you started? You can > look at some of the existing matrix codegen

[PATCH] D94355: [Passes] Add relative lookup table converter pass

This revision was automatically updated to reflect the committed changes. Closed by commit rG78a65cd945d0: [Passes] Add relative lookup table converter pass (authored by gulfem). Changed prior to commit: https://reviews.llvm.org/D94355?vs=331139=332445#toc Repository: rG LLVM Github

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:90 +// equivalent integer vector type with EEW and corresponding ELMUL (elmul = +// (eew/sew) * lmul). Fore example, vector type is __rvv_float16m4 +// (SEW=16, LMUL=4) and

[PATCH] D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager

luismarques created this revision. luismarques added a reviewer: asb. Herald added subscribers: vkmr, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook. luismarques requested review of this revision. Herald added a project: clang. Herald added a

[clang] 3c67653 - [docs] Clarify which part of the "refers to" rule for lifetimebound is

Author: Richard Smith Date: 2021-03-22T15:06:20-07:00 New Revision: 3c67653ef4e3f5278b4f278cb2b181a1fe3c4f27 URL: https://github.com/llvm/llvm-project/commit/3c67653ef4e3f5278b4f278cb2b181a1fe3c4f27 DIFF: https://github.com/llvm/llvm-project/commit/3c67653ef4e3f5278b4f278cb2b181a1fe3c4f27.diff

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

rprichard added a comment. In D96403#2639210 , @srhines wrote: > It is actually using `clang-r416183` from toolchains.py > . > From there, you

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2642782 , @dblaikie wrote: > In D97411#2642194 , @akhuang wrote: > >>> Hmm - is that type used in a way that invokes Undefined Behavior? Or is >>> this a gap/bug in the ctor

[PATCH] D99117: Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

rsmith created this revision. rsmith added a reviewer: dblaikie. Herald added a reviewer: aaron.ballman. rsmith requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99117 Files: clang/include/clang/Basic/AttrDocs.td

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

dblaikie added a comment. In D99107#2642451 , @rnk wrote: > We try to uphold the invariant that -g flags do not affect generated code, so > I don't think we should do this. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5fab603 - Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

Author: Richard Smith Date: 2021-03-22T15:03:42-07:00 New Revision: 5fab60377c1afec872235747d99ef6b7c508e4f8 URL: https://github.com/llvm/llvm-project/commit/5fab60377c1afec872235747d99ef6b7c508e4f8 DIFF: https://github.com/llvm/llvm-project/commit/5fab60377c1afec872235747d99ef6b7c508e4f8.diff

[PATCH] D99117: Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fab60377c1a: Attempt to further improve the documentation for the [[clang::lifetimebound]]… (authored by rsmith). Changed prior to commit:

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; usaxena95 wrote: > kadircet wrote: > > this

Re: [clang] 5c689e4 - Improve documentation for the [[clang::lifetimebound]] attribute.

On Thu, Mar 18, 2021 at 7:58 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2021-03-18T19:58:21-07:00 > New Revision: 5c689e4bb0473e08645547ddbf9874b5e2fa04d0 > > URL: >

[clang] c3134d7 - [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

Author: Joshua Haberman Date: 2021-03-22T14:13:42-07:00 New Revision: c3134d7c44f1059889dfee698dff415f7c2e1620 URL: https://github.com/llvm/llvm-project/commit/c3134d7c44f1059889dfee698dff415f7c2e1620 DIFF:

[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3134d7c44f1: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair. (authored by haberman, committed by rsmith). Repository: rG

Re: [clang] 5c689e4 - Improve documentation for the [[clang::lifetimebound]] attribute.

On Mon, 22 Mar 2021 at 13:31, David Blaikie wrote: > On Thu, Mar 18, 2021 at 7:58 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: Richard Smith >> Date: 2021-03-18T19:58:21-07:00 >> New Revision: 5c689e4bb0473e08645547ddbf9874b5e2fa04d0 >> >> URL: >>

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added a comment. Thanks for the patch! I think this also needs changes in code-gen & code-gen tests. In D99037#2642598 , @SaurabhJha wrote: > In D99037#2640388 , @fhahn wrote: > >> Thanks for the patch! I

[PATCH] D99126: [darwin][driver] Pass through -global-isel LLVM flags to ld.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99126/new/ https://reviews.llvm.org/D99126

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

nick created this revision. nick added reviewers: akhuang, rnk, aprantl. nick requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When no debug information is emitted there is no point in emitting a hack introduced in D63361

[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

haberman updated this revision to Diff 332405. haberman added a comment. Updated change to reflect all diffs since main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98889/new/ https://reviews.llvm.org/D98889 Files:

[clang] 424bf5d - [Driver] Bring back "Clean up Debian multiarch /usr/include/ madness" and restore i586-linux-gnu

Author: Fangrui Song Date: 2021-03-22T13:25:35-07:00 New Revision: 424bf5d8918f6356f1b8e99205c5fc8b4783ca22 URL: https://github.com/llvm/llvm-project/commit/424bf5d8918f6356f1b8e99205c5fc8b4783ca22 DIFF: https://github.com/llvm/llvm-project/commit/424bf5d8918f6356f1b8e99205c5fc8b4783ca22.diff

[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

njames93 added a comment. Herald added a project: clang-tools-extra. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98275/new/ https://reviews.llvm.org/D98275 ___ cfe-commits mailing list

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

zequanwu abandoned this revision. zequanwu added a comment. This overlaps with the functionality of attribute `used`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98295/new/ https://reviews.llvm.org/D98295

[PATCH] D99117: Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/AttrDocs.td:3038-3039 +is considered to refer to its underlying array, and aggregates (arrays and +simple ``struct``s) are

[clang] 4c65dfc - [AST] Add introspection support for Decls

Author: Stephen Kelly Date: 2021-03-22T23:16:02Z New Revision: 4c65dfc895d03d1c3bfa1ccfe9567c9ea8557492 URL: https://github.com/llvm/llvm-project/commit/4c65dfc895d03d1c3bfa1ccfe9567c9ea8557492 DIFF: https://github.com/llvm/llvm-project/commit/4c65dfc895d03d1c3bfa1ccfe9567c9ea8557492.diff

[PATCH] D98775: [AST] Add introspection support for Decls

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c65dfc895d0: [AST] Add introspection support for Decls (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D98775?vs=332160=332469#toc Repository: rG LLVM Github Monorepo

[clang] 282bf9e - [HIP] Fix ROCm detection

Author: Yaxun (Sam) Liu Date: 2021-03-22T16:10:02-04:00 New Revision: 282bf9eaf7b1fc28fd60a177b97dc1ce9f220352 URL: https://github.com/llvm/llvm-project/commit/282bf9eaf7b1fc28fd60a177b97dc1ce9f220352 DIFF:

[PATCH] D98867: [HIP] Fix ROCm detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG282bf9eaf7b1: [HIP] Fix ROCm detection (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98867/new/

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

nick added a comment. In D99107#2642451 , @rnk wrote: > We try to uphold the invariant that -g flags do not affect generated code, so > I don't think we should do this. Even under `-O0`? I could change the check to always emit on `-O0`. With

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. In D99037#2640388 , @fhahn wrote: > Thanks for the patch! I think this also needs changes in code-gen & code-gen > tests. Hey @fhahn I searched but could not find the relevant code-gen and code-gen tests I need to fix. Can

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added inline comments. Comment at: llvm/utils/gn/secondary/llvm/lib/Transforms/Utils/BUILD.gn:64 "PromoteMemoryToRegister.cpp", +"RelLookupTableConverter.cpp" "SSAUpdater.cpp", thakis wrote: > leonardchan wrote: > > Good that you added this,

[clang] 66af90b - [darwin][driver] Pass through -global-isel LLVM flags to ld.

Author: Amara Emerson Date: 2021-03-22T17:23:06-07:00 New Revision: 66af90b46e1fe395806474dde2d49b8dc78bae1a URL: https://github.com/llvm/llvm-project/commit/66af90b46e1fe395806474dde2d49b8dc78bae1a DIFF: https://github.com/llvm/llvm-project/commit/66af90b46e1fe395806474dde2d49b8dc78bae1a.diff

[PATCH] D99126: [darwin][driver] Pass through -global-isel LLVM flags to ld.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66af90b46e1f: [darwin][driver] Pass through -global-isel LLVM flags to ld. (authored by aemerson). Repository: rG LLVM Github Monorepo CHANGES

Re: [clang] a00d440 - [AST] Hide errors from the attempt to introspect nodes

Is this missing a test case? On Tue, Mar 16, 2021 at 4:47 PM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Stephen Kelly > Date: 2021-03-16T23:46:31Z > New Revision: a00d44012820e9ed2eba623dd61ca9cf5a2ce115 > > URL: >

[PATCH] D94355: [Passes] Add relative lookup table converter pass

thakis added inline comments. Comment at: llvm/utils/gn/secondary/llvm/lib/Transforms/Utils/BUILD.gn:64 "PromoteMemoryToRegister.cpp", +"RelLookupTableConverter.cpp" "SSAUpdater.cpp", leonardchan wrote: > Good that you added this, but I think Nico

[PATCH] D99106: [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor

njames93 created this revision. njames93 added reviewers: aaron.ballman, klimek, steveire. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Saves having to manually deallocate storage and keeps InnerArgs will have good cache

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

rnk added a comment. We try to uphold the invariant that -g flags do not affect generated code, so I don't think we should do this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99107/new/ https://reviews.llvm.org/D99107

[PATCH] D99117: Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

rsmith added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3038-3039 +is considered to refer to its underlying array, and aggregates (arrays and +simple ``struct``s) are considered to refer to all objects that their +subobjects refer to. +

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. In D97411#2642194 , @akhuang wrote: >> Hmm - is that type used in a way that invokes Undefined Behavior? Or is this >> a gap/bug in the ctor homing? I thought there was already a special case for >> constexpr ctors that opted

[PATCH] D99126: [darwin][driver] Pass through -global-isel LLVM flags to ld.

aemerson created this revision. aemerson added reviewers: paquette, ahmed, qcolombet, pete. aemerson added a project: clang. Herald added subscribers: steven_wu, hiraditya. aemerson requested review of this revision. GlobalISel is currently not enabled when using -flto since the front-end -mvllm

[PATCH] D97993: [Driver] Suppress GCC detection under -B

vvereschaka added a comment. `CHECK: "-internal-isystem" "/usr/local/include"` didn't break the test on the cross builders before. Also, the `// CHECK: "-L[[TOOLCHAIN]]/usr/lib/i386-linux-gnu/gcc/i686-linux-gnu/4.5/../../../.."` check now is failing also (line 31). I tried to temporary

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay added a comment. In D97993#2643318 , @vvereschaka wrote: > `CHECK: "-internal-isystem" "/usr/local/include"` didn't break the test on > the cross builders before. > > Also, the `// CHECK: >

[clang] 10cc5bc - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-22T23:09:41-05:00 New Revision: 10cc5bcd868c433f9a781aef82178b04e98bd098 URL: https://github.com/llvm/llvm-project/commit/10cc5bcd868c433f9a781aef82178b04e98bd098 DIFF:

[PATCH] D99145: [clang] Fix a crash when CTAD fails

kadircet created this revision. kadircet added a reviewer: hokein. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99145 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

jrtc27 added a comment. Most likely because you're adding assembly tests in Clang, which won't work if the backend isn't present (and needs a REQUIRES line). Assembly tests in Clang are generally bad practice and best avoided for that reason. If you do want them it's probably best to split

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. The previous commit is https://github.com/llvm/llvm-project/commit/a86bc00, and I don't understand enough of what the other code is doing to know if anything else needs to be fixed. I'd also like to add in a test to ensure this doesn't regress in the future, but I'm

[clang] b5e96e0 - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-22T22:25:28-05:00 New Revision: b5e96e0ad601bddbf102606d7a3d8ae6e68d1688 URL: https://github.com/llvm/llvm-project/commit/b5e96e0ad601bddbf102606d7a3d8ae6e68d1688 DIFF:

[clang] 3775d81 - Improve module dumping for debugging.

Author: Richard Smith Date: 2021-03-22T19:07:46-07:00 New Revision: 3775d811ff6dc1ed844aee7d15263a447ee18d52 URL: https://github.com/llvm/llvm-project/commit/3775d811ff6dc1ed844aee7d15263a447ee18d52 DIFF: https://github.com/llvm/llvm-project/commit/3775d811ff6dc1ed844aee7d15263a447ee18d52.diff

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

rsmith added a comment. Ah, I think I see how we get here. I think this fix might possibly break a case such as: template int x = [](auto){ return T(); }.operator()(T()); int y = x; ... where transforming the call to `operator()` might end up looking for the transformed version of the

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

khchen added a comment. In D99082#2643322 , @jrtc27 wrote: > Most likely because you're adding assembly tests in Clang, which won't work > if the backend isn't present (and needs a REQUIRES line). Assembly tests in > Clang are generally bad practice and

[clang] 1ea07ee - Revert "[RISCV][NFC] Fix RVV intrinsic tests."

Author: Zakk Chen Date: 2021-03-22T18:51:48-07:00 New Revision: 1ea07ee45347d713166beeb0b3ebf3d1a3b2a463 URL: https://github.com/llvm/llvm-project/commit/1ea07ee45347d713166beeb0b3ebf3d1a3b2a463 DIFF: https://github.com/llvm/llvm-project/commit/1ea07ee45347d713166beeb0b3ebf3d1a3b2a463.diff

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone created this revision. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99134 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp Index:

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

rsmith added a comment. Hm, do we ever call `FindInstantiatedDecl` on a lambda class in the first place? It seems plausible to me that this condition is unreachable. But to the extent that it's reachable, it seems mostly correct: a lambda expression appearing in a non-dependent context might

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGab082b582dd0: [RISCV][NFC] Fix RVV intrinsic tests. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/

[clang] ab082b5 - [RISCV][NFC] Fix RVV intrinsic tests.

Author: Zakk Chen Date: 2021-03-22T18:24:03-07:00 New Revision: ab082b582dd01becc0e0dbb0ff28371e0ce392a9 URL: https://github.com/llvm/llvm-project/commit/ab082b582dd01becc0e0dbb0ff28371e0ce392a9 DIFF: https://github.com/llvm/llvm-project/commit/ab082b582dd01becc0e0dbb0ff28371e0ce392a9.diff

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. It looks like this change was originally added 9 years ago with a commit message of "Lambda closure types are always considered to be like "local" classes, even if they are not within a function scope. Teach template instantiation to treat them as such, and make sure

[PATCH] D98943: [clang][deps] NFC: Extract ModuleID struct

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98943/new/ https://reviews.llvm.org/D98943

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rv32Zbr.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32 -mattr=experimental-zbr -verify-machineinstrs < %s \ jrtc27 wrote: >

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/rv32Zbr.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32 -mattr=experimental-zbr -verify-machineinstrs < %s \ craig.topper wrote: >

[clang] bef2cb9 - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-22T20:23:07-05:00 New Revision: bef2cb90625e08cef0cbe7a63bcf91c81c44a443 URL: https://github.com/llvm/llvm-project/commit/bef2cb90625e08cef0cbe7a63bcf91c81c44a443 DIFF:

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

khchen added a comment. I need to take a look why Buildbot run failed: https://lab.llvm.org/buildbot/#/builders/139/builds/1615 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/ https://reviews.llvm.org/D99082

[clang] d8e574c - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-22T22:08:43-05:00 New Revision: d8e574c8e690841ea3f8a607b383c314043b70a0 URL: https://github.com/llvm/llvm-project/commit/d8e574c8e690841ea3f8a607b383c314043b70a0 DIFF:

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. > Hmm - is that type used in a way that invokes Undefined Behavior? Or is this > a gap/bug in the ctor homing? I thought there was already a special case for > constexpr ctors that opted them out of ctor homing. Right, I think the constexpr is only used in >c++17 for

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332380. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Targets/Sparc.cpp clang/test/Preprocessor/predefined-arch-macros.c Index:

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen updated this revision to Diff 332384. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97831/new/ https://reviews.llvm.org/D97831 Files: clang/docs/DiagnosticsReference.rst

[PATCH] D98867: [HIP] Fix ROCm detection

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:269 +if (Loc != StringRef::npos) + VerStr[Loc] = '.'; +V.tryParse(VerStr); yaxunl wrote: > tra

[clang] 933d146 - Revert "[Driver] -m32: Add /usr/include/i386-linux-gnu for Debian"

Author: Petr Hosek Date: 2021-03-22T11:58:28-07:00 New Revision: 933d146f38c6d77a9b4fdde2b6b394f6ad9f8bf5 URL: https://github.com/llvm/llvm-project/commit/933d146f38c6d77a9b4fdde2b6b394f6ad9f8bf5 DIFF: https://github.com/llvm/llvm-project/commit/933d146f38c6d77a9b4fdde2b6b394f6ad9f8bf5.diff

[clang] 21b211a - Revert "[Driver] Clean up Debian multiarch /usr/include/ madness"

Author: Petr Hosek Date: 2021-03-22T11:58:28-07:00 New Revision: 21b211a8f24f8ecfab8b380ff761a90d9cf73924 URL: https://github.com/llvm/llvm-project/commit/21b211a8f24f8ecfab8b380ff761a90d9cf73924 DIFF: https://github.com/llvm/llvm-project/commit/21b211a8f24f8ecfab8b380ff761a90d9cf73924.diff

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added a subscriber: bruno. hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > hoy wrote: > > > >

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; kadircet wrote: > this definitely makes

[PATCH] D98783: [CUDA][HIP] Remove unused addr space casts

tra added a subscriber: rsmith. tra added a comment. We may want to add someone with more expertise with the IR as a reviewer. I'd like an educated opinion on whether the invisible dangling IR is something that needs fixing in general or if it's OK to just clean it up in this particular case.

[clang] 3e32e8c - [test] Bring back the improved arm and $sysroot/usr/include/i386-linux-gnu tests

Author: Fangrui Song Date: 2021-03-22T12:08:46-07:00 New Revision: 3e32e8c588e911f1fdf2589b01855a1cce3bda92 URL: https://github.com/llvm/llvm-project/commit/3e32e8c588e911f1fdf2589b01855a1cce3bda92 DIFF: https://github.com/llvm/llvm-project/commit/3e32e8c588e911f1fdf2589b01855a1cce3bda92.diff

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > hoy wrote: > > > > dblaikie wrote: > > > > > hoy

[clang] f263418 - [Driver] Gnu.cpp: remove obsoleted i386 triple detection from end-of-life distribution versions

Author: Fangrui Song Date: 2021-03-22T00:23:55-07:00 New Revision: f26341840253e15ab07c9e765733803fd3e4 URL: https://github.com/llvm/llvm-project/commit/f26341840253e15ab07c9e765733803fd3e4 DIFF: https://github.com/llvm/llvm-project/commit/f26341840253e15ab07c9e765733803fd3e4.diff

[clang-tools-extra] 2e58226 - [clangd] Fix linker error when linking clang-index-server with shared libraries

Author: Nathan Ridge Date: 2021-03-22T02:38:58-04:00 New Revision: 2e58226d8d7ee8b5e4a0f13188ef7d97911abae4 URL: https://github.com/llvm/llvm-project/commit/2e58226d8d7ee8b5e4a0f13188ef7d97911abae4 DIFF: https://github.com/llvm/llvm-project/commit/2e58226d8d7ee8b5e4a0f13188ef7d97911abae4.diff

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

TaWeiTu added a comment. In D98548#2625593 , @tmatheson wrote: > This seems quite an early point to bail out, so it will prevent some > errors/warnings associated with initialization from being emitted. For > example, this warning is currently emitted

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

HazardyKnusperkeks added a comment. In D99031#2640425 , @aybassiouny wrote: >> How about verifyFormat? Would that fail without your patch? > > @HazardyKnusperkeks sorry, but not sure that I understand your point. Are you > suggesting to use verifyFormat

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Given that it did not change any reports in our testbench it seems to be safe to land it. It clearly improves the API significantly, so I'm not opposing. Really good work @vsavchenko.

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/ https://reviews.llvm.org/D98128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2637186 , @steakhal wrote: > Ah, I wanted to give it a go, but the bots caught an assertion failure for > the parent revision of this. See the details at the Bugzilla ticket >

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

kadircet added a comment. (also please let me know if I should land this for you, preferably with an email address to attribute the commit to) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98824/new/ https://reviews.llvm.org/D98824 ___

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

steakhal added a comment. In D86465#2640765 , @vsavchenko wrote: > I do have a bit of a struggle here. This is a unit-test and thus should be > compiled for all of the supported architectures by all of the supported > compilers. > Is there a

[clang] 3085bda - [analyzer][solver] Fix infeasible constraints (PR49642)

Author: Valeriy Savchenko Date: 2021-03-22T11:02:02+03:00 New Revision: 3085bda2b348f6a8b4e0bd1d230af4e9c900c9c4 URL: https://github.com/llvm/llvm-project/commit/3085bda2b348f6a8b4e0bd1d230af4e9c900c9c4 DIFF:

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3085bda2b348: [analyzer][solver] Fix infeasible constraints (PR49642) (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius added a comment. I'll fix the formatting with the next update. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1445-1461 + unsigned TokKind = 0; + switch (Tok.getKind()) { + case tok::kw_mutable: TokKind = 0; break; + case tok::arrow: TokKind = 1;

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

balazske added a comment. In D98951#2637807 , @shafik wrote: > Can we add a test for the `getCapturedVLAType` case? The test is added here: D99062 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2637186 , @steakhal wrote: > Ah, I wanted to give it a go, but the bots caught an assertion failure for > the parent revision of this. See the details at the Bugzilla ticket >

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S updated this revision to Diff 332236. Max_S added a comment. Fixed interaction between Before and After configurations options. Before handles the case of two access modifiers specification following each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. Hmm, the new test seems to cause an assertion failure in llvm code generation in Windows. Is anything known about that? Is the test case wrong in some way? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5075 + "};", + Style); +} MyDeveloperDay wrote: > I wonder if there should be other options > > i.e. > > ``` > struct new_struct

[PATCH] D98948: [analyzer][solver] Fix infeasible constraints (PR49642)

vsavchenko updated this revision to Diff 332211. vsavchenko added a comment. Re-write the test using %clang_analyze_cc1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98948/new/ https://reviews.llvm.org/D98948 Files:

[clang] 82f6e0d - [Driver] -m32: Add /usr/include/i386-linux-gnu for Debian

Author: Fangrui Song Date: 2021-03-22T01:27:06-07:00 New Revision: 82f6e0dde29e6c6da27f64db5992eb539a57d21b URL: https://github.com/llvm/llvm-project/commit/82f6e0dde29e6c6da27f64db5992eb539a57d21b DIFF: https://github.com/llvm/llvm-project/commit/82f6e0dde29e6c6da27f64db5992eb539a57d21b.diff

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

vsavchenko added a comment. In D86465#2640687 , @steakhal wrote: > Given that it did not change any reports in our testbench it seems to be safe > to land it. > > It clearly improves the API significantly, so I'm not opposing. > Really good work

[clang] 20d9326 - [OpenCL] Use -fdeclare-opencl-builtins for some tests

Author: Sven van Haastregt Date: 2021-03-22T09:46:28Z New Revision: 20d93267e18463292d54791f3c19211a85b27227 URL: https://github.com/llvm/llvm-project/commit/20d93267e18463292d54791f3c19211a85b27227 DIFF: https://github.com/llvm/llvm-project/commit/20d93267e18463292d54791f3c19211a85b27227.diff

[PATCH] D99063: [clang-format] Fix ObjC method indent after f7f9f94b

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit https://github.com/llvm/llvm-project/commit/f7f9f94b2e2b4c714bac9036f6b73a3df42daaff changed the indent of ObjC method arguments from +4 to +2,

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S marked 4 inline comments as done. Max_S added a comment. > The tests in line 9462 and 9466 require some additional implementation. > EmptyLineAfterAccessModifier is adding the three lines since it is configured > to do so, but EmptyLineBeforeAccessModifier would remove these lines. Since

[clang] 02b51e5 - [analyzer][solver] Redesign constraint ranges data structure

Author: Valeriy Savchenko Date: 2021-03-22T13:52:35+03:00 New Revision: 02b51e5316cd501ede547d0223e0f5416ebd9845 URL: https://github.com/llvm/llvm-project/commit/02b51e5316cd501ede547d0223e0f5416ebd9845 DIFF:

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02b51e5316cd: [analyzer][solver] Redesign constraint ranges data structure (authored by vsavchenko). Changed prior to commit:

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko added a comment. In D91949#2503646 , @MyDeveloperDay wrote: > I think the revision whilst it does what is needed to structs doesn't address > the many other times this forms appear. I think we need something a little > more

  1   2   >