r259537 - ARM: allow both vfma and vfms intrinsics on v7.

Author: tnorthover Date: Tue Feb 2 12:02:10 2016 New Revision: 259537 URL: http://llvm.org/viewvc/llvm-project?rev=259537=rev Log: ARM: allow both vfma and vfms intrinsics on v7. The main purpose here is that vfma/vfms should be symmetric, and they are supported on most v7 cores. The new

Re: r259507 - Make the remaining headers self-contained.

Out of curiosity, what technique were you using to find out if the headers were self-contained? Just "clang -c foo.h"? Cheers, Rafael On 2 February 2016 at 09:24, Benjamin Kramer via cfe-commits wrote: > Author: d0k > Date: Tue Feb 2 08:24:21 2016 > New Revision:

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16786#342074, @aaron.ballman wrote: > In http://reviews.llvm.org/D16786#342072, @Eugene.Zelenko wrote: > > > I think proper solution will be to create tests for included files ot the > > fly, bu renaming main test to .h and creating

Re: [PATCH] D16759: [OpenMP] Parsing + sema for target parallel for directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with small comment Comment at: lib/Parse/ParseOpenMP.cpp:185 @@ -182,3 +184,3 @@ /// 'distribute' | 'target enter data' | 'target exit data' | -///

Re: [PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. I'll wait for global options implementation. Repository: rL LLVM http://reviews.llvm.org/D16700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. I think proper solution will be to create tests for included files ot the fly, bu renaming main test to .h and creating dummy source file. But this is task for scripts wizards :-) Repository: rL LLVM http://reviews.llvm.org/D16794

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. I think proper solution will be to create tests for included files ot the fly, bu renaming main test to .h and creating dummy source file. But this is task for scripts wizards :-) Repository: rL LLVM http://reviews.llvm.org/D16786

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

aaron.ballman added a comment. In http://reviews.llvm.org/D16786#341938, @Eugene.Zelenko wrote: > I didn't notice test cases for included files for other checkers. So it's > hard to tell for should special test case introduced for this specific > problem or not. Generally speaking, all

Re: [PATCH] D16804: [analyzer] AnalysisConsumer: print fully-qualified function name while displaying progress

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thank you! http://reviews.llvm.org/D16804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

Richard, Please take another look when you get a chance. Thanks. On Tue, Feb 2, 2016 at 11:14 AM, Sterling Augustine wrote: > saugustine updated this revision to Diff 46680. > saugustine marked 19 inline comments as done. > saugustine added a comment. > > - Update docs.

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

aaron.ballman added a comment. In http://reviews.llvm.org/D16786#342075, @Eugene.Zelenko wrote: > In http://reviews.llvm.org/D16786#342074, @aaron.ballman wrote: > > > In http://reviews.llvm.org/D16786#342072, @Eugene.Zelenko wrote: > > > > > I think proper solution will be to create tests for

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. I didn't notice test cases for included files for other checkers. So it's hard to tell for should special test case introduced for this specific problem or not. Repository: rL LLVM http://reviews.llvm.org/D16786

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. I didn't notice test cases for included files for other checkers. So it's hard to tell for should special test case introduced for this specific problem or not. Repository: rL LLVM http://reviews.llvm.org/D16794

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

saugustine updated this revision to Diff 46680. saugustine marked 19 inline comments as done. saugustine added a comment. - Update docs. Handle keywords and anonymous namespaces. - Address code review issues. Cleanup many http://reviews.llvm.org/D15861 Files:

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

aaron.ballman added a comment. In http://reviews.llvm.org/D16786#342072, @Eugene.Zelenko wrote: > I think proper solution will be to create tests for included files ot the > fly, bu renaming main test to .h and creating dummy source file. But this is > task for scripts wizards :-) I'm not

r259591 - ObjCXX: fix a crash during typo correction.

Author: mren Date: Tue Feb 2 16:23:03 2016 New Revision: 259591 URL: http://llvm.org/viewvc/llvm-project?rev=259591=rev Log: ObjCXX: fix a crash during typo correction. For ObjCXX, we can create a CastExpr with Kind being CK_UserDefinedConversion and SubExpr being BlockExpr. Specifically one

[PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

sugak created this revision. sugak added reviewers: rsmith, rjmccall. sugak added subscribers: hans, cfe-commits. gcc-4.8.1 fails to build clang because of a regression in that version of gcc (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58022). See details about the generated error in

Re: [PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

rjmccall added a comment. LGTM, too. http://reviews.llvm.org/D16819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

eugenis created this revision. eugenis added reviewers: pcc, kcc. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. Avoid crashing when printing diagnostics for vtable-related CFI errors. In diagnostic mode, the frontend does an additional check of

[libunwind] r259571 - Creating release candidate rc2 from release_380 branch

Author: hans Date: Tue Feb 2 15:11:13 2016 New Revision: 259571 URL: http://llvm.org/viewvc/llvm-project?rev=259571=rev Log: Creating release candidate rc2 from release_380 branch Added: libunwind/tags/RELEASE_380/rc2/ - copied from r259570, libunwind/branches/release_38/

[libcxx] r259564 - Creating release candidate rc2 from release_380 branch

Author: hans Date: Tue Feb 2 15:10:52 2016 New Revision: 259564 URL: http://llvm.org/viewvc/llvm-project?rev=259564=rev Log: Creating release candidate rc2 from release_380 branch Added: libcxx/tags/RELEASE_380/rc2/ (props changed) - copied from r259563, libcxx/branches/release_38/

[libcxxabi] r259565 - Creating release candidate rc2 from release_380 branch

Author: hans Date: Tue Feb 2 15:10:55 2016 New Revision: 259565 URL: http://llvm.org/viewvc/llvm-project?rev=259565=rev Log: Creating release candidate rc2 from release_380 branch Added: libcxxabi/tags/RELEASE_380/rc2/ (props changed) - copied from r259564,

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:737 @@ +736,3 @@ +unsigned FuncParamNo, unsigned AttrArgNo) { + assert(Attr.getArg(AttrArgNo).is()); + // FuncParamNo is base-1 aaron.ballman

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv updated this revision to Diff 46693. george.burgess.iv marked 2 inline comments as done. george.burgess.iv added a comment. Addressed all feedback. http://reviews.llvm.org/D14274 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yuck. Yeah, LGTM. Do you need someone to commit this for you? Hans, this should go into 3.8 as well. http://reviews.llvm.org/D16819 ___

[PATCH] D16821: Add whole-program vtable optimization feature to Clang.

pcc created this revision. pcc added reviewers: joker.eph, pete, chandlerc. pcc added subscribers: hans, kcc, cfe-commits. This patch introduces the -fwhole-program-vtables flag, which enables the whole-program vtable optimization feature (D16795) in Clang. http://reviews.llvm.org/D16821 Files:

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

tra updated this revision to Diff 46696. tra marked 8 inline comments as done. tra added a comment. Addressed Richard's comments. Relaxed restrictions a bit to allow constant initializers even those CUDA would not considered to be empty. Updated test case accordingly.

Re: [PATCH] D16503: [MSVC Compat] Warn when suppressing a trailing comma in macro args

thakis added a comment. Sorry for the slow response. I was reading http://reviews.llvm.org/D15670 to understand this patch, and I couldn't find anything in that patch that enables this extension only in Microsoft mode. Trying suppressed-comma-msextension.cpp locally, it seems to pass without

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

> On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits > wrote: > > silvas added a comment. > > In http://reviews.llvm.org/D15829#333902, @davidxl wrote: > >> For the longer term, one possible solution is to make FE based >> instrumentation only used for

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

aaboud updated this revision to Diff 46708. aaboud added a comment. Reduced the LIT tests and added comment explaining part of it. http://reviews.llvm.org/D15977 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGDecl.cpp test/CodeGenCXX/debug-info-lb.cpp

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

eugenis added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2494 @@ +2493,3 @@ + llvm::Value *ValidVtable = nullptr; + if (CheckAndAppendValidVtable) { +llvm::Value *AllVtables = llvm::MetadataAsValue::get( samsonov wrote: > This is really ugly. Why

Re: r259598 - Work around build failure due to GCC 4.8.1 bug. We don't completely understand

Hans, this fixes a compile failure with one of our supported host compilers (GCC 4.8.1). Can we get this patch into 3.8? On Tue, Feb 2, 2016 at 3:11 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Tue Feb 2 17:11:49 2016 > New Revision: 259598 > >

r259592 - [CUDA] Do not allow dynamic initialization of global device side variables.

Author: tra Date: Tue Feb 2 16:29:48 2016 New Revision: 259592 URL: http://llvm.org/viewvc/llvm-project?rev=259592=rev Log: [CUDA] Do not allow dynamic initialization of global device side variables. In general CUDA does not allow dynamic initialization of global device-side variables. One

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

samsonov added a subscriber: samsonov. Comment at: lib/CodeGen/CGExpr.cpp:2494 @@ +2493,3 @@ + llvm::Value *ValidVtable = nullptr; + if (CheckAndAppendValidVtable) { +llvm::Value *AllVtables = llvm::MetadataAsValue::get( This is really ugly. Why are you not

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259592: [CUDA] Do not allow dynamic initialization of global device side variables. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D15305?vs=46696=46707#toc Repository: rL LLVM

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

eugenis added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2494 @@ +2493,3 @@ + llvm::Value *ValidVtable = nullptr; + if (CheckAndAppendValidVtable) { +llvm::Value *AllVtables = llvm::MetadataAsValue::get( pcc wrote: > eugenis wrote: > > samsonov

Re: [PATCH] D16503: [MSVC Compat] Warn when suppressing a trailing comma in macro args

ehsan added a comment. In http://reviews.llvm.org/D16503#342116, @thakis wrote: > Sorry for the slow response. I was reading http://reviews.llvm.org/D15670 to > understand this patch, and I couldn't find anything in that patch that > enables this extension only in Microsoft mode. Trying >

Re: [PATCH] D16819: Remove llvm::(cast|isa) from lib/CodeGen/Address.h to fix build with gcc-4.8.1

rsmith closed this revision. rsmith added a comment. Thanks, committed as r259598. http://reviews.llvm.org/D16819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r259598 - Work around build failure due to GCC 4.8.1 bug. We don't completely understand

Yes! r259603. Cheers, Hans On Tue, Feb 2, 2016 at 3:17 PM, Richard Smith wrote: > Hans, this fixes a compile failure with one of our supported host > compilers (GCC 4.8.1). Can we get this patch into 3.8? > > On Tue, Feb 2, 2016 at 3:11 PM, Richard Smith via cfe-commits >

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

dblaikie added a comment. Looks good - though you could do that one further simplification to the test case, I think. (removing x/if x) Comment at: test/CodeGenCXX/debug-info-lb.cpp:5 @@ +4,3 @@ + static int bar = 1; + if (x) + { Looks like you could remove

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

pcc added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2494 @@ +2493,3 @@ + llvm::Value *ValidVtable = nullptr; + if (CheckAndAppendValidVtable) { +llvm::Value *AllVtables = llvm::MetadataAsValue::get( eugenis wrote: > samsonov wrote: > > This is

r259604 - Fix rejects-valid when forming a pointer-to-member with 'decltype(expr)::*'.

Author: rsmith Date: Tue Feb 2 17:34:49 2016 New Revision: 259604 URL: http://llvm.org/viewvc/llvm-project?rev=259604=rev Log: Fix rejects-valid when forming a pointer-to-member with 'decltype(expr)::*'. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/trunk/test/Parser/cxx0x-decl.cpp

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#340515, @nemanjai wrote: > If the reviewers don't mind, I would like to keep this patch with diagnostics > for interoperability between the two types for now. This is simply because > enabling such interoperability

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

samsonov added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2642 @@ +2641,3 @@ + llvm::MDString::get(CGM.getLLVMContext(), "all-vtables")); + llvm::Value *ValidVtable = Builder.CreateZExt( + Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::bitset_test),

r259609 - PR24989: Stop trying to use the C++11 rules for lambda return type inference in

Author: rsmith Date: Tue Feb 2 17:58:56 2016 New Revision: 259609 URL: http://llvm.org/viewvc/llvm-project?rev=259609=rev Log: PR24989: Stop trying to use the C++11 rules for lambda return type inference in C++14 generic lambdas. It conflicts with the C++14 return type deduction mechanism, and

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

eugenis updated this revision to Diff 46718. eugenis added a comment. Moved bitset.text call outside. LLVM is smart enough to sink it along the cold branch, so performance should not suffer. Repository: rL LLVM http://reviews.llvm.org/D16823 Files: lib/CodeGen/CGClass.cpp

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

ahatanak updated this revision to Diff 46725. ahatanak added a comment. Sorry for taking so long to get back to this patch. I've updated the patch based on your review comments. I defined a new helper function getAArch64FeaturesFromCPU which gets the target features from the cpu name and

Re: [PATCH] D16638: [CUDA] Added device-side std::{malloc/free}

tra updated this revision to Diff 46729. tra added a comment. Added few more device-side system calls and related wrapper functions. Added nothrow attributes on malloc/free. http://reviews.llvm.org/D16638 Files: lib/Headers/__clang_cuda_runtime_wrapper.h Index:

r259618 - Fix typo in OpenCL type mangling. This is still bogus (we should either use the

Author: rsmith Date: Tue Feb 2 19:43:59 2016 New Revision: 259618 URL: http://llvm.org/viewvc/llvm-project?rev=259618=rev Log: Fix typo in OpenCL type mangling. This is still bogus (we should either use the actual source name of the typedef or a vendor mangling) but at least it stands a chance

Fwd: [cfe-commits] r170428 [1/3] - in /cfe/trunk: include/clang/AST/ include/clang/Basic/ include/clang/Sema/ include/clang/Serialization/ lib/AST/ lib/CodeGen/ lib/Parse/ lib/Sema/ lib/Serialization/

Hi Guy, > Modified: cfe/trunk/lib/CodeGen/CGRTTI.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRTTI.cpp?rev=170428=170427=170428=diff > == > --- cfe/trunk/lib/CodeGen/CGRTTI.cpp (original) >

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

tra added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:429-430 @@ +428,4 @@ + CXXConstructorDecl *CD) { + if (!CD->isDefined() && CD->isTemplateInstantiation()) +InstantiateFunctionDefinition(VarLoc, CD->getFirstDecl()); +

r259616 - Fix Itanium RTTI emission so that we emit fundamental type information into the

Author: rsmith Date: Tue Feb 2 19:32:42 2016 New Revision: 259616 URL: http://llvm.org/viewvc/llvm-project?rev=259616=rev Log: Fix Itanium RTTI emission so that we emit fundamental type information into the C++ ABI library for the same set of types for which we expect the C++ ABI library to

Re: [cfe-commits] r170428 [1/3] - in /cfe/trunk: include/clang/AST/ include/clang/Basic/ include/clang/Sema/ include/clang/Serialization/ lib/AST/ lib/CodeGen/ lib/Parse/ lib/Sema/ lib/Serialization/

Fixed as part of r259616. On Tue, Feb 2, 2016 at 4:45 PM, Richard Smith wrote: > Hi Guy, > >> Modified: cfe/trunk/lib/CodeGen/CGRTTI.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRTTI.cpp?rev=170428=170427=170428=diff >>

Re: r259507 - Make the remaining headers self-contained.

On Tue, Feb 2, 2016 at 11:11 AM, Rafael Espíndola < cfe-commits@lists.llvm.org> wrote: > Out of curiosity, what technique were you using to find out if the > headers were self-contained? Just "clang -c foo.h"? > Building LLVM & Clang with C++ modules enabled > > Cheers, > Rafael > > > On 2

r259628 - clang-format: [JS/TypeScript] Support "enum" as an optional property name, too.

Author: djasper Date: Tue Feb 2 23:33:44 2016 New Revision: 259628 URL: http://llvm.org/viewvc/llvm-project?rev=259628=rev Log: clang-format: [JS/TypeScript] Support "enum" as an optional property name, too. Before: enum?: string []; After: enum?: string[]; Modified:

Re: [PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

rnk added a comment. If the ABI is still open to small changes and clarifications, can we make sure that C and C++ empty structs are passed the same way? Unfortunately, on normal x86_64 SysV GCC doesn't pass them the same way and Clang has to follow suit. http://reviews.llvm.org/D16808

Re: [PATCH] D16801: [OpenMP] Change in initial size of DSAStackTy::StackTy

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG. Will you commit it yourself or you want me to do this? http://reviews.llvm.org/D16801 ___ cfe-commits mailing list

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

ariccio updated this revision to Diff 46737. ariccio marked 2 inline comments as done. ariccio added a comment. Removed single `const`. http://reviews.llvm.org/D16748 Files: C:/LLVM/llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h

Re: [PATCH] D16748: Cleanup MemRegion.cpp/MemRegion.h

ariccio added a comment. All set. http://reviews.llvm.org/D16748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14274: Add alloc_size attribute to clang

aaron.ballman added a comment. The attribute part looks mostly good (a few small nits), but the rest should be reviewed by @rsmith. Comment at: lib/Sema/SemaDeclAttr.cpp:737 @@ +736,3 @@ +unsigned FuncParamNo, unsigned AttrArgNo) { +

r259506 - [StaticAnalyzer] Pull SymExpr and SymbolData into its own header to avoid cyclic includes.

Author: d0k Date: Tue Feb 2 08:24:11 2016 New Revision: 259506 URL: http://llvm.org/viewvc/llvm-project?rev=259506=rev Log: [StaticAnalyzer] Pull SymExpr and SymbolData into its own header to avoid cyclic includes. Added: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SymExpr.h

r259507 - Make the remaining headers self-contained.

Author: d0k Date: Tue Feb 2 08:24:21 2016 New Revision: 259507 URL: http://llvm.org/viewvc/llvm-project?rev=259507=rev Log: Make the remaining headers self-contained. Modified: cfe/trunk/include/clang/AST/BaseSubobject.h cfe/trunk/include/clang/AST/DeclOpenMP.h

Re: [PATCH] D16717: [clang-tidy] Add non-constant references in function parameters check.

hokein updated this revision to Diff 46628. hokein added a comment. Address comments. http://reviews.llvm.org/D16717 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/GoogleTidyModule.cpp clang-tidy/google/NonConstReferences.cpp clang-tidy/google/NonConstReferences.h

Re: [PATCH] D16717: [clang-tidy] Add non-constant references in function parameters check.

hokein marked 4 inline comments as done. hokein added a comment. http://reviews.llvm.org/D16717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline

bsmith added a comment. Ping. Repository: rL LLVM http://reviews.llvm.org/D15283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259487 - clang-format: Make AlignAfterOpenBracket also affect angle brackets.

Author: djasper Date: Tue Feb 2 04:28:11 2016 New Revision: 259487 URL: http://llvm.org/viewvc/llvm-project?rev=259487=rev Log: clang-format: Make AlignAfterOpenBracket also affect angle brackets. Patch by Matthew Whitehead, thank you. Modified:

Re: [PATCH] D16630: PR23057: Fix assertion `Val && "isa<> used on a null pointer"' on invalid for-range expression

d.zobnin.bugzilla added inline comments. Comment at: lib/Parse/ParseStmt.cpp:1719-1724 @@ -1718,6 +1718,8 @@ if (ForRange) { +ExprResult CorrectedRange = +Actions.CorrectDelayedTyposInExpr(ForRangeInit.RangeExpr.get()); ForRangeStmt =

Re: [PATCH] D16586: Make clang AAPCS compliant w.r.t volatile bitfield accesses

rmaprath added inline comments. Comment at: test/CodeGen/aapcs-bitfield.c:312-317 @@ +311,8 @@ + + // BE: %[[PTR3:.*]] = bitcast %struct.st5a* %[[PTR2]] to i32* + // BE-NEXT: %[[LD:.*]] = load volatile i32, i32* %[[PTR3]], align 4 + // BE-NEXT: %[[CLR:.*]] = and i32 %[[LD]],

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

pxli168 added inline comments. Comment at: lib/Sema/SemaStmtAttr.cpp:208 @@ +207,3 @@ +SourceRange Range) { + assert(A.getKind() == AttributeList::AT_OpenCLUnrollHint); + This is also not necessary because this function can be

[PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

d.zobnin.bugzilla created this revision. d.zobnin.bugzilla added reviewers: mkuper, rnk, DavidKreitzer. d.zobnin.bugzilla added a subscriber: cfe-commits. Add missing check for zero-sized type for MCU ABI in order to return zero-sized types (empty structs and unions) via memory.

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

yaxunl updated this revision to Diff 46651. yaxunl marked 9 inline comments as done. yaxunl added a comment. Revised as Xiuli and Anastasia suggested. http://reviews.llvm.org/D16686 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D16682: 19957 - OpenCL incorrectly accepts implicit address space conversion with ternary operator

ichesnokov added inline comments. Comment at: test/CodeGenOpenCL/ternary-implicit-casts-fail.cl:2 @@ +1,3 @@ +// RUN: %clang_cc1 %s +// XFAIL: * + ichesnokov wrote: > asl wrote: > > ichesnokov wrote: > > > asl wrote: > > > > Don't do XFAIL tests - they will be

r259518 - Make CodeGen headers self-contained.

Author: d0k Date: Tue Feb 2 10:05:18 2016 New Revision: 259518 URL: http://llvm.org/viewvc/llvm-project?rev=259518=rev Log: Make CodeGen headers self-contained. Modified: cfe/trunk/lib/CodeGen/CGRecordLayout.h Modified: cfe/trunk/lib/CodeGen/CGRecordLayout.h URL:

Re: [PATCH] D16630: PR23057: Fix assertion `Val && "isa<> used on a null pointer"' on invalid for-range expression

majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D16630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16572: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression

majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D16572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

ichesnokov removed rL LLVM as the repository for this revision. ichesnokov updated this revision to Diff 46634. ichesnokov added a comment. Warnings added to the case. Turned off by default: Original bahavior: "// If we have a redefinition of a typedef in C, emit a warning. This warning // is

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

ichesnokov marked 3 inline comments as done. Comment at: test/SemaOpenCL/implicit-typedef.cl:2 @@ +1,2 @@ +// RUN: %clang_cc1 %s -cl-std=CL2.0 -verify -pedantic -fsyntax-only -Wsystem-headers +typedef atomic_int atomic_flag; // expected-warning {{redefinition of typedef

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added inline comments. Comment at: lib/Sema/SemaStmtAttr.cpp:225 @@ +224,3 @@ +Expr *E = A.getArgAsExpr(0); +assert(E != nullptr && "Invalid opencl_unroll_hint argument"); +llvm::APSInt ArgVal(32); pxli168 wrote: > Is this necessary as you

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

aaron.ballman added a comment. Missing a test case for this functionality. The isExpansionInMainFile() was used to silence the diagnostic in macros, but it was pointed out during review that this should be fixed and it seems to have fallen through the cracks. Can you also add tests for macros

r259490 - Make headers self-contained.

Author: d0k Date: Tue Feb 2 05:06:57 2016 New Revision: 259490 URL: http://llvm.org/viewvc/llvm-project?rev=259490=rev Log: Make headers self-contained. Modified: cfe/trunk/include/clang/Lex/HeaderMap.h cfe/trunk/include/clang/Lex/MacroArgs.h cfe/trunk/lib/Analysis/BodyFarm.h

r259491 - [OpenCL] Eliminate warning when declaring OpenCL builtin functions.

Author: stulova Date: Tue Feb 2 05:29:43 2016 New Revision: 259491 URL: http://llvm.org/viewvc/llvm-project?rev=259491=rev Log: [OpenCL] Eliminate warning when declaring OpenCL builtin functions. OpenCL builtin functions are usually declared in header files. Currently clang emits warning for

[PATCH] D16801: [OpenMP] Change in initial size of DSAStackTy::StackTy

esakella created this revision. esakella added a subscriber: ABataev. Hello, I have made a small change in the initial size of the StackTy SmallVector of class DSAStackTy. I reduced the initial size of this SmallVector from 64 elements to 4 elements, in order to improve the memory

r259489 - Move DebugInfoKind into its own header to cut the cyclic dependency edge from Driver to Frontend.

Author: d0k Date: Tue Feb 2 05:06:51 2016 New Revision: 259489 URL: http://llvm.org/viewvc/llvm-project?rev=259489=rev Log: Move DebugInfoKind into its own header to cut the cyclic dependency edge from Driver to Frontend. Added: cfe/trunk/include/clang/Driver/DebugInfoKind.h Modified:

[PATCH] D16804: [analyzer] AnalysisConsumer: print fully-qualified function name while displaying progress

a.sidorin created this revision. a.sidorin added reviewers: xazax.hun, zaks.anna, dcoughlin. a.sidorin added a subscriber: cfe-commits. -analyzer-display progress option prints only function names which may be suspicious. This patch forces AnalysisConsumer to print fully-qualified function

Re: [PATCH] D16376: clang-tidy check: Assignment and Construction

aaron.ballman added inline comments. Comment at: clang-tidy/misc/AssignmentAndConstructionCheck.cpp:91 @@ +90,3 @@ + case AssignmentAndConstructionCheck::SpecialFunctionKind::CopyConstructor: +return "class '%0' defines a copy-constructor but not a copy-assignment " +

Re: [PATCH] D16539: [FIX] 26194 - LLVM crash in CXXNameMangler::mangleType

ichesnokov added a comment. Please support discussion about MicrosoftMangle+CL at https://llvm.org/bugs/show_bug.cgi?id=26194 Comment at: tools/driver/driver.cpp:367 @@ -367,1 +366,3 @@ +int Result = ExecuteCC1Tool(argv, argv[1] + 4); +return Result; // Useful for

Re: [PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

hjl.tools added a subscriber: hjl.tools. hjl.tools added a comment. Why should empty structs and unions) be return in memory? I don't remember I called for it in MCU psABI. http://reviews.llvm.org/D16808 ___ cfe-commits mailing list

Re: [PATCH] D16717: [clang-tidy] Add non-constant references in function parameters check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Thank you! Comment at: test/clang-tidy/google-runtime-references.cpp:1 @@ +1,2 @@ +// RUN: %check_clang_tidy %s google-runtime-references %t -- --

Re: [PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:366 @@ +365,3 @@ + binaryOperator( + isExpansionInMainFile(), hasOperatorName(OperatorName), + hasLHS(allOf( aaron.ballman wrote: >

Re: [PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

LegalizeAdulthood added a comment. I do not have commit access. If someone could commit this for me, I would appreciate it. Patch by Richard Thomson. Thanks. http://reviews.llvm.org/D16308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r259530 - [clang-tidy] Add non-constant references in function parameters check.

Author: alexfh Date: Tue Feb 2 11:27:01 2016 New Revision: 259530 URL: http://llvm.org/viewvc/llvm-project?rev=259530=rev Log: [clang-tidy] Add non-constant references in function parameters check. Summary: This is implemented originally by Alexander Kornienko. Reviewers: alexfh Subscribers:

Re: [PATCH] D16717: [clang-tidy] Add non-constant references in function parameters check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259530: [clang-tidy] Add non-constant references in function parameters check. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D16717?vs=46628=4#toc Repository: rL LLVM

[clang-tools-extra] r259531 - [clang-tidy] Removed unnecessary parameters in the test

Author: alexfh Date: Tue Feb 2 11:27:08 2016 New Revision: 259531 URL: http://llvm.org/viewvc/llvm-project?rev=259531=rev Log: [clang-tidy] Removed unnecessary parameters in the test Modified: clang-tools-extra/trunk/test/clang-tidy/google-runtime-references.cpp Modified:

Re: [PATCH] D16788: PS4 ABI Round 2. Actual PS4 code.

probinson added inline comments. Comment at: include/clang/Basic/TargetCXXABI.h:118 @@ -115,1 +117,3 @@ +/// in LLVM 3.2. +PS4 }; rjmccall wrote: > I'm not sure why you added a new C++ ABI kind here. The bug fix you're > opting out of is not at all

RE: r259489 - Move DebugInfoKind into its own header to cut the cyclic dependency edge from Driver to Frontend.

Maybe Basic would be a better home for the new header? Having CodeGen pull in something from Driver seems weird and unprecedented. Thanks, --paulr > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Benjamin Kramer via cfe-commits > Sent:

Re: [PATCH] D16788: PS4 ABI Round 2. Actual PS4 code.

rjmccall added inline comments. Comment at: include/clang/Basic/TargetCXXABI.h:118 @@ -115,1 +117,3 @@ +/// in LLVM 3.2. +PS4 }; probinson wrote: > rjmccall wrote: > > I'm not sure why you added a new C++ ABI kind here. The bug fix you're > > opting

Re: [PATCH] D16630: PR23057: Fix assertion `Val && "isa<> used on a null pointer"' on invalid for-range expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL259532: PR23057: Fix assertion `Val && "isa<> used on a null pointer"' on invalid for… (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D16630?vs=46131=46669#toc Repository:

[PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

ahatanak created this revision. ahatanak added reviewers: doug.gregor, rjmccall, vsk. ahatanak added a subscriber: cfe-commits. This patch fixes a bug in the code between line 117-126 of TypeLocBuilder.cpp which was causing the assert in line 132. The bug manifests itself when an element of

Re: r259507 - Make the remaining headers self-contained.

On Tue, Feb 2, 2016 at 11:15 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Feb 2, 2016 at 11:11 AM, Rafael Espíndola < > cfe-commits@lists.llvm.org> wrote: > >> Out of curiosity, what technique were you using to find out if the >> headers were

Re: [PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeCommon.h:1 @@ +1,2 @@ +//=== CGOpenMPRuntimeCommon.h - Helpers for OpenMP Runtimes Codegen ==// +// I don't think we need this new file and new namespace. If some (currently) internal

  1   2   >