[PATCH] D99145: [clang] Fix a crash when CTAD fails

kadircet created this revision. kadircet added a reviewer: hokein. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99145 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

khchen added a comment. In D99082#2643322 , @jrtc27 wrote: > Most likely because you're adding assembly tests in Clang, which won't work > if the backend isn't present (and needs a REQUIRES line). Assembly tests in > Clang are generally bad practice and

[clang] 10cc5bc - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-22T23:09:41-05:00 New Revision: 10cc5bcd868c433f9a781aef82178b04e98bd098 URL: https://github.com/llvm/llvm-project/commit/10cc5bcd868c433f9a781aef82178b04e98bd098 DIFF:

[PATCH] D97993: [Driver] Suppress GCC detection under -B

MaskRay added a comment. In D97993#2643318 , @vvereschaka wrote: > `CHECK: "-internal-isystem" "/usr/local/include"` didn't break the test on > the cross builders before. > > Also, the `// CHECK: >

[PATCH] D98943: [clang][deps] NFC: Extract ModuleID struct

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98943/new/ https://reviews.llvm.org/D98943

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

rsmith added a comment. Ah, I think I see how we get here. I think this fix might possibly break a case such as: template int x = [](auto){ return T(); }.operator()(T()); int y = x; ... where transforming the call to `operator()` might end up looking for the transformed version of the

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

rsmith added a comment. Hm, do we ever call `FindInstantiatedDecl` on a lambda class in the first place? It seems plausible to me that this condition is unreachable. But to the extent that it's reachable, it seems mostly correct: a lambda expression appearing in a non-dependent context might

[clang] b5e96e0 - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-22T22:25:28-05:00 New Revision: b5e96e0ad601bddbf102606d7a3d8ae6e68d1688 URL: https://github.com/llvm/llvm-project/commit/b5e96e0ad601bddbf102606d7a3d8ae6e68d1688 DIFF:

[clang] d8e574c - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-22T22:08:43-05:00 New Revision: d8e574c8e690841ea3f8a607b383c314043b70a0 URL: https://github.com/llvm/llvm-project/commit/d8e574c8e690841ea3f8a607b383c314043b70a0 DIFF:

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. The previous commit is https://github.com/llvm/llvm-project/commit/a86bc00, and I don't understand enough of what the other code is doing to know if anything else needs to be fixed. I'd also like to add in a test to ensure this doesn't regress in the future, but I'm

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. It looks like this change was originally added 9 years ago with a commit message of "Lambda closure types are always considered to be like "local" classes, even if they are not within a function scope. Teach template instantiation to treat them as such, and make sure

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone created this revision. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99134 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp Index:

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

jrtc27 added a comment. Most likely because you're adding assembly tests in Clang, which won't work if the backend isn't present (and needs a REQUIRES line). Assembly tests in Clang are generally bad practice and best avoided for that reason. If you do want them it's probably best to split

[clang] 3775d81 - Improve module dumping for debugging.

Author: Richard Smith Date: 2021-03-22T19:07:46-07:00 New Revision: 3775d811ff6dc1ed844aee7d15263a447ee18d52 URL: https://github.com/llvm/llvm-project/commit/3775d811ff6dc1ed844aee7d15263a447ee18d52 DIFF: https://github.com/llvm/llvm-project/commit/3775d811ff6dc1ed844aee7d15263a447ee18d52.diff

[PATCH] D97993: [Driver] Suppress GCC detection under -B

vvereschaka added a comment. `CHECK: "-internal-isystem" "/usr/local/include"` didn't break the test on the cross builders before. Also, the `// CHECK: "-L[[TOOLCHAIN]]/usr/lib/i386-linux-gnu/gcc/i686-linux-gnu/4.5/../../../.."` check now is failing also (line 31). I tried to temporary

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

khchen added a comment. I need to take a look why Buildbot run failed: https://lab.llvm.org/buildbot/#/builders/139/builds/1615 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/ https://reviews.llvm.org/D99082

[clang] 1ea07ee - Revert "[RISCV][NFC] Fix RVV intrinsic tests."

Author: Zakk Chen Date: 2021-03-22T18:51:48-07:00 New Revision: 1ea07ee45347d713166beeb0b3ebf3d1a3b2a463 URL: https://github.com/llvm/llvm-project/commit/1ea07ee45347d713166beeb0b3ebf3d1a3b2a463 DIFF: https://github.com/llvm/llvm-project/commit/1ea07ee45347d713166beeb0b3ebf3d1a3b2a463.diff

[clang] ab082b5 - [RISCV][NFC] Fix RVV intrinsic tests.

Author: Zakk Chen Date: 2021-03-22T18:24:03-07:00 New Revision: ab082b582dd01becc0e0dbb0ff28371e0ce392a9 URL: https://github.com/llvm/llvm-project/commit/ab082b582dd01becc0e0dbb0ff28371e0ce392a9 DIFF: https://github.com/llvm/llvm-project/commit/ab082b582dd01becc0e0dbb0ff28371e0ce392a9.diff

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGab082b582dd0: [RISCV][NFC] Fix RVV intrinsic tests. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/

[clang] bef2cb9 - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-22T20:23:07-05:00 New Revision: bef2cb90625e08cef0cbe7a63bcf91c81c44a443 URL: https://github.com/llvm/llvm-project/commit/bef2cb90625e08cef0cbe7a63bcf91c81c44a443 DIFF:

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/rv32Zbr.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32 -mattr=experimental-zbr -verify-machineinstrs < %s \ craig.topper wrote: >

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rv32Zbr.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32 -mattr=experimental-zbr -verify-machineinstrs < %s \ jrtc27 wrote: >

[PATCH] D99126: [darwin][driver] Pass through -global-isel LLVM flags to ld.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66af90b46e1f: [darwin][driver] Pass through -global-isel LLVM flags to ld. (authored by aemerson). Repository: rG LLVM Github Monorepo CHANGES

[clang] 66af90b - [darwin][driver] Pass through -global-isel LLVM flags to ld.

Author: Amara Emerson Date: 2021-03-22T17:23:06-07:00 New Revision: 66af90b46e1fe395806474dde2d49b8dc78bae1a URL: https://github.com/llvm/llvm-project/commit/66af90b46e1fe395806474dde2d49b8dc78bae1a DIFF: https://github.com/llvm/llvm-project/commit/66af90b46e1fe395806474dde2d49b8dc78bae1a.diff

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2642782 , @dblaikie wrote: > In D97411#2642194 , @akhuang wrote: > >>> Hmm - is that type used in a way that invokes Undefined Behavior? Or is >>> this a gap/bug in the ctor

[PATCH] D99126: [darwin][driver] Pass through -global-isel LLVM flags to ld.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99126/new/ https://reviews.llvm.org/D99126

[PATCH] D99126: [darwin][driver] Pass through -global-isel LLVM flags to ld.

aemerson created this revision. aemerson added reviewers: paquette, ahmed, qcolombet, pete. aemerson added a project: clang. Herald added subscribers: steven_wu, hiraditya. aemerson requested review of this revision. GlobalISel is currently not enabled when using -flto since the front-end -mvllm

[PATCH] D98775: [AST] Add introspection support for Decls

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c65dfc895d0: [AST] Add introspection support for Decls (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D98775?vs=332160=332469#toc Repository: rG LLVM Github Monorepo

[clang] 4c65dfc - [AST] Add introspection support for Decls

Author: Stephen Kelly Date: 2021-03-22T23:16:02Z New Revision: 4c65dfc895d03d1c3bfa1ccfe9567c9ea8557492 URL: https://github.com/llvm/llvm-project/commit/4c65dfc895d03d1c3bfa1ccfe9567c9ea8557492 DIFF: https://github.com/llvm/llvm-project/commit/4c65dfc895d03d1c3bfa1ccfe9567c9ea8557492.diff

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added inline comments. Comment at: llvm/utils/gn/secondary/llvm/lib/Transforms/Utils/BUILD.gn:64 "PromoteMemoryToRegister.cpp", +"RelLookupTableConverter.cpp" "SSAUpdater.cpp", thakis wrote: > leonardchan wrote: > > Good that you added this,

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:90 +// equivalent integer vector type with EEW and corresponding ELMUL (elmul = +// (eew/sew) * lmul). Fore example, vector type is __rvv_float16m4 +// (SEW=16, LMUL=4) and

[PATCH] D94355: [Passes] Add relative lookup table converter pass

thakis added inline comments. Comment at: llvm/utils/gn/secondary/llvm/lib/Transforms/Utils/BUILD.gn:64 "PromoteMemoryToRegister.cpp", +"RelLookupTableConverter.cpp" "SSAUpdater.cpp", leonardchan wrote: > Good that you added this, but I think Nico

[PATCH] D94355: [Passes] Add relative lookup table converter pass

This revision was automatically updated to reflect the committed changes. Closed by commit rG78a65cd945d0: [Passes] Add relative lookup table converter pass (authored by gulfem). Changed prior to commit: https://reviews.llvm.org/D94355?vs=331139=332445#toc Repository: rG LLVM Github

[clang] 3c67653 - [docs] Clarify which part of the "refers to" rule for lifetimebound is

Author: Richard Smith Date: 2021-03-22T15:06:20-07:00 New Revision: 3c67653ef4e3f5278b4f278cb2b181a1fe3c4f27 URL: https://github.com/llvm/llvm-project/commit/3c67653ef4e3f5278b4f278cb2b181a1fe3c4f27 DIFF: https://github.com/llvm/llvm-project/commit/3c67653ef4e3f5278b4f278cb2b181a1fe3c4f27.diff

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. In D97411#2642194 , @akhuang wrote: >> Hmm - is that type used in a way that invokes Undefined Behavior? Or is this >> a gap/bug in the ctor homing? I thought there was already a special case for >> constexpr ctors that opted

[PATCH] D99117: Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

rsmith added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3038-3039 +is considered to refer to its underlying array, and aggregates (arrays and +simple ``struct``s) are considered to refer to all objects that their +subobjects refer to. +

[PATCH] D99117: Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fab60377c1a: Attempt to further improve the documentation for the [[clang::lifetimebound]]… (authored by rsmith). Changed prior to commit:

[clang] 5fab603 - Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

Author: Richard Smith Date: 2021-03-22T15:03:42-07:00 New Revision: 5fab60377c1afec872235747d99ef6b7c508e4f8 URL: https://github.com/llvm/llvm-project/commit/5fab60377c1afec872235747d99ef6b7c508e4f8 DIFF: https://github.com/llvm/llvm-project/commit/5fab60377c1afec872235747d99ef6b7c508e4f8.diff

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

dblaikie added a comment. In D99107#2642451 , @rnk wrote: > We try to uphold the invariant that -g flags do not affect generated code, so > I don't think we should do this. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99117: Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/AttrDocs.td:3038-3039 +is considered to refer to its underlying array, and aggregates (arrays and +simple ``struct``s) are

[PATCH] D99117: Attempt to further improve the documentation for the [[clang::lifetimebound]] attribute.

rsmith created this revision. rsmith added a reviewer: dblaikie. Herald added a reviewer: aaron.ballman. rsmith requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99117 Files: clang/include/clang/Basic/AttrDocs.td

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. > I think you probably need to add new files for the tests, e.g. > `matrix-type-casts.cpp` & `matrix-type-casts.c` and then just add tests for > various valid cast combinations. Is that enough to get you started? You can > look at some of the existing matrix codegen

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added a comment. Thanks for the patch! I think this also needs changes in code-gen & code-gen tests. In D99037#2642598 , @SaurabhJha wrote: > In D99037#2640388 , @fhahn wrote: > >> Thanks for the patch! I

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

zequanwu abandoned this revision. zequanwu added a comment. This overlaps with the functionality of attribute `used`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98295/new/ https://reviews.llvm.org/D98295

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

nick added a comment. Is this hack actually needed? I could not reproduce a problem with https://bugs.chromium.org/p/chromium/issues/detail?id=860398#c13 repro, the breakpoint fires for me and I see the variable. The difference with the hack and without, using `clang.exe src.cpp -S

Re: [clang] 5c689e4 - Improve documentation for the [[clang::lifetimebound]] attribute.

On Mon, 22 Mar 2021 at 13:31, David Blaikie wrote: > On Thu, Mar 18, 2021 at 7:58 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: Richard Smith >> Date: 2021-03-18T19:58:21-07:00 >> New Revision: 5c689e4bb0473e08645547ddbf9874b5e2fa04d0 >> >> URL: >>

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. In D99037#2640388 , @fhahn wrote: > Thanks for the patch! I think this also needs changes in code-gen & code-gen > tests. Hey @fhahn I searched but could not find the relevant code-gen and code-gen tests I need to fix. Can

[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3134d7c44f1: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair. (authored by haberman, committed by rsmith). Repository: rG

[clang] c3134d7 - [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

Author: Joshua Haberman Date: 2021-03-22T14:13:42-07:00 New Revision: c3134d7c44f1059889dfee698dff415f7c2e1620 URL: https://github.com/llvm/llvm-project/commit/c3134d7c44f1059889dfee698dff415f7c2e1620 DIFF:

[PATCH] D99108: [RISCV] Add XFAIL riscv32 for known issue with the old pass manager

luismarques created this revision. luismarques added a reviewer: asb. Herald added subscribers: vkmr, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook. luismarques requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

nick added a comment. In D99107#2642451 , @rnk wrote: > We try to uphold the invariant that -g flags do not affect generated code, so > I don't think we should do this. Even under `-O0`? I could change the check to always emit on `-O0`. With

Re: [clang] a00d440 - [AST] Hide errors from the attempt to introspect nodes

Is this missing a test case? On Tue, Mar 16, 2021 at 4:47 PM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Stephen Kelly > Date: 2021-03-16T23:46:31Z > New Revision: a00d44012820e9ed2eba623dd61ca9cf5a2ce115 > > URL: >

Re: [clang] 5c689e4 - Improve documentation for the [[clang::lifetimebound]] attribute.

On Thu, Mar 18, 2021 at 7:58 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2021-03-18T19:58:21-07:00 > New Revision: 5c689e4bb0473e08645547ddbf9874b5e2fa04d0 > > URL: >

[clang] 424bf5d - [Driver] Bring back "Clean up Debian multiarch /usr/include/ madness" and restore i586-linux-gnu

Author: Fangrui Song Date: 2021-03-22T13:25:35-07:00 New Revision: 424bf5d8918f6356f1b8e99205c5fc8b4783ca22 URL: https://github.com/llvm/llvm-project/commit/424bf5d8918f6356f1b8e99205c5fc8b4783ca22 DIFF: https://github.com/llvm/llvm-project/commit/424bf5d8918f6356f1b8e99205c5fc8b4783ca22.diff

[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

njames93 added a comment. Herald added a project: clang-tools-extra. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98275/new/ https://reviews.llvm.org/D98275 ___ cfe-commits mailing list

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; usaxena95 wrote: > kadircet wrote: > > this

[PATCH] D98867: [HIP] Fix ROCm detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG282bf9eaf7b1: [HIP] Fix ROCm detection (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98867/new/

[clang] 282bf9e - [HIP] Fix ROCm detection

Author: Yaxun (Sam) Liu Date: 2021-03-22T16:10:02-04:00 New Revision: 282bf9eaf7b1fc28fd60a177b97dc1ce9f220352 URL: https://github.com/llvm/llvm-project/commit/282bf9eaf7b1fc28fd60a177b97dc1ce9f220352 DIFF:

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

rnk added a comment. We try to uphold the invariant that -g flags do not affect generated code, so I don't think we should do this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99107/new/ https://reviews.llvm.org/D99107

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

rprichard added a comment. In D96403#2639210 , @srhines wrote: > It is actually using `clang-r416183` from toolchains.py > . > From there, you

[PATCH] D98889: [clang] Replaced some manual pointer tagging with llvm::PointerIntPair.

haberman updated this revision to Diff 332405. haberman added a comment. Updated change to reflect all diffs since main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98889/new/ https://reviews.llvm.org/D98889 Files:

[PATCH] D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info

nick created this revision. nick added reviewers: akhuang, rnk, aprantl. nick requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When no debug information is emitted there is no point in emitting a hack introduced in D63361

[PATCH] D99106: [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor

njames93 created this revision. njames93 added reviewers: aaron.ballman, klimek, steveire. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Saves having to manually deallocate storage and keeps InnerArgs will have good cache

[clang] 3e32e8c - [test] Bring back the improved arm and $sysroot/usr/include/i386-linux-gnu tests

Author: Fangrui Song Date: 2021-03-22T12:08:46-07:00 New Revision: 3e32e8c588e911f1fdf2589b01855a1cce3bda92 URL: https://github.com/llvm/llvm-project/commit/3e32e8c588e911f1fdf2589b01855a1cce3bda92 DIFF: https://github.com/llvm/llvm-project/commit/3e32e8c588e911f1fdf2589b01855a1cce3bda92.diff

[PATCH] D98783: [CUDA][HIP] Remove unused addr space casts

tra added a subscriber: rsmith. tra added a comment. We may want to add someone with more expertise with the IR as a reviewer. I'd like an educated opinion on whether the invisible dangling IR is something that needs fixing in general or if it's OK to just clean it up in this particular case.

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; kadircet wrote: > this definitely makes

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added a subscriber: bruno. hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + dblaikie wrote: > hoy wrote: > > dblaikie wrote: > > > hoy wrote: > > > >

[clang] 21b211a - Revert "[Driver] Clean up Debian multiarch /usr/include/ madness"

Author: Petr Hosek Date: 2021-03-22T11:58:28-07:00 New Revision: 21b211a8f24f8ecfab8b380ff761a90d9cf73924 URL: https://github.com/llvm/llvm-project/commit/21b211a8f24f8ecfab8b380ff761a90d9cf73924 DIFF: https://github.com/llvm/llvm-project/commit/21b211a8f24f8ecfab8b380ff761a90d9cf73924.diff

[clang] 933d146 - Revert "[Driver] -m32: Add /usr/include/i386-linux-gnu for Debian"

Author: Petr Hosek Date: 2021-03-22T11:58:28-07:00 New Revision: 933d146f38c6d77a9b4fdde2b6b394f6ad9f8bf5 URL: https://github.com/llvm/llvm-project/commit/933d146f38c6d77a9b4fdde2b6b394f6ad9f8bf5 DIFF: https://github.com/llvm/llvm-project/commit/933d146f38c6d77a9b4fdde2b6b394f6ad9f8bf5.diff

[PATCH] D98867: [HIP] Fix ROCm detection

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:269 +if (Loc != StringRef::npos) + VerStr[Loc] = '.'; +V.tryParse(VerStr); yaxunl wrote: > tra

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen updated this revision to Diff 332384. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97831/new/ https://reviews.llvm.org/D97831 Files: clang/docs/DiagnosticsReference.rst

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332380. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/Basic/Targets/Sparc.cpp clang/test/Preprocessor/predefined-arch-macros.c Index:

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. > Hmm - is that type used in a way that invokes Undefined Behavior? Or is this > a gap/bug in the ctor homing? I thought there was already a special case for > constexpr ctors that opted them out of ctor homing. Right, I think the constexpr is only used in >c++17 for

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

arlosi added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/ https://reviews.llvm.org/D98438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added subscribers: aprantl, rsmith. dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > dblaikie wrote: > > hoy wrote: > > >

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; this definitely makes sense, but most of the

[PATCH] D98814: [CUDA][HIP] Mark device var used by host only

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:31-33 +// Check device-used static device var is not in llvm.compiler.used. +// CHECK-DAG: @_ZL2u4 +static

[PATCH] D99082: [RISCV][NFC] Fix RVV intrinsic tests.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99082/new/ https://reviews.llvm.org/D99082

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

tra added a comment. In D98902#2640477 , @tianshilei1992 wrote: > In D98902#2636308 , @jdoerfert wrote: > >> @tra, so you think we should not do this? The user will see a link error >> late I assume, might be

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies added a comment. Thank you very much! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

shafik added a comment. Thank you for adding the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98951/new/ https://reviews.llvm.org/D98951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99062/new/ https://reviews.llvm.org/D99062 ___ cfe-commits mailing list

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

StephenTozer added a comment. Apart from the one comment, LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1644-1650 + Opts.EnableDIPreservationVerify = Args.hasArg(OPT_fverify_debuginfo_preserve); + // Ignore the option if the -fverify-debuginfo-preserve wasn't

Re: [clang] c2f9086 - [Driver] Gnu.cpp: drop an unneeded special rule related to sysroot

I reverted this and the related change in 625fd7e54205077. The regression range did point to this and the related change. On Mon, Mar 22, 2021 at 9:42 AM Arthur Eubanks wrote: > Same error on the Android Chrome bots, although I didn't check if this > commit was the issue. >

[clang] 5184f69 - Revert "[Driver] Gnu.cpp: drop an unneeded special rule related to sysroot"

Author: Arthur Eubanks Date: 2021-03-22T10:16:19-07:00 New Revision: 5184f69041166257e4c6a15e572d12c676cd0c31 URL: https://github.com/llvm/llvm-project/commit/5184f69041166257e4c6a15e572d12c676cd0c31 DIFF:

[PATCH] D72235: [clang-tidy] new altera unroll loops check

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit on your behalf in 5a87f81fe9aee996dfe3a84dd833f0a48e093e7f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/

[clang-tools-extra] 5a87f81 - new altera unroll loops check

Author: Frank Derry Wanye Date: 2021-03-22T13:09:53-04:00 New Revision: 5a87f81fe9aee996dfe3a84dd833f0a48e093e7f URL: https://github.com/llvm/llvm-project/commit/5a87f81fe9aee996dfe3a84dd833f0a48e093e7f DIFF:

[PATCH] D99077: [ASTImporter] Fix import of ObjCPropertyDecl that share the same name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe421a74108ee: [ASTImporter] Fix import of ObjCPropertyDecl that share the same name (authored by teemperor). Herald added a subscriber: cfe-commits.

[clang] e421a74 - [ASTImporter] Fix import of ObjCPropertyDecl that share the same name

Author: Raphael Isemann Date: 2021-03-22T18:05:50+01:00 New Revision: e421a74108ee86afec133c77258470d3ed7dcc90 URL: https://github.com/llvm/llvm-project/commit/e421a74108ee86afec133c77258470d3ed7dcc90 DIFF:

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

aaron.ballman added a comment. In D97371#2641800 , @rjmccall wrote: > Windows exceptions code-generation is quite different; I don't know whether > Clang supports ObjC on Windows in general. It'd be fine if you add a > `-triple` argument to this test.

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

rjmccall added a comment. Windows exceptions code-generation is quite different; I don't know whether Clang supports ObjC on Windows in general. It'd be fine if you add a `-triple` argument to this test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen updated this revision to Diff 332341. khchen added a comment. update tests, remove target-feature zfh. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98848/new/ https://reviews.llvm.org/D98848 Files:

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius updated this revision to Diff 332340. curdeius added a comment. - Use a generic message. - Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98433/new/ https://reviews.llvm.org/D98433 Files:

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. I have updated the patch now with the result that clang should behave as GCC now on Linux, NetBSD and OpenBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332339. glaubitz edited the summary of this revision. Herald added a subscriber: krytarowski. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files:

Re: [clang] c2f9086 - [Driver] Gnu.cpp: drop an unneeded special rule related to sysroot

Same error on the Android Chrome bots, although I didn't check if this commit was the issue. https://ci.chromium.org/ui/p/chromium/builders/ci/ToTAndroid/16087/overview On Mon, Mar 22, 2021 at 9:11 AM Matt Morehouse via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Fangrui, > > This

[PATCH] D99008: [RISCV] [2/2] Add intrinsic for Zbr extension

craig.topper added a comment. Please note I asked that this patch be separate from D99009 because the rvintrin.h file name may not be the final filename we want to use. This https://github.com/riscv/riscv-c-api-doc/pull/14 suggests it should be

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

brad added a comment. In D98574#2641697 , @glaubitz wrote: > `-m32` is not supported on OpenBSD at all: > > openbsd# echo | gcc -E -dM -m32 - > :0: error: -m32 is not supported by this configuration > openbsd# Yes. OpenBSD has no 32-bit

[PATCH] D98959: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTH! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98959/new/ https://reviews.llvm.org/D98959

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv32-zbr.c:5 + +#include + I don't think this include is needed. You're calling the __builtin names directly. Comment at:

  1   2   >