[clang] 08c766a - Bump the trunk major version to 14

Author: Tom Stellard Date: 2021-07-27T21:58:25-07:00 New Revision: 08c766a7318ab37bf1d77e0c683cd3b00e700877 URL: https://github.com/llvm/llvm-project/commit/08c766a7318ab37bf1d77e0c683cd3b00e700877 DIFF: https://github.com/llvm/llvm-project/commit/08c766a7318ab37bf1d77e0c683cd3b00e700877.diff

[PATCH] D106674: Runtime for Interop directive

sriharikrishna updated this revision to Diff 362280. sriharikrishna added a comment. Runtime for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 Files:

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson updated this revision to Diff 362277. mhjacobson marked an inline comment as done. mhjacobson added a comment. Explicitly added `--start-group` and `--end-group` to the expectation in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson marked an inline comment as done. mhjacobson added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 +CmdArgs.push_back("--end-group"); + benshi001 wrote: > You are appreciated to use 'git show -U99' or 'git diff -U99'

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson updated this revision to Diff 362275. mhjacobson added a comment. Updated the diff to add more context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106854/new/ https://reviews.llvm.org/D106854 Files:

[PATCH] D106674: Runtime for Interop directive

sriharikrishna updated this revision to Diff 362269. sriharikrishna added a comment. Runtime for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 Files:

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 +CmdArgs.push_back("--end-group"); + You are appreciated to use 'git show -U99' or 'git diff -U99' for better context display. Comment at:

[PATCH] D106907: [clang] fix concepts crash on substitution failure during normalization

mizvekov updated this revision to Diff 362268. mizvekov added a comment. - Restore assert. - Fix incorrekt use of emplace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106907/new/ https://reviews.llvm.org/D106907 Files:

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 added inline comments. Comment at: llvm/lib/Support/ConvertUTFWrapper.cpp:176 + // enough that we can fit a null terminator without reallocating. + Out.resize(SrcBytes.size() * UNI_MAX_UTF8_BYTES_PER_CODE_POINT + 1); + UTF8 *Dst = reinterpret_cast([0]);

[PATCH] D106674: Runtime for Interop directive

sriharikrishna updated this revision to Diff 362266. sriharikrishna added a comment. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Runtime for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

steven.zhang added a comment. In D106431#2907688 , @whisperity wrote: > In D106431#2907002 , @Sockke wrote: > >> Any thoughts? : ) > > First, let's first fix that we should still warn for the uninitialised

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

airlied added a comment. In D106778#2904509 , @Anastasia wrote: > Generally LGTM, but I think we should guard the `else` blocks with > CL_VERSION_2_0 or higher to avoid exposing the functions in earlier standards > because the spec says: > > The C11

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

airlied added a comment. In D106778#2904509 , @Anastasia wrote: > Generally LGTM, but I think we should guard the `else` blocks with > CL_VERSION_2_0 or higher to avoid exposing the functions in earlier standards > because the spec says: > > The C11

[PATCH] D98709: [clang-tidy] New feature --skip-headers, part 1, LocFilter

chh updated this revision to Diff 362262. chh added a comment. apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98709/new/ https://reviews.llvm.org/D98709 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ab6aedda9d9: [OpenMP] Folding threadLimit and numThreads when single value in kernels (authored by Jose M Monsalve Diaz jmonsalved...@anl.gov,

[PATCH] D100713: [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr

mizvekov marked 2 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5845 + if (!To->isRValue()) { +QualType T = Self.Context.getDecltypeForParenthesizedExpr(To); InitializedEntity Entity =

[PATCH] D100713: [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr

mizvekov updated this revision to Diff 362257. mizvekov added a comment. - rename to getReferenceQualifiedType. - Move the null expression special case out of the function, back to the original user. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

This revision was automatically updated to reflect the committed changes. Closed by commit rG4819b751bd87: [clang] NFC: change uses of `Expr-getValueKind` into `is?Value` (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org/D100733?vs=351123=362254#toc Repository: rG

[clang] 4819b75 - [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

Author: Matheus Izvekov Date: 2021-07-28T03:09:31+02:00 New Revision: 4819b751bd875f458eb0060f7c586aa9ac41965c URL: https://github.com/llvm/llvm-project/commit/4819b751bd875f458eb0060f7c586aa9ac41965c DIFF:

[PATCH] D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels

josemonsalve2 updated this revision to Diff 362248. josemonsalve2 added a comment. Rebasing to main this time for real Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106033/new/ https://reviews.llvm.org/D106033 Files:

[PATCH] D106907: [clang] fix concepts crash on substitution failure during normalization

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:751 + return None; +Conjunction.emplace(S.Context, std::move(*Conjunction), std::move(*Next), +CCK_Conjunction); mizvekov wrote: > rsmith wrote: > >

[PATCH] D106907: [clang] fix concepts crash on substitution failure during normalization

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:744 ArrayRef E) { - assert(E.size() != 0); - auto First = fromConstraintExpr(S, D, E[0]); rsmith wrote: > Might be useful to keep this assert;

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, setTraversalScope

chh updated this revision to Diff 362239. chh edited the summary of this revision. chh added a comment. Add new test cases into misc-unused-using-decls.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files:

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. In D105527#2908944 , @Bigcheese wrote: > Also, this python script just doesn't work. It's missing a sys import, a "w" > flag, and a new line after each write. It also dumps the output into the > source directory. Was this

[PATCH] D60912: MS ABI: handle inline static data member and inline variable as template static data member

MaskRay added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:494 // too. AddGlobalCtor(Fn, 65535, COMDATKey); } else { Confirmed with `lld-link -subsystem:console -opt:ref -debug:symtab a.o b.o c.o -entry:main -out:win.exe` that

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Proposed fix here: D106924 The reproducer had another whitespace difference before and after D104601 : " typedef __builtin_va_list __gnuc_va_list;" instead of " typedef __builtin_va_list

[PATCH] D106925: COFF/ELF: Place llvm.global_ctors elements in llvm.used if comdat is used

MaskRay created this revision. MaskRay added reviewers: rnk, rsmith. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On ELF, an SHT_INIT_ARRAY outside a section group is a GC root. The current codegen abuses SHT_INIT_ARRAY in a

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur created this revision. Meinersbur added reviewers: aaron.ballman, mstorsjo, dblaikie. Meinersbur added a project: clang. Meinersbur requested review of this revision. The implementation of -fminimize-whitespace (D104601 ) revised the logic when to

[PATCH] D100713: [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5461 +QualType ASTContext::getDecltypeForParenthesizedExpr(const Expr *e) const { + if (!e) +return VoidTy; This check doesn't seem like it belongs here. Comment at:

[PATCH] D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels

josemonsalve2 updated this revision to Diff 362234. josemonsalve2 added a comment. Resync again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106033/new/ https://reviews.llvm.org/D106033 Files:

[PATCH] D106907: [clang] fix concepts crash on substitution failure during normalization

rsmith added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:744 ArrayRef E) { - assert(E.size() != 0); - auto First = fromConstraintExpr(S, D, E[0]); Might be useful to keep this assert; it will make it

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

Bigcheese added a comment. Here's a version that actually works (python 3, not sure if it's valid in 2), although I would much prefer we not write to the source directory during a build. import re import os import sys input_file = open(sys.argv[1]) with open(sys.argv[2], "w") as

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

Bigcheese added a comment. Also, this python script just doesn't work. It's missing a sys import, a "w" flag, and a new line after each write. It also dumps the output into the source directory. Was this actually tested? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels

josemonsalve2 updated this revision to Diff 362226. josemonsalve2 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sync to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106033/new/

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

lunasorcery updated this revision to Diff 362220. lunasorcery added a comment. Sorry it took me so long to get back to this - fell off my radar somewhat. I've updated the release notes, I think it's ready to commit now? I lack commit rights (first time contributor!) so for attribution it'd be

[PATCH] D98709: [clang-tidy] New feature --skip-headers, part 1, LocFilter

chh updated this revision to Diff 362216. chh edited the summary of this revision. chh added a comment. - Use clang-format layout in ClangTidy.cpp and ClangTidyModule.h. - Fix misc-unused-using-decls false-positive warning from --skip-headers. - UnusedUsingDeclsCheck is now registered as an

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

efriedma added inline comments. Comment at: llvm/lib/Support/ConvertUTFWrapper.cpp:176 + // enough that we can fit a null terminator without reallocating. + Out.resize(SrcBytes.size() * UNI_MAX_UTF8_BYTES_PER_CODE_POINT + 1); + UTF8 *Dst = reinterpret_cast([0]);

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

jrtc27 added a comment. In D105516#2892512 , @rjmccall wrote: > I agree with Eli: we should decide what the goals are here and then use those > goals to decide if we can identify a desirable permanent feature and, if so, > what the appropriate name for

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

arichardson added a comment. I like this since the flag significantly improves readability for `update_cc_test_checks.py`-generated Clang test without having to use the `-disable-O0-optnone | opt` trick. Not sure what the best flag name is, but as long as it's a CC1 flag it shouldn't really

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Seems fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105516/new/ https://reviews.llvm.org/D105516

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 362208. gandhi21299 added a comment. Instruction selector is unable to select unsafe hw atomic instruction for add. Adding relevant diagnostic in the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 362157. gandhi21299 added a comment. - corrected test by replacing the hardware instruction check by `v_add_f32_e64` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 created this revision. gandhi21299 added reviewers: arsenm, yaxunl, rampitec. Herald added subscribers: kerbowa, jfb, tpr, nhaehnle, jvesely. gandhi21299 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Implement target

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg to run mem2reg at -O0

jrtc27 updated this revision to Diff 362214. jrtc27 added a comment. Now only a CC1 option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105516/new/ https://reviews.llvm.org/D105516 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D106614: [Clang] add btf_tag attribute

yonghong-song added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2019 +targets. This attribute may be attached to a struct/union, struct/union field, +function or variables declaration. If -g is specified, the ARGUMENT info will +be preserved in IR and be

[PATCH] D106920: [AIX] Update fetch_and_add type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedbdf8e5b5aa: [AIX] Update fetch_and_add type (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] edbdf8e - [AIX] Update fetch_and_add type

Author: Jinsong Ji Date: 2021-07-27T22:13:29Z New Revision: edbdf8e5b5aad9f1d7f12dd4025d6811a6fff0b2 URL: https://github.com/llvm/llvm-project/commit/edbdf8e5b5aad9f1d7f12dd4025d6811a6fff0b2 DIFF: https://github.com/llvm/llvm-project/commit/edbdf8e5b5aad9f1d7f12dd4025d6811a6fff0b2.diff LOG:

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 updated this revision to Diff 362198. MarcusJohnson91 added a comment. Dropped the UTF32 BOM stuff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753 Files: llvm/include/llvm/Support/ConvertUTF.h

[PATCH] D106920: [AIX] Update fetch_and_add type

jsji updated this revision to Diff 362197. jsji edited the summary of this revision. jsji added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106920/new/ https://reviews.llvm.org/D106920 Files:

[PATCH] D106920: [AIX] Update fetch_and_add type

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. Thanks. LGTM with minor nits. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-fetch.c:19 // -void

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

MaskRay added a comment. In D106701#2908679 , @craig.topper wrote: > Does this work with LTO? `-falign-loops=` doesn't affect ld.lld code generation options. `-Wl,-mllvm,--align-loops=128` can be used for now. Repository: rG LLVM Github Monorepo

[PATCH] D106614: [Clang] add btf_tag attribute

anakryiko added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2019 +targets. This attribute may be attached to a struct/union, struct/union field, +function or variables declaration. If -g is specified, the ARGUMENT info will +be preserved in IR and be

[PATCH] D106920: [AIX] Update fetch_and_add type

jsji created this revision. Herald added subscribers: steven.zhang, kbarton, nemanjai. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out that AIX kernerl are definiing int instead of unsing int for fectch_and_add. Legacy

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

craig.topper added a comment. Does this work with LTO? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106701/new/ https://reviews.llvm.org/D106701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson updated this revision to Diff 362185. mhjacobson added a comment. Modified regression test `Driver/avr-ld.c` to account for the new arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106854/new/ https://reviews.llvm.org/D106854

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0276db14167b: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit`… (authored by Jose M Monsalve Diaz jmonsalved...@anl.gov,

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:262-269 + if (T.isOSAIX()) { +// Pass -b prefix for AIX linker. +A.claim(); +A.render(Args, CmdArgs); +continue; + } else { +

[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc49df15c2788: [dfsan][NFC] Describe how origin trace tracking works (authored by Jianzhou Zhao jianzho...@google.com). Repository: rG LLVM Github

[clang] c49df15 - [dfsan][NFC] Describe how origin trace tracking works

Author: Jianzhou Zhao Date: 2021-07-27T21:10:39Z New Revision: c49df15c278857adecd12db6bb1cdc96885f7079 URL: https://github.com/llvm/llvm-project/commit/c49df15c278857adecd12db6bb1cdc96885f7079 DIFF: https://github.com/llvm/llvm-project/commit/c49df15c278857adecd12db6bb1cdc96885f7079.diff

[PATCH] D106907: [clang] fix concepts crash on substitution failure during normalization

mizvekov created this revision. mizvekov edited the summary of this revision. mizvekov added a reviewer: rsmith. mizvekov added a subscriber: Quuxplusone. mizvekov published this revision for review. mizvekov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D105972: Fix __attribute__((annotate("")) with non-zero globals AS

arichardson added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105972/new/ https://reviews.llvm.org/D105972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Looking into it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

stephan.yichao.zhao updated this revision to Diff 362161. stephan.yichao.zhao added a comment. typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106903/new/ https://reviews.llvm.org/D106903 Files: clang/docs/DataFlowSanitizerDesign.rst

[PATCH] D106914: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT

tstellar added a comment. LGTM. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106914/new/ https://reviews.llvm.org/D106914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106914: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe07f9342be71: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

stephan.yichao.zhao updated this revision to Diff 362159. stephan.yichao.zhao added a comment. tweak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106903/new/ https://reviews.llvm.org/D106903 Files: clang/docs/DataFlowSanitizerDesign.rst

[clang] e07f934 - [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT

Author: Jinsong Ji Date: 2021-07-27T20:18:50Z New Revision: e07f9342be7132f433963880d95e471ae2246d64 URL: https://github.com/llvm/llvm-project/commit/e07f9342be7132f433963880d95e471ae2246d64 DIFF: https://github.com/llvm/llvm-project/commit/e07f9342be7132f433963880d95e471ae2246d64.diff LOG:

[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

stephan.yichao.zhao updated this revision to Diff 362158. stephan.yichao.zhao added a comment. explained what a trace and a chain are. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106903/new/ https://reviews.llvm.org/D106903 Files:

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

jsji added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:79 + set(LLVM_EXPORTED_SYMBOL_FILE) + set(USE_VERSION_SCRIPT TRUE) +endif() jsji wrote: > I think we should check LLVM_HAVE_LINK_VERSION_SCRIPT here, there are > platforms that does

[PATCH] D106914: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106914/new/ https://reviews.llvm.org/D106914

[PATCH] D106914: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT

jsji created this revision. jsji added reviewers: PowerPC, tstellar, MaskRay, hubert.reinterpretcast. Herald added a subscriber: mgorny. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are some platform that might not have

[PATCH] D106858: [hwasan] Fix stack safety test for old PM.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG835ef6f93d57: [hwasan] Fix stack safety test for old PM. (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 835ef6f - [hwasan] Fix stack safety test for old PM.

Author: Florian Mayer Date: 2021-07-27T20:50:46+01:00 New Revision: 835ef6f93d5789d3d7d905462e7574a38b30577d URL: https://github.com/llvm/llvm-project/commit/835ef6f93d5789d3d7d905462e7574a38b30577d DIFF: https://github.com/llvm/llvm-project/commit/835ef6f93d5789d3d7d905462e7574a38b30577d.diff

[PATCH] D106890: [z/OS] Make MinGlobalAlign consistent with SystemZ

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2d4b064644b: [z/OS] Make MinGlobalAlign consistent with SystemZ (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106890/new/

[clang] a2d4b06 - [z/OS] Make MinGlobalAlign consistent with SystemZ

Author: Fanbo Meng Date: 2021-07-27T15:39:14-04:00 New Revision: a2d4b064644bdf146d0649c6a70e595567f1213f URL: https://github.com/llvm/llvm-project/commit/a2d4b064644bdf146d0649c6a70e595567f1213f DIFF: https://github.com/llvm/llvm-project/commit/a2d4b064644bdf146d0649c6a70e595567f1213f.diff

[PATCH] D106790: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124)

rnk added a comment. In D106790#2906762 , @hans wrote: > In D106790#2905110 , @rnk wrote: > >> Does this match GCC? They also provide this Intel intrinsic. > > No, they define it without volatile (and also

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

jsji added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:79 + set(LLVM_EXPORTED_SYMBOL_FILE) + set(USE_VERSION_SCRIPT TRUE) +endif() I think we should check LLVM_HAVE_LINK_VERSION_SCRIPT here, there are platforms that does NOT support

[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

gbalats added inline comments. Comment at: clang/docs/DataFlowSanitizerDesign.rst:142 +Every four 4-bytes aligned application bytes share a 4-byte origin value. A +4-byte origin contains a 4-bit depth and a 28-bit hash ID of a chain. + What is a chain? It's not

[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

stephan.yichao.zhao created this revision. stephan.yichao.zhao added a reviewer: gbalats. stephan.yichao.zhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106903 Files:

[PATCH] D106895: [dfsan][NFC] Update API interfaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00411ebeeb71: [dfsan][NFC] Update API interfaces (authored by Jianzhou Zhao jianzho...@google.com). Repository: rG LLVM Github Monorepo CHANGES

[clang] 00411eb - [dfsan][NFC] Update API interfaces

Author: Jianzhou Zhao Date: 2021-07-27T18:53:36Z New Revision: 00411ebeeb718da63d1ec0e0ffc8e5012e474fe9 URL: https://github.com/llvm/llvm-project/commit/00411ebeeb718da63d1ec0e0ffc8e5012e474fe9 DIFF: https://github.com/llvm/llvm-project/commit/00411ebeeb718da63d1ec0e0ffc8e5012e474fe9.diff

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz updated this revision to Diff 362123. beanz added a comment. One last fix for a test failure my change caused. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/ https://reviews.llvm.org/D106732 Files:

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

cjdb updated this revision to Diff 362116. cjdb retitled this revision from "Revert "Revert "[clang][pp] adds '#pragma include_instead'"" Includes regression test for problem noted by @hans." to "Revert "Revert "[clang][pp] adds '#pragma include_instead'""". cjdb edited the summary of this

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'"" Includes regression test for problem noted by @hans.

hans added inline comments. Comment at: clang/test/PCH/ms-pch-macro-include_instead-regression.c:24 + +#include BAZ + This is really the interesting part. Maybe the other checks and macros could be removed, if that's enough to trigger the crash? Repository:

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

vitalybuka added a comment. @eugenis Why do we have them in here and in sanitizer/hwasan_interface.h ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 ___

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

sfertile created this revision. sfertile added reviewers: stevewan, Jake-Egan. Herald added subscribers: shchenz, nemanjai. sfertile requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Zero-width bitfields on AIX pad out to the natral

[libunwind] 21c24ae - [runtimes] Always build libc++, libc++abi and libunwind with -fPIC

Author: Louis Dionne Date: 2021-07-27T14:19:05-04:00 New Revision: 21c24ae9029a1fcd1c76b61b1c48b81b5c66c606 URL: https://github.com/llvm/llvm-project/commit/21c24ae9029a1fcd1c76b61b1c48b81b5c66c606 DIFF: https://github.com/llvm/llvm-project/commit/21c24ae9029a1fcd1c76b61b1c48b81b5c66c606.diff

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

sidneym added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:604 + const bool HasSysRoot = !D.SysRoot.empty(); + if (HasSysRoot) { SmallString<128> P(D.SysRoot); bcain wrote: > MaskRay wrote: > > To match Linux.cpp, this code block

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'"" Includes regression test for problem noted by @hans.

cjdb created this revision. cjdb added reviewers: aaron.ballman, rsmith, dblaikie. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 973de7185606a21fd5e9d5e8c014fbf898c0e72f

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1601 + CGM.getModule(), OMPRTL___kmpc_free_shared), + V); +} This needs to include the size of the accompanying push

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 362093. gandhi21299 added a comment. - replaced `check-prefixes` to `check-prefix` in the test - Function ffp1 emits a `flat_atomic_cmpswap` instead of `global_atomic_add`, I am not sure if that is considered an unsafe hardware instruction. @arsenm ?

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

leonardchan added a comment. In D99381#2858599 , @mcgrathr wrote: > Frankly I don't think it makes sense to have __sanitizer_mallinfo and those > other allocator functions declared in hwasan_interface_internal.h at all. > Those are neither APIs that the

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

leonardchan updated this revision to Diff 362103. leonardchan retitled this revision from "[compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits" to "[compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface". leonardchan edited the summary of this

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. Closed by commit rG48ad446a0fb2: [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 48ad446 - [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp-contract=on

Author: Melanie Blower Date: 2021-07-27T13:55:31-04:00 New Revision: 48ad446a0fb2c9b98cb7047e4daf8a84c29cef8f URL: https://github.com/llvm/llvm-project/commit/48ad446a0fb2c9b98cb7047e4daf8a84c29cef8f DIFF:

[PATCH] D106895: [dfsan][NFC] Update API interfaces

stephan.yichao.zhao created this revision. stephan.yichao.zhao added a reviewer: gbalats. stephan.yichao.zhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106895 Files:

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 created this revision. gandhi21299 added reviewers: arsenm, yaxunl, rampitec. gandhi21299 created this object with edit policy "Members of Project: AMDGPU". Herald added subscribers: foad, kerbowa, jfb, hiraditya, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. gandhi21299

[PATCH] D106890: [z/OS] Make MinGlobalAlign consistent with SystemZ

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106890/new/ https://reviews.llvm.org/D106890

[PATCH] D106890: [z/OS] Make MinGlobalAlign consistent with SystemZ

fanbo-meng created this revision. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove overriding MinGlobalAlign to 0 for z/OS target to be consistent with SystemZ. Repository: rG LLVM Github Monorepo

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 362074. josemonsalve2 added a comment. Fixing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org/D106298 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

  1   2   3   >