llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sameer Sahasrabuddhe (ssahasra)
Changes
In the builtins declaration, "ULi" is a 32-bit integer on Windows. Use "WUi"
instead to ensure a 64-bit integer on all platforms.
---
Full diff:
Author: Jie Fu
Date: 2023-11-30T15:53:36+08:00
New Revision: 5891a8f7ce0a7b866a5bc06c34092fbdb28dda1c
URL:
https://github.com/llvm/llvm-project/commit/5891a8f7ce0a7b866a5bc06c34092fbdb28dda1c
DIFF:
https://github.com/llvm/llvm-project/commit/5891a8f7ce0a7b866a5bc06c34092fbdb28dda1c.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/73463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cor3ntin
Date: 2023-11-30T08:45:05+01:00
New Revision: 030047c432cac133738be68fa0974f70e69dd58d
URL:
https://github.com/llvm/llvm-project/commit/030047c432cac133738be68fa0974f70e69dd58d
DIFF:
https://github.com/llvm/llvm-project/commit/030047c432cac133738be68fa0974f70e69dd58d.diff
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/73099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S,
SourceLocation IdentLoc,
: IdentLoc);
}
+static ImplicitConversionKind getConversionKind(QualType FromType,
+
cor3ntin wrote:
@usx95 stupid question, how does that affects llvm when built with GCC/MSVC?
If we do require a too recent version of compiler to build in C++20 mode it
will make it harder to move llvm to C++20.
https://github.com/llvm/llvm-project/pull/72348
https://github.com/rapidsna ready_for_review
https://github.com/llvm/llvm-project/pull/70749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -485,20 +499,83 @@ Pointer types in a ``typedef`` can still have explicit
annotations, e.g.,
``typedef int *__single``, in which case the bounds annotation ``__single``
will
apply to every use of the ``typedef``.
-Array to pointer promotion
---
-
cor3ntin wrote:
> Thanks! I assume you'll also be looking at the variable case (perhaps as a
> separate commit)?
I'll try to get to it, yes!
Thanks for the review
https://github.com/llvm/llvm-project/pull/73463
___
cfe-commits mailing list
@@ -0,0 +1,362 @@
+==
+``-fbounds-safety``: Enforcing bounds safety for C
+==
+
+.. contents::
+ :local:
+
+Overview
+
+
+``-fbounds-safety`` is a C extension to enforce
@@ -0,0 +1,362 @@
+==
+``-fbounds-safety``: Enforcing bounds safety for C
+==
+
+.. contents::
+ :local:
+
+Overview
+
+
+``-fbounds-safety`` is a C extension to enforce
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/73463
>From af4176fba7e7b6e45ddd5b7730c7b1c2cbd69537 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Sun, 26 Nov 2023 22:47:51 +0100
Subject: [PATCH 1/4] [Clang] Eagerly instantiate used constexpr function upon
@@ -0,0 +1,362 @@
+==
+``-fbounds-safety``: Enforcing bounds safety for C
+==
+
+.. contents::
+ :local:
+
+Overview
+
+
+``-fbounds-safety`` is a C extension to enforce
@@ -0,0 +1,362 @@
+==
+``-fbounds-safety``: Enforcing bounds safety for C
+==
+
+.. contents::
+ :local:
+
+Overview
+
+
+``-fbounds-safety`` is a C extension to enforce
@@ -0,0 +1,362 @@
+==
+``-fbounds-safety``: Enforcing bounds safety for C
+==
+
+.. contents::
+ :local:
+
+Overview
+
+
+``-fbounds-safety`` is a C extension to enforce
@@ -0,0 +1,362 @@
+==
+``-fbounds-safety``: Enforcing bounds safety for C
+==
+
+.. contents::
+ :local:
+
+Overview
+
+
+``-fbounds-safety`` is a C extension to enforce
@@ -0,0 +1,362 @@
+==
+``-fbounds-safety``: Enforcing bounds safety for C
+==
+
+.. contents::
+ :local:
+
+Overview
+
+
+``-fbounds-safety`` is a C extension to enforce
@@ -0,0 +1,362 @@
+==
+``-fbounds-safety``: Enforcing bounds safety for C
+==
+
+.. contents::
+ :local:
+
+Overview
+
+
+``-fbounds-safety`` is a C extension to enforce
@@ -0,0 +1,362 @@
+==
+``-fbounds-safety``: Enforcing bounds safety for C
+==
+
+.. contents::
+ :local:
+
+Overview
+
+
+``-fbounds-safety`` is a C extension to enforce
bogner wrote:
> I agree that "is declared here" is useless when "here" is... nowhere. But the
> point to the note is to help the user to see what the actual declaration is
> to help them repair the issue. Losing the note entirely isn't the worst
> thing, but I wonder if it would be better for
https://github.com/W-50243 updated
https://github.com/llvm/llvm-project/pull/73200
>From ebc84bed665494dde9dbef956a0383ff79cb3d0c Mon Sep 17 00:00:00 2001
From: W-50243
Date: Thu, 23 Nov 2023 11:02:24 +0800
Subject: [PATCH] [FIX] Fix the function isctype failed in arm64-big-endian
---
bogner wrote:
> That's a lot of repeated code. Should we have a "NoteTemplateLocation"
> function(s) of some sort that would do the check and the diag as appropriate?
Makes sense to me, and also makes @AaronBallman's idea of emitting notes
referring to the external source a little easier.
Author: Phoebe Wang
Date: 2023-11-19T10:14:34+08:00
New Revision: 5237193b87721134541f228e28edfd544a9c8ac8
URL:
https://github.com/llvm/llvm-project/commit/5237193b87721134541f228e28edfd544a9c8ac8
DIFF:
https://github.com/llvm/llvm-project/commit/5237193b87721134541f228e28edfd544a9c8ac8.diff
https://github.com/bogner updated
https://github.com/llvm/llvm-project/pull/71264
>From cab6bcd73081fcbe9807adbf60b345f8d9e654e4 Mon Sep 17 00:00:00 2001
From: Justin Bogner
Date: Fri, 3 Nov 2023 18:59:49 -0700
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/73376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
@shafik See
https://discourse.llvm.org/t/rfc-allow-c-11-lambdas-in-c-03-as-an-extension/75262
https://github.com/llvm/llvm-project/pull/73376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/73376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik wrote:
> Was there an RFC asking the community about exposing lambdas in pre C++11
> modes? This is a sufficiently large language extension that we probably
> should verify if we haven't already. I believe this is a conforming extension
> (I can't think of a circumstance under which
https://github.com/SixWeining closed
https://github.com/llvm/llvm-project/pull/72514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Lu Weining
Date: 2023-11-30T14:08:45+08:00
New Revision: 1296d20adfb0978afe38d67efab9818079d870ca
URL:
https://github.com/llvm/llvm-project/commit/1296d20adfb0978afe38d67efab9818079d870ca
DIFF:
https://github.com/llvm/llvm-project/commit/1296d20adfb0978afe38d67efab9818079d870ca.diff
https://github.com/wangleiat approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/72514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
Thank you, LGTM
https://github.com/llvm/llvm-project/pull/73463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/73691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Shafik Yaghmour
Date: 2023-11-29T21:03:32-08:00
New Revision: 0233a1306b240850cbf9f4783a20c36f967d9697
URL:
https://github.com/llvm/llvm-project/commit/0233a1306b240850cbf9f4783a20c36f967d9697
DIFF:
zjiaz wrote:
FWIW, `mcmodel=medium` option is used in [chromium's build config
file](https://source.chromium.org/chromium/chromium/src/+/main:build/config/compiler/BUILD.gn;l=1451?q=mcmodel=chromium%2Fchromium%2Fsrc:build%2F),
and now chromium's llvm toolchain has been affected by this issue:
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/73886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rymiel updated
https://github.com/llvm/llvm-project/pull/73886
>From 95e2a2ee5d901d79430cb9b9468e1af8215b334f Mon Sep 17 00:00:00 2001
From: Emilia Kond
Date: Thu, 30 Nov 2023 03:30:48 +0200
Subject: [PATCH 1/2] [clang-format] Don't skip stringizing when determining
brace
@@ -1851,6 +1851,22 @@ TEST_F(TokenAnnotatorTest,
UnderstandsTrailingReturnArrow) {
EXPECT_TOKEN(Tokens[13], tok::arrow, TT_Unknown);
}
+TEST_F(TokenAnnotatorTest, UnderstandHashInMacro) {
+ auto Tokens = annotate("#define Foo(Bar) \\\n"
+ " {
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/73709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jacob Lambert
Date: 2023-11-29T18:39:17-08:00
New Revision: 3cf190974a37d18c7bd6f52b9588f4104e8e96f0
URL:
https://github.com/llvm/llvm-project/commit/3cf190974a37d18c7bd6f52b9588f4104e8e96f0
DIFF:
https://github.com/llvm/llvm-project/commit/3cf190974a37d18c7bd6f52b9588f4104e8e96f0.diff
ronlieb wrote:
> performance degradation observed for this patch on trunk build : hpc2021 8
> mpi210's reference run 518.tealeaf 10.8% 534.hpgmg 7.3%
both of these benchmarks which exhibited performance regressions, contain
reductions.
https://github.com/llvm/llvm-project/pull/70401
jansvoboda11 wrote:
I'm not thrilled by the chosen implementation strategy. Disabling tracking
during parts of header search does not sound obviously correct to me. Module
map search can have subtle side-effects, and I wouldn't be suprised if this
feature was affected by one. That said, I
jansvoboda11 wrote:
We set `RedirectingFileSystem::HasBeenUsed` to `true` while implicitly
compiling one module, but then hand off the same VFS object to implicit compile
of another module. This will cause all modules discovered later to incorrectly
inherit that bit from previous modules.
https://github.com/ecnelises updated
https://github.com/llvm/llvm-project/pull/66978
>From 2a7b9be6cd0705590c85c51b35ea99fe053aaf47 Mon Sep 17 00:00:00 2001
From: Qiu Chaofan
Date: Wed, 6 Sep 2023 16:16:34 +0800
Subject: [PATCH 1/4] [PowerPC] Combine sub within setcc back to sext
---
glandium wrote:
Weirdly, this leads to `warning: argument unused during compilation: '-nopie'`
rather than `error: unknown argument: '-nopie'`
https://github.com/llvm/llvm-project/pull/72578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/aheejin closed
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Heejin Ahn
Date: 2023-11-29T18:03:58-08:00
New Revision: e88a2f123fa4843ae3782377668cf5741acc9121
URL:
https://github.com/llvm/llvm-project/commit/e88a2f123fa4843ae3782377668cf5741acc9121
DIFF:
https://github.com/llvm/llvm-project/commit/e88a2f123fa4843ae3782377668cf5741acc9121.diff
aheejin wrote:
I think the CI failures are unrelated. Merging.
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/73886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1851,6 +1851,22 @@ TEST_F(TokenAnnotatorTest,
UnderstandsTrailingReturnArrow) {
EXPECT_TOKEN(Tokens[13], tok::arrow, TT_Unknown);
}
+TEST_F(TokenAnnotatorTest, UnderstandHashInMacro) {
+ auto Tokens = annotate("#define Foo(Bar) \\\n"
+ " {
@@ -1851,6 +1851,22 @@ TEST_F(TokenAnnotatorTest,
UnderstandsTrailingReturnArrow) {
EXPECT_TOKEN(Tokens[13], tok::arrow, TT_Unknown);
}
+TEST_F(TokenAnnotatorTest, UnderstandHashInMacro) {
+ auto Tokens = annotate("#define Foo(Bar) \\\n"
+ " {
@@ -496,7 +496,7 @@ void UnwrappedLineParser::calculateBraceTypes(bool
ExpectClassBody) {
do {
NextTok = Tokens->getNextToken();
} while (NextTok->is(tok::comment));
-while (NextTok->is(tok::hash)) {
+while (NextTok->is(tok::hash) &&
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Emilia Kond (rymiel)
Changes
PR #69473 introduced skipping PP directives when determining the brace
kind of an lbrace. However, it did so by skipping to the end of the line when
encountering a hash character. This means it also
https://github.com/rymiel created
https://github.com/llvm/llvm-project/pull/73886
PR #69473 introduced skipping PP directives when determining the brace kind of
an lbrace. However, it did so by skipping to the end of the line when
encountering a hash character. This means it also skipped to
@@ -80,14 +86,21 @@ namespace dr5 { // dr5: 3.1
namespace dr7 { // dr7: 3.4
class A { public: ~A(); };
- class B : virtual private A {}; // expected-note 2 {{declared private here}}
- class C : public B {} c; // expected-error 2 {{inherited virtual base class
'A' has
@@ -80,14 +86,21 @@ namespace dr5 { // dr5: 3.1
namespace dr7 { // dr7: 3.4
class A { public: ~A(); };
- class B : virtual private A {}; // expected-note 2 {{declared private here}}
- class C : public B {} c; // expected-error 2 {{inherited virtual base class
'A' has
https://github.com/shafik commented:
I think I mostly like this direction.
https://github.com/llvm/llvm-project/pull/73879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/73879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik updated
https://github.com/llvm/llvm-project/pull/73691
>From 21d6bbdd1f8676e51b053ec3dd9020270e6b929e Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour
Date: Tue, 28 Nov 2023 11:20:12 -0800
Subject: [PATCH] [Clang][Lex] Fix parsing of nested requirement to prevent
Endilll wrote:
I'm putting this NFC for a review, because that's the direction I'd like our DR
test suite to take. If it goes well, I'll go on and refactor the rest of the
test suite in this manner.
https://github.com/llvm/llvm-project/pull/73879
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/71771
>From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 9 Nov 2023 02:21:46 +
Subject: [PATCH 1/3] Fix clang to recognize new C23 modifiers %w and %wf when
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch converts (almost) every expected directive in
`test/CXX/drs/dr0xx.cpp` into either `@-1` form (when directive immediately
follow the line diagnostic is pointing out to), or `@#marker` form
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/73879
This patch converts (almost) every expected directive in
`test/CXX/drs/dr0xx.cpp` into either `@-1` form (when directive immediately
follow the line diagnostic is pointing out to), or `@#` form (when
directive
@@ -286,7 +286,33 @@
clang::analyze_format_string::ParseLengthModifier(FormatSpecifier ,
lmKind = LengthModifier::AsInt3264;
break;
case 'w':
- lmKind = LengthModifier::AsWide; ++I; break;
+ ++I;
+ if (I == E) return false;
+ if (*I == 'f')
@@ -1157,7 +1157,15 @@ void UnwrappedLineParser::parsePPDefine() {
// guard processing above, and changes preprocessing nesting.
FormatTok->Tok.setKind(tok::identifier);
FormatTok->Tok.setIdentifierInfo(Keywords.kw_internal_ident_after_define);
- nextToken();
+
+ if
@@ -956,42 +958,112 @@ static llvm::Value
*getArrayIndexingBound(CodeGenFunction ,
return nullptr;
}
-const Expr *
-CodeGenFunction::BuildCountedByFieldExpr(const Expr *Base,
- const ValueDecl *CountedByVD) {
+namespace {
+
+/// \p
@@ -956,42 +958,112 @@ static llvm::Value
*getArrayIndexingBound(CodeGenFunction ,
return nullptr;
}
-const Expr *
-CodeGenFunction::BuildCountedByFieldExpr(const Expr *Base,
- const ValueDecl *CountedByVD) {
+namespace {
+
+/// \p
@@ -956,42 +958,112 @@ static llvm::Value
*getArrayIndexingBound(CodeGenFunction ,
return nullptr;
}
-const Expr *
-CodeGenFunction::BuildCountedByFieldExpr(const Expr *Base,
- const ValueDecl *CountedByVD) {
+namespace {
+
+/// \p
@@ -956,42 +958,112 @@ static llvm::Value
*getArrayIndexingBound(CodeGenFunction ,
return nullptr;
}
-const Expr *
-CodeGenFunction::BuildCountedByFieldExpr(const Expr *Base,
- const ValueDecl *CountedByVD) {
+namespace {
+
+/// \p
Author: Vlad Serebrennikov
Date: 2023-11-30T02:25:15+03:00
New Revision: bf2e05c7fbc739cd9b9086163303f846ee2806d2
URL:
https://github.com/llvm/llvm-project/commit/bf2e05c7fbc739cd9b9086163303f846ee2806d2
DIFF:
https://github.com/ributzka approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/73719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bwendling wrote:
Okay. With the latest commit, I handle some of the weird accesses. As it turns
out, looking at `isArrow()` for a `MemberExpr` isn't going to work, because
it'll happen with ordinary accesses:
```
ImplicitCastExpr 0x564fa8c3fd48 'int *'
`-MemberExpr 0x564fa8c3fcf8 'int[]'
Author: Brendan Dahl
Date: 2023-11-29T15:13:30-08:00
New Revision: c6d70722b49db01914d5f64cc86ea5ed609ad9fd
URL:
https://github.com/llvm/llvm-project/commit/c6d70722b49db01914d5f64cc86ea5ed609ad9fd
DIFF:
https://github.com/llvm/llvm-project/commit/c6d70722b49db01914d5f64cc86ea5ed609ad9fd.diff
https://github.com/efriedma-quic closed
https://github.com/llvm/llvm-project/pull/66716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
Actually that is more like a quick fix, we can live with it. More proper way
would be simply to split those tests into pre-c++20 and universal.
https://github.com/llvm/llvm-project/pull/73105
___
cfe-commits mailing list
cor3ntin wrote:
@PiotrZSL You beat me to it, thanks a lot!
https://github.com/llvm/llvm-project/pull/73105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/73719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/73709
>From 995706601f9f4aed021a9003ad79ca3e7e1d18af Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 28 Nov 2023 14:42:11 -0800
Subject: [PATCH 1/7] [clang-offload-bundler] Add support for
-check-input-archive
brendandahl wrote:
@efriedma-quic missed your comment. I don't have commit access. Can you merge
for me?
Thanks!
https://github.com/llvm/llvm-project/pull/66716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Piotr Zegar
Date: 2023-11-29T22:53:59Z
New Revision: fc19424d1d6d0df20e1734610a8e80a8e5158009
URL:
https://github.com/llvm/llvm-project/commit/fc19424d1d6d0df20e1734610a8e80a8e5158009
DIFF:
https://github.com/llvm/llvm-project/commit/fc19424d1d6d0df20e1734610a8e80a8e5158009.diff
LOG:
bwendling wrote:
> I agree users probably shouldn't be doing that... but given it compiles your
> code should handle it gracefully. (It should just be a matter of making sure
> you don't recurse too deeply through the "base".)
*nods* However, the code it generates might not be what they
https://github.com/Benjins updated
https://github.com/llvm/llvm-project/pull/71291
>From 12e5ec3c0727d58bf8d91f673c3facd974f98c54 Mon Sep 17 00:00:00 2001
From: Benji Smith <6193112+benj...@users.noreply.github.com>
Date: Sat, 4 Nov 2023 11:57:20 -0400
Subject: [PATCH 1/4] [C API] Add getters
https://github.com/jdoerfert closed
https://github.com/llvm/llvm-project/pull/73864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Johannes Doerfert
Date: 2023-11-29T14:49:13-08:00
New Revision: fae233c63f93b4b6f9693685abe6c7d24393682f
URL:
https://github.com/llvm/llvm-project/commit/fae233c63f93b4b6f9693685abe6c7d24393682f
DIFF:
efriedma-quic wrote:
I agree users probably shouldn't be doing that... but given it compiles your
code should handle it gracefully. (It should just be a matter of making sure
you don't recurse too deeply through the "base".)
https://github.com/llvm/llvm-project/pull/73730
https://github.com/jhuber6 approved this pull request.
AFAIK this is the correct way to set debug information for something that
doesn't have a valid source location like a lot of generated OpenMP calls.
https://github.com/llvm/llvm-project/pull/73856
dyung wrote:
@cor3ntin Your commit seems to be causing 2 test failures in the
clang-tools-extra tests, can you try to fix them or revert if you need time to
investigate?
https://lab.llvm.org/buildbot/#/builders/139/builds/54467
https://github.com/llvm/llvm-project/pull/73105
Author: Michael Platings
Date: 2023-11-29T17:21:08-05:00
New Revision: be811d1617654e46f4f4daa82259ae4fad4c8e6a
URL:
https://github.com/llvm/llvm-project/commit/be811d1617654e46f4f4daa82259ae4fad4c8e6a
DIFF:
@@ -418,14 +418,20 @@ llvm::MDNode *CodeGenTBAA::getBaseTypeInfo(QualType QTy) {
return nullptr;
const Type *Ty = Context.getCanonicalType(QTy).getTypePtr();
- if (llvm::MDNode *N = BaseTypeMetadataCache[Ty])
-return N;
- // Note that the following helper call
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/73264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic approved this pull request.
LGTM with one minor comment
https://github.com/llvm/llvm-project/pull/73264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/73103
>From 074d18d3805b067a5442bea94816d01319a29083 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Wed, 22 Nov 2023 11:43:07 +0100
Subject: [PATCH 1/5] [Clang] Implement P2308R1 - Template Parameter
https://github.com/efriedma-quic approved this pull request.
LGTM
See
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
for the rules on use/don't use braces. A single multi-line statement is sort
of on the edge; I tend
efriedma-quic wrote:
As a historical note, when I first wrote the support for atomics, it was under
a model where LLVM IR only modeled legal atomics, and clang lowered illegal
atomics to libcalls. This was changed a few years later to generalize atomics
in LLVM IR to support arbitrary atomic
efriedma-quic wrote:
The concept makes sense, but I think the code should be inside
CodeGenModule::GetAddrOfTemplateParamObject? I think all users of the function
want a value in the correct address-space.
https://github.com/llvm/llvm-project/pull/69266
https://github.com/lwshanbd created
https://github.com/llvm/llvm-project/pull/73861
Fix #69214.
In `emitOMPSimdRegion`, the `EmitOMPPrivateLoopCounters` should be after
`EmitOMPPrivateClause`.
>From 9eb00076c22197f223649b420994176a170a2671 Mon Sep 17 00:00:00 2001
From: Baodi Shan
Date: Wed,
Author: Jon Roelofs
Date: 2023-11-29T13:57:10-08:00
New Revision: 97e7926f25d81fb6c6d87202f721c2e2cf6198f5
URL:
https://github.com/llvm/llvm-project/commit/97e7926f25d81fb6c6d87202f721c2e2cf6198f5
DIFF:
https://github.com/llvm/llvm-project/commit/97e7926f25d81fb6c6d87202f721c2e2cf6198f5.diff
Author: Jon Roelofs
Date: 2023-11-29T13:57:04-08:00
New Revision: ecbfa0495147d255964d8beeb89c8d8d80ec74a1
URL:
https://github.com/llvm/llvm-project/commit/ecbfa0495147d255964d8beeb89c8d8d80ec74a1
DIFF:
https://github.com/llvm/llvm-project/commit/ecbfa0495147d255964d8beeb89c8d8d80ec74a1.diff
@@ -63,6 +63,12 @@ class CGCUDARuntime {
OffloadGlobalSurfaceEntry = 0x2,
/// Mark the entry as a texture variable.
OffloadGlobalTextureEntry = 0x3,
+ /// Mark the entry as being extern.
+ OffloadGlobalExtern = 0x4,
yxsamliu wrote:
1 - 100 of 404 matches
Mail list logo
