[clang] c25572b - [clang] NFC: rename SK_CastDerivedToBaseRValue to SK_CastDerivedToBasePRValue

Author: Matheus Izvekov Date: 2021-06-09T12:38:59+02:00 New Revision: c25572bf2993438f24b57d859d072e8b2aa975d2 URL: https://github.com/llvm/llvm-project/commit/c25572bf2993438f24b57d859d072e8b2aa975d2 DIFF:

[clang] 1e50c3d - [clang] NRVO: Improvements and handling of more cases.

Author: Matheus Izvekov Date: 2021-06-12T16:43:32+02:00 New Revision: 1e50c3d785f4563873ab1ce86559f2a1285b5678 URL: https://github.com/llvm/llvm-project/commit/1e50c3d785f4563873ab1ce86559f2a1285b5678 DIFF:

[clang] 667fbcd - [clang] NRVO: Improvements and handling of more cases.

Author: Matheus Izvekov Date: 2021-06-10T23:02:51+02:00 New Revision: 667fbcdd0b2ee5e78f5ce9789b862e3bbca94644 URL: https://github.com/llvm/llvm-project/commit/667fbcdd0b2ee5e78f5ce9789b862e3bbca94644 DIFF:

[clang] cbd0054 - [clang] Implement P2266 Simpler implicit move

Author: Matheus Izvekov Date: 2021-06-11T00:56:06+02:00 New Revision: cbd0054b9eb17ec48f0702e3828209646c8f5ebd URL: https://github.com/llvm/llvm-project/commit/cbd0054b9eb17ec48f0702e3828209646c8f5ebd DIFF:

[clang] bf20631 - [clang] Implement P2266 Simpler implicit move

Author: Matheus Izvekov Date: 2021-06-13T12:10:56+02:00 New Revision: bf20631782183cd19e0bb7219e908c2bbb01a75f URL: https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f DIFF:

[clang] 7ddd15c - [clang] Exclude function pointers on DefaultedComparisonAnalyzer

Author: Matheus Izvekov Date: 2021-06-18T13:07:47+02:00 New Revision: 7ddd15cd5dea76a19a9c5315e2a9903d74a49be8 URL: https://github.com/llvm/llvm-project/commit/7ddd15cd5dea76a19a9c5315e2a9903d74a49be8 DIFF:

[clang] 12c90e2 - [clang] NRVO: Improvements and handling of more cases.

Author: Matheus Izvekov Date: 2021-06-17T01:56:38+02:00 New Revision: 12c90e2e25dfd1d38250055efc21acb42d158912 URL: https://github.com/llvm/llvm-project/commit/12c90e2e25dfd1d38250055efc21acb42d158912 DIFF:

[clang] b88eb85 - [clang] use correct builtin type for defaulted comparison analyzer

Author: Matheus Izvekov Date: 2021-06-17T02:08:31+02:00 New Revision: b88eb855b53184161ad1ea0eea1962100941cf0b URL: https://github.com/llvm/llvm-project/commit/b88eb855b53184161ad1ea0eea1962100941cf0b DIFF:

[clang] ced6b20 - [clang] Implement P2266 Simpler implicit move

Author: Matheus Izvekov Date: 2021-06-18T17:08:59+02:00 New Revision: ced6b204d18e6eed611f8ebf27122ec19147ea7a URL: https://github.com/llvm/llvm-project/commit/ced6b204d18e6eed611f8ebf27122ec19147ea7a DIFF:

[clang] 2c60d22 - [clang] disable P2266 simpler implicit moves under -fms-compatibility

Author: Matheus Izvekov Date: 2021-07-08T00:13:11+02:00 New Revision: 2c60d22610325bcd6fb4c4bcc8b522b9fdfb46ee URL: https://github.com/llvm/llvm-project/commit/2c60d22610325bcd6fb4c4bcc8b522b9fdfb46ee DIFF:

[clang] 5a1c504 - [clang] fix constexpr code generation for user conversions.

Author: Matheus Izvekov Date: 2021-07-08T20:23:19+02:00 New Revision: 5a1c50410ccc1973a1a0a4acca0c01677c28e9b6 URL: https://github.com/llvm/llvm-project/commit/5a1c50410ccc1973a1a0a4acca0c01677c28e9b6 DIFF:

[clang] ad14b5b - [clang] Stop providing builtin overload candidate for relational function pointer comparisons

Author: Matheus Izvekov Date: 2021-06-26T00:08:02+02:00 New Revision: ad14b5b008e2f643cb989ec645f12bf26a8659bb URL: https://github.com/llvm/llvm-project/commit/ad14b5b008e2f643cb989ec645f12bf26a8659bb DIFF:

[clang] 7d2d5a3 - [clang] Apply P1825 as Defect Report from C++11 up to C++20.

Author: Matheus Izvekov Date: 2021-07-01T12:10:06+02:00 New Revision: 7d2d5a3a6d7aaa40468c30250bf6b0938ef02c08 URL: https://github.com/llvm/llvm-project/commit/7d2d5a3a6d7aaa40468c30250bf6b0938ef02c08 DIFF:

[clang] d6144c3 - [clang] add C++ feature test macro for P2266 simpler implicit move

Author: Matheus Izvekov Date: 2021-06-26T23:05:23+02:00 New Revision: d6144c30fb6ae7ac15c82d512f8da7572577c2d2 URL: https://github.com/llvm/llvm-project/commit/d6144c30fb6ae7ac15c82d512f8da7572577c2d2 DIFF:

[clang] 2110638 - [clang] fixes named return of variables with dependent alignment

Author: Matheus Izvekov Date: 2021-07-06T02:30:44+02:00 New Revision: 21106388eb96c87b3f580c42a322c76a61605261 URL: https://github.com/llvm/llvm-project/commit/21106388eb96c87b3f580c42a322c76a61605261 DIFF:

[clang] f2d5fce - [clang] fixes named return of variables with dependent alignment

Author: Matheus Izvekov Date: 2021-07-07T02:54:55+02:00 New Revision: f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365 URL: https://github.com/llvm/llvm-project/commit/f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365 DIFF:

[clang] bac74a5 - [clang] NFC: remove trailing white spaces from some tests

Author: Matheus Izvekov Date: 2021-04-03T03:18:22+02:00 New Revision: bac74a50e99f3d014d6e5a67272fd3b20eeb7fed URL: https://github.com/llvm/llvm-project/commit/bac74a50e99f3d014d6e5a67272fd3b20eeb7fed DIFF:

[clang] 3ad6dd5 - [clang] Use decltype((E)) for compound requirement type constraint

Author: Matheus Izvekov Date: 2021-03-30T22:00:33+02:00 New Revision: 3ad6dd5d8f0a70756f665e8179ad7c5210022c11 URL: https://github.com/llvm/llvm-project/commit/3ad6dd5d8f0a70756f665e8179ad7c5210022c11 DIFF:

[clang] d4a8c73 - [clang] Fix ICE on invalid type parameters for concepts

Author: Matheus Izvekov Date: 2021-03-13T01:23:02+01:00 New Revision: d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a URL: https://github.com/llvm/llvm-project/commit/d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a DIFF:

[clang] c9fd92d - [clang] Improve diagnostics on implicitly deleted defaulted comparisons

Author: Matheus Izvekov Date: 2021-03-13T01:13:52+01:00 New Revision: c9fd92d573988c59b7a613f07909596cdad36095 URL: https://github.com/llvm/llvm-project/commit/c9fd92d573988c59b7a613f07909596cdad36095 DIFF:

[clang] 1819222 - [clang] tests: cleanup, update and add some new ones

Author: Matheus Izvekov Date: 2021-04-09T17:24:08+02:00 New Revision: 18192228602c6a8093fb0eefa863ab854dd03e59 URL: https://github.com/llvm/llvm-project/commit/18192228602c6a8093fb0eefa863ab854dd03e59 DIFF:

[clang] d98c34f - [clang] fix error recovery ICE on copy elision when returing invalid variable

Author: Matheus Izvekov Date: 2021-09-03T20:34:08+02:00 New Revision: d98c34f4d7950f531661ba3f498222ccf6239a0f URL: https://github.com/llvm/llvm-project/commit/d98c34f4d7950f531661ba3f498222ccf6239a0f DIFF:

[clang] 2d6829b - [clang] disable implicit moves when not in CPlusPLus

Author: Matheus Izvekov Date: 2021-09-14T11:29:47+02:00 New Revision: 2d6829bbbe6877920d9be1db93b9f3fc85b43d10 URL: https://github.com/llvm/llvm-project/commit/2d6829bbbe6877920d9be1db93b9f3fc85b43d10 DIFF:

[clang] 68b9d8e - [clang] fix transformation of template arguments of 'auto' type constraints

Author: Matheus Izvekov Date: 2021-09-08T03:22:34+02:00 New Revision: 68b9d8ed7abe4046992ae1557990edfbb3a772bc URL: https://github.com/llvm/llvm-project/commit/68b9d8ed7abe4046992ae1557990edfbb3a772bc DIFF:

[clang] 03282f2 - [clang] C++98 implicit moves are back with a vengeance

Author: Matheus Izvekov Date: 2021-07-13T19:16:49+02:00 New Revision: 03282f2fe14e9dd61aaeeda3785f56c7ccb4f3c9 URL: https://github.com/llvm/llvm-project/commit/03282f2fe14e9dd61aaeeda3785f56c7ccb4f3c9 DIFF:

[clang] 219790c - [clang] fix canonicalization of nested name specifiers

Author: Matheus Izvekov Date: 2021-08-03T22:39:48+02:00 New Revision: 219790c1f53665a8b5f7578472e5c2675f9bec6a URL: https://github.com/llvm/llvm-project/commit/219790c1f53665a8b5f7578472e5c2675f9bec6a DIFF:

[clang] e64e692 - [clang] fix crash on template instantiation of invalid requires expressions

Author: Matheus Izvekov Date: 2021-08-03T23:16:04+02:00 New Revision: e64e6924b8aef8d48117beb6e87162109ac2512c URL: https://github.com/llvm/llvm-project/commit/e64e6924b8aef8d48117beb6e87162109ac2512c DIFF:

[clang] 0c7cd4a - [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr

Author: Matheus Izvekov Date: 2021-07-28T23:27:43+02:00 New Revision: 0c7cd4a873138f2116403a733274c8cb7dbf925f URL: https://github.com/llvm/llvm-project/commit/0c7cd4a873138f2116403a733274c8cb7dbf925f DIFF:

[clang] 87aa318 - [clang] fix concepts crash on substitution failure during normalization

Author: Matheus Izvekov Date: 2021-07-28T23:28:45+02:00 New Revision: 87aa31827b293127619e2ef96e80baf709eae338 URL: https://github.com/llvm/llvm-project/commit/87aa31827b293127619e2ef96e80baf709eae338 DIFF:

[clang] d9308aa - [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

Author: Matheus Izvekov Date: 2021-09-21T21:41:20+02:00 New Revision: d9308aa39b236064a680ca57178af3c731e13e49 URL: https://github.com/llvm/llvm-project/commit/d9308aa39b236064a680ca57178af3c731e13e49 DIFF:

[clang] 37adc4f - [clang] set templates as invalid when any of the parameters are invalid

Author: Matheus Izvekov Date: 2021-09-25T04:04:47+02:00 New Revision: 37adc4f957c2383a625e2e593ba1d18a25d92b91 URL: https://github.com/llvm/llvm-project/commit/37adc4f957c2383a625e2e593ba1d18a25d92b91 DIFF:

[clang] 489561d - [clang] fix typo correction not looking for candidates in base classes.

Author: Matheus Izvekov Date: 2021-10-16T00:35:22+02:00 New Revision: 489561d46381d41a068beed1a2e18e00f0660248 URL: https://github.com/llvm/llvm-project/commit/489561d46381d41a068beed1a2e18e00f0660248 DIFF:

[clang] af10d6f - [clang] don't instantiate templates with injected arguments

Author: Matheus Izvekov Date: 2021-09-29T23:19:13+02:00 New Revision: af10d6f350ff3e92c6ffae66cc9dac36884cdd55 URL: https://github.com/llvm/llvm-project/commit/af10d6f350ff3e92c6ffae66cc9dac36884cdd55 DIFF:

[clang] 1f6458c - [clang] NFC: remove duplicated code around type constraint and templ arg subst

Author: Matheus Izvekov Date: 2021-09-29T23:05:46+02:00 New Revision: 1f6458cb1944b69f052db463e5f2c6304f16b256 URL: https://github.com/llvm/llvm-project/commit/1f6458cb1944b69f052db463e5f2c6304f16b256 DIFF:

[clang] 85914b7 - [clang] fix regression deducing pack expansion arguments introduced by D110216

Author: Matheus Izvekov Date: 2021-11-19T03:36:20+01:00 New Revision: 85914b757015dfbc780dc254696acb95b8dc7679 URL: https://github.com/llvm/llvm-project/commit/85914b757015dfbc780dc254696acb95b8dc7679 DIFF:

[clang] 21ed00b - [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload

Author: Matheus Izvekov Date: 2021-11-16T03:09:50+01:00 New Revision: 21ed00bc1bfd2b0b81d288f7f096a31079c24c4a URL: https://github.com/llvm/llvm-project/commit/21ed00bc1bfd2b0b81d288f7f096a31079c24c4a DIFF:

[clang] 9fec50f - [cmake] use project relative paths when generating ASTNodeAPI.json

Author: Matheus Izvekov Date: 2021-11-15T12:35:34+01:00 New Revision: 9fec50f001b1ab86ff36c6e92336ae1c1d3fcdef URL: https://github.com/llvm/llvm-project/commit/9fec50f001b1ab86ff36c6e92336ae1c1d3fcdef DIFF:

[clang] 2d7fba5 - [clang] deprecate frelaxed-template-template-args, make it on by default

Author: Matheus Izvekov Date: 2021-10-27T22:48:27+02:00 New Revision: 2d7fba5f95f0614f6f2c4a4ed966b307d617898b URL: https://github.com/llvm/llvm-project/commit/2d7fba5f95f0614f6f2c4a4ed966b307d617898b DIFF:

[clang] 086e111 - [clang] NFC: include non friendly types and missing sugar in test expectations

Author: Matheus Izvekov Date: 2021-10-27T23:03:29+02:00 New Revision: 086e111216bc4fb8065aa7ef4bc226380d1c237e URL: https://github.com/llvm/llvm-project/commit/086e111216bc4fb8065aa7ef4bc226380d1c237e DIFF:

[clang] 1d68eca - [clang] fix oops: enable implicit moves in MSVC compatibility mode

Author: Matheus Izvekov Date: 2021-07-20T23:32:05+02:00 New Revision: 1d68ecafd6ad9ba8857c78e567abbc58810329c1 URL: https://github.com/llvm/llvm-project/commit/1d68ecafd6ad9ba8857c78e567abbc58810329c1 DIFF:

[clang] 4819b75 - [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

Author: Matheus Izvekov Date: 2021-07-28T03:09:31+02:00 New Revision: 4819b751bd875f458eb0060f7c586aa9ac41965c URL: https://github.com/llvm/llvm-project/commit/4819b751bd875f458eb0060f7c586aa9ac41965c DIFF:

[clang] 20555a1 - [clang] P2266 implicit moves STL workaround

Author: Matheus Izvekov Date: 2021-07-26T22:21:31+02:00 New Revision: 20555a15a596012ef827e29b665db53a4fc0b86c URL: https://github.com/llvm/llvm-project/commit/20555a15a596012ef827e29b665db53a4fc0b86c DIFF:

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

mizvekov wrote: Yep, I definitely I agree this is a good change, thanks for working on it! I thought about doing the same at the time, but I just didn't have the bandwidth for yet another patch with a lot of test churn :) https://github.com/llvm/llvm-project/pull/65214

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/70282 >From 9f3711c112159c57becae105561bc988a0caaeb5 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 26 Oct 2023 06:07:57 +0200 Subject: [PATCH 1/2] [clang][driver] remove accidentally added NoXarchOption

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"], "fverify-intermediate-code">, def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">, Group, Visibility<[ClangOption, CLOption, DXCOption]>, HelpText<"Disable verification of LLVM

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"], "fverify-intermediate-code">, def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">, Group, Visibility<[ClangOption, CLOption, DXCOption]>, HelpText<"Disable verification of LLVM

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/70282 Present shortcomings are that this only works for non-LTO builds, and that this new pass doesn't work quite the same as the IR verification flag, as it runs between every machine pass and is thus much more

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/70282 >From b2006f46ebfd1da17014cf6c577da4700c355d00 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 12:09:15 +0200 Subject: [PATCH] [Clang][Driver] Add new flags to control machine instruction

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

mizvekov wrote: I don't disagree that if we stop at this step, then the flag doesn't buy much. But it would be worthwhile if we ever implemented LTO integration or implemented a lightweight machine verification which runs the pass 1 or 2 times, which would work similarly to the IR

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

mizvekov wrote: > It looks like the Itanium mangleTypeName() canonicalizes the type itself; > should the MSVC mangleTypeName do the same thing? It's done on purpose: `MicrosoftMangle.cpp`: ```cpp void MicrosoftCXXNameMangler::mangleType(QualType T, SourceRange Range,

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/66816 Hashing the sugared type instead of the canonical type meant that a simple example like this would always fail under MSVC: ``` static auto l() {} int main() { auto a = l; a(); } ``` `clang

[clang] Improve sort mangled (PR #67066)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/67066 This is stacked on top of https://github.com/llvm/llvm-project/pull/66816 Disregard first commit. >From 47bd926491f28f722c429f3ab4a993aa5d85d1b7 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Tue, 19 Sep

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/67751 Stacked, consider only last commit. >From 7009ebf7f2016816b5cbb694e0611cd2a86d7cf1 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 28 Sep 2023 22:38:59 +0200 Subject: [PATCH 1/2] [clang] implement

[clang] [clang] implement common sugared type of inst-dependent DecltypeType (PR #67739)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/67739 >From 7009ebf7f2016816b5cbb694e0611cd2a86d7cf1 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 28 Sep 2023 22:38:59 +0200 Subject: [PATCH] [clang] implement common sugared type of inst-dependent

[clang] [clang] implement common sugared type of inst-dependent DecltypeType (PR #67739)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/67739 While a DecltypeType node itself is not uniqued, an instantiation dependent DecltypeType will have a DependentDecltypeType as an underlying type, which is uniqued. In that case, there can be non-identical

[clang] [clang] implement common sugared type of inst-dependent DecltypeType (PR #67739)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/67739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/67751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/67751 >From 5919cbf2a91f1cff3e48ba10cd2e9f5d2f5023f0 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Fri, 29 Sep 2023 00:49:16 +0200 Subject: [PATCH] [NFC][clang] change remaining context-dependent type nodes to

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/68015 This helps check clang generated good IR in the first place, as otherwise this can cause UB in subsequent passes, with the final verification pass not catching any issues. This for example would have helped

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

@@ -923,6 +923,8 @@ void EmitAssemblyHelper::RunOptimizationPipeline( PB.crossRegisterProxies(LAM, FAM, CGAM, MAM); ModulePassManager MPM; + // Add a verifier pass, before any other passes, to catch CodeGen issues. + MPM.addPass(VerifierPass());

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

mizvekov wrote: @tru Would you agree to backport this fix to 17? Strictly speaking there is an API change here, but I think it's a bit obscure and in any case, this change could catch misuse of it. https://github.com/llvm/llvm-project/pull/66816 ___

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/67066 >From 44d43a8e7fa5b19671bc3f56f934dfb63a632aa4 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 21 Sep 2023 22:57:27 +0200 Subject: [PATCH] [NFC][Clang][CodeGen] Improve performance for vtable metadata

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

mizvekov wrote: Yep, it's a regression from 16. This bug makes ubsan unusable for MSVC target in real world projects. We could alternatively backport just the canonicalization, but not the rename, if that makes it better. https://github.com/llvm/llvm-project/pull/66816

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

@@ -1020,21 +1022,23 @@ void EmitAssemblyHelper::RunOptimizationPipeline( } if (CodeGenOpts.FatLTO) { - MPM = PB.buildFatLTODefaultPipeline(Level, PrepareForThinLTO, - PrepareForThinLTO || -

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

mizvekov wrote: Weird, the commit in the MR has a description, but it lost the description when merging through the github interface. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] e897014 - [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (#67066)

Author: Matheus Izvekov Date: 2023-10-03T03:23:34+02:00 New Revision: e8970141ec4326acb139789db01fb7c51538a4be URL: https://github.com/llvm/llvm-project/commit/e8970141ec4326acb139789db01fb7c51538a4be DIFF:

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

@@ -923,6 +923,8 @@ void EmitAssemblyHelper::RunOptimizationPipeline( PB.crossRegisterProxies(LAM, FAM, CGAM, MAM); ModulePassManager MPM; + // Add a verifier pass, before any other passes, to catch CodeGen issues. + MPM.addPass(VerifierPass());

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

mizvekov wrote: @kstoimenov I believe you are supposed to notify the MR in case of reverts, otherwise I could have missed this if I wasn't awake. I believe in this case the bot is misconfigured, it's using `-Werror,-Wmissing-field-initializers`, the 'error' is just a missing initializer,

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

https://github.com/mizvekov deleted https://github.com/llvm/llvm-project/pull/68015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68015 >From be5fab19a147c979c7e8afb421d157b194f4a125 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 2 Oct 2023 13:52:35 +0200 Subject: [PATCH] [clang][codegen] Add a verifier IR pass before any further

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

mizvekov wrote: Thanks for the review. I think the change stands on itself, as we are avoiding storing one pointer per Type Node instance, for the cost of one extra pointer per ASTContext, which is negligible. These type nodes we are changing here are old, at least as far back as 2008. In

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/67751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/67751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

mizvekov wrote: @rnk Since @efriedma-quic seems to be unavailable, any objections we move forward and merge this, as is? https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

mizvekov wrote: CC @vgvassilev @pcanal @Sterling-Augustine As the removed workaround dates back to the initial implementation imported in 0dd191a5c4bf27cc8a2b6033436b00f0cbdc4ce7 from Cling. https://github.com/llvm/llvm-project/pull/67566 ___

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

mizvekov wrote: It's recommended to avoid introducing pure clang-format changes mixed with other non-style changes. The recommended way to avoid that is to run clang-format on the modified files on a separate commit, and then just merge that, no review required.

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/68015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/67751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

mizvekov wrote: > Could you please send me a link which describes that process? I assume that > by MR you mean merge request? Thanks, Kirill > […](#) > On Mon, Oct 2, 2023 at 5:24 PM Matheus Izvekov ***@***.***> wrote: > @kstoimenov I believe you are supposed to

[clang] [CLang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/68172 None >From 4aec8113bc23d361164f1e164c8e4e36a9eb0ad0 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH] [CLang][Driver] Add new flags to control IR verification

[clang] [Clang][CodeGen] Fix use of CXXThisValue with StrictVTablePointers (PR #68169)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/68169 When emitting non-virtual base initializers for the constructor prologue, we would potentially use a re-laundered this pointer value from a previous block, which subsequently would not dominate this use. With

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68172 >From ee49cd2bddc21be68f73fca7cb344150cd7ad7a6 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH] [CLang][Driver] Add new flags to control IR verification ---

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68172 >From 8a0226386732cea374558a38475c7d629c84ef28 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH] [CLang][Driver] Add new flags to control IR verification ---

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68172 >From 634c0f8ea4acd0694d89c3e2d278e6bcb78b923f Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH] [Clang][Driver] Add new flags to control IR verification ---

[clang] [clang][Index] Use canonical function parameter types in USRs (PR #68222)

@@ -265,10 +265,13 @@ void USRGenerator::VisitFunctionDecl(const FunctionDecl *D) { Out << '>'; } + QualType CanonicalType = D->getType().getCanonicalType(); // Mangle in type information for the arguments. - for (auto *PD : D->parameters()) { -Out << '#'; -

[clang] [clang][Index] Use canonical function parameter types in USRs (PR #68222)

https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/68222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/68172 >From a5414db5e14cb40d062e54e780293cabc432197a Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 04:39:11 +0200 Subject: [PATCH] [Clang][Driver] Add new flags to control IR verification ---

[clang] [Clang][Driver] Add new flags to control IR verification (PR #68172)

@@ -146,6 +146,13 @@ Non-comprehensive list of changes in this release New Compiler Flags -- +* ``-fverify-intermediate-code`` and it's complement ``-fno-verify-intermediate-code``. + Enables or disables verification of the generated LLVM IR. + It's

  1   2   3   4   5   >