patch for formatter bug 38525

Hi, Please see the attached patch file and test case for Bug 38525 in Formatter. Thanks, Owen Index: lib/Format/ContinuationIndenter.cpp === --- lib/Format/ContinuationIndenter.cpp

Fwd: patch file for bug 38557

Hi, Attached is the patch file for Bug 38557 ( https://bugs.llvm.org/show_bug.cgi?id=38557). Thanks, Owen Index: UnwrappedLineParser.cpp === --- UnwrappedLineParser.cpp (revision 339102) +++ UnwrappedLineParser.cpp (working copy) @@

Re: Fwd: patch file for bug 38557

can take over, otherwise we can > get it into trunk for you :) > > All the best, Jonas > > Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits: > > Hi, > > Attached is the patch file for Bug 38557 ( > https:

r342708 - [clang-format] Do not merge short case labels if followed by a block.

Author: owenpan Date: Thu Sep 20 20:46:36 2018 New Revision: 342708 URL: http://llvm.org/viewvc/llvm-project?rev=342708=rev Log: [clang-format] Do not merge short case labels if followed by a block. Do not allow short case labels on a single line if the label is followed by a left brace. Fixes

r343305 - [ClangFormat] 'try' of function-try-block doesn't obey BraceWrapping

Author: owenpan Date: Fri Sep 28 02:17:00 2018 New Revision: 343305 URL: http://llvm.org/viewvc/llvm-project?rev=343305=rev Log: [ClangFormat] 'try' of function-try-block doesn't obey BraceWrapping It should respond to AfterFunction, not AfterControlStatement. Fixes PR39067 Modified:

r342116 - [clang-format] Wrapped block after case label should not be merged into one line

Author: owenpan Date: Thu Sep 13 00:27:15 2018 New Revision: 342116 URL: http://llvm.org/viewvc/llvm-project?rev=342116=rev Log: [clang-format] Wrapped block after case label should not be merged into one line PR38854 Differential Revision: http://reviews.llvm.org/D51719 Modified:

r357877 - [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413

Author: owenpan Date: Sun Apr 7 14:05:52 2019 New Revision: 357877 URL: http://llvm.org/viewvc/llvm-project?rev=357877=rev Log: [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413 Differential Revision: https://reviews.llvm.org/D60374 Modified:

r357851 - [clang-format] Fix Bug 41407

Author: owenpan Date: Sat Apr 6 16:10:11 2019 New Revision: 357851 URL: http://llvm.org/viewvc/llvm-project?rev=357851=rev Log: [clang-format] Fix Bug 41407 Differential Revision: https://reviews.llvm.org/D60359 Modified: cfe/trunk/lib/Format/ContinuationIndenter.cpp

r357957 - [clang-format] Add AfterCaseLabel to BraceWrapping

Author: owenpan Date: Mon Apr 8 16:36:25 2019 New Revision: 357957 URL: http://llvm.org/viewvc/llvm-project?rev=357957=rev Log: [clang-format] Add AfterCaseLabel to BraceWrapping Fixes PR38686 llvm-svn: 52527 Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst

Re: r357877 - [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413

ate it to 'PR' (so PR41413 in this example). > > Thanks! > --paulr > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > Owen Pan via cfe-commits > > Sent: Sunday, April 07, 2019 5:06 PM > > T

r359687 - [clang-format] Fix bug that misses some function-like macro usages

Author: owenpan Date: Wed May 1 08:03:41 2019 New Revision: 359687 URL: http://llvm.org/viewvc/llvm-project?rev=359687=rev Log: [clang-format] Fix bug that misses some function-like macro usages Fixes PR41483 Differential Revision: https://reviews.llvm.org/D61297 Modified:

r359711 - [clang-format] Fix a bug in AlignConsecutiveDeclarations.

Author: owenpan Date: Wed May 1 11:23:44 2019 New Revision: 359711 URL: http://llvm.org/viewvc/llvm-project?rev=359711=rev Log: [clang-format] Fix a bug in AlignConsecutiveDeclarations. Fixes PR37175 Differential Revision: https://reviews.llvm.org/D61222 Modified:

r358710 - [clang-format] Fix incorrect formatting of keyword macro definition

Author: owenpan Date: Thu Apr 18 13:17:08 2019 New Revision: 358710 URL: http://llvm.org/viewvc/llvm-project?rev=358710=rev Log: [clang-format] Fix incorrect formatting of keyword macro definition See PR39719 Differential Revision: https://reviews.llvm.org/D60853 Modified:

r359943 - [clang-format] Fix bug in block comment reflow that joins * and /

Author: owenpan Date: Fri May 3 16:15:40 2019 New Revision: 359943 URL: http://llvm.org/viewvc/llvm-project?rev=359943=rev Log: [clang-format] Fix bug in block comment reflow that joins * and / Fixes PR41213 Differential Revision: https://reviews.llvm.org/D61276 Modified:

r360256 - [clang] Fix a bug that reports UTF32 (LE) files as UTF16 (LE) ones

Author: owenpan Date: Wed May 8 06:49:17 2019 New Revision: 360256 URL: http://llvm.org/viewvc/llvm-project?rev=360256=rev Log: [clang] Fix a bug that reports UTF32 (LE) files as UTF16 (LE) ones Also fix a typo for the SCSU byte order mark. Differential Revision:

r360257 - [clang-format] Fix the crash when formatting unsupported encodings

Author: owenpan Date: Wed May 8 07:11:12 2019 New Revision: 360257 URL: http://llvm.org/viewvc/llvm-project?rev=360257=rev Log: [clang-format] Fix the crash when formatting unsupported encodings Fixes PR33946 Differential Revision: https://reviews.llvm.org/D61559 Modified:

r359029 - [clang-format] Fix bug in reflow of block comments containing CR/LF

Author: owenpan Date: Tue Apr 23 13:29:46 2019 New Revision: 359029 URL: http://llvm.org/viewvc/llvm-project?rev=359029=rev Log: [clang-format] Fix bug in reflow of block comments containing CR/LF Fix PR36119 Differential Revision: https://reviews.llvm.org/D60996 Modified:

r359280 - [clang-format] Fix documentation for FixNamespaceComments

Author: owenpan Date: Fri Apr 26 00:05:47 2019 New Revision: 359280 URL: http://llvm.org/viewvc/llvm-project?rev=359280=rev Log: [clang-format] Fix documentation for FixNamespaceComments Fixes PR40409 Differential Revision: https://reviews.llvm.org/D61174 Modified:

r369157 - [clang-format] Fix the bug that joins template closer and > or >>

Author: owenpan Date: Fri Aug 16 14:49:17 2019 New Revision: 369157 URL: http://llvm.org/viewvc/llvm-project?rev=369157=rev Log: [clang-format] Fix the bug that joins template closer and > or >> Also fixes a buggy test case. See PR42404 Differential Revision: https://reviews.llvm.org/D66332

r369214 - [clang-format] Fix a bug that joins template closer and =

Author: owenpan Date: Sun Aug 18 11:51:39 2019 New Revision: 369214 URL: http://llvm.org/viewvc/llvm-project?rev=369214=rev Log: [clang-format] Fix a bug that joins template closer and = Also fixes the documentation for SpaceBeforeAssignmentOperators. See discussions at

r368507 - [clang-format] Add SpaceInEmptyBlock option for WebKit

Author: owenpan Date: Sat Aug 10 00:51:21 2019 New Revision: 368507 URL: http://llvm.org/viewvc/llvm-project?rev=368507=rev Log: [clang-format] Add SpaceInEmptyBlock option for WebKit See PR40840 Differential Revision: https://reviews.llvm.org/D65925 Modified:

r368539 - [clang-format] Expand AllowShortBlocksOnASingleLine for WebKit

Author: owenpan Date: Sun Aug 11 10:48:36 2019 New Revision: 368539 URL: http://llvm.org/viewvc/llvm-project?rev=368539=rev Log: [clang-format] Expand AllowShortBlocksOnASingleLine for WebKit See PR40840 Differential Revision: https://reviews.llvm.org/D66059 Modified:

r371571 - [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists

Author: owenpan Date: Tue Sep 10 16:26:45 2019 New Revision: 371571 URL: http://llvm.org/viewvc/llvm-project?rev=371571=rev Log: [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists See PR18455. Differential Revision: https://reviews.llvm.org/D67395 Modified:

r367648 - [clang-format] Fix a bug that doesn't break braces before unions for Allman

Author: owenpan Date: Thu Aug 1 21:30:42 2019 New Revision: 367648 URL: http://llvm.org/viewvc/llvm-project?rev=367648=rev Log: [clang-format] Fix a bug that doesn't break braces before unions for Allman Differential Revision: https://reviews.llvm.org/D65631 Modified:

[clang] 163c13f - [clang-format] Fix formatting of the code that follows C# Lambda Expressions

Author: Peter Stys Date: 2021-12-17T10:42:15-08:00 New Revision: 163c13fed9f68c31a14b3d2409b994909f0600bb URL: https://github.com/llvm/llvm-project/commit/163c13fed9f68c31a14b3d2409b994909f0600bb DIFF: https://github.com/llvm/llvm-project/commit/163c13fed9f68c31a14b3d2409b994909f0600bb.diff

[clang] 212e6c9 - [doc] Fix regex in ClangFormatStyleOptions for IncludeCategories

Author: Joshua Huels Date: 2021-12-17T18:46:12-08:00 New Revision: 212e6c99776f393e0af368ca2086eb8bae2ee1ed URL: https://github.com/llvm/llvm-project/commit/212e6c99776f393e0af368ca2086eb8bae2ee1ed DIFF: https://github.com/llvm/llvm-project/commit/212e6c99776f393e0af368ca2086eb8bae2ee1ed.diff

[clang] b9f6e09 - [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

Author: Owen Pan Date: 2021-12-21T16:42:52-08:00 New Revision: b9f6e09b850acf2ade04f22fa423e7cc0f075e62 URL: https://github.com/llvm/llvm-project/commit/b9f6e09b850acf2ade04f22fa423e7cc0f075e62 DIFF: https://github.com/llvm/llvm-project/commit/b9f6e09b850acf2ade04f22fa423e7cc0f075e62.diff

[clang] c41b3b0 - [clang-format] Adjust braced list detection

Author: Tan S. B Date: 2021-12-05T22:39:29-08:00 New Revision: c41b3b0fa0f4f70aad8deaf48bcd42a04385066c URL: https://github.com/llvm/llvm-project/commit/c41b3b0fa0f4f70aad8deaf48bcd42a04385066c DIFF: https://github.com/llvm/llvm-project/commit/c41b3b0fa0f4f70aad8deaf48bcd42a04385066c.diff

[clang] 7fb2d9f - [clang-format] Fix crashes due to missing l_paren

Author: Owen Pan Date: 2022-03-16T01:45:20-07:00 New Revision: 7fb2d9f9b5efaf15c10711826b496ee65f70491d URL: https://github.com/llvm/llvm-project/commit/7fb2d9f9b5efaf15c10711826b496ee65f70491d DIFF: https://github.com/llvm/llvm-project/commit/7fb2d9f9b5efaf15c10711826b496ee65f70491d.diff

[clang] 0a0cc3c - [clang-format] Don't unwrap lines preceded by line comments

Author: Owen Pan Date: 2022-03-14T19:16:29-07:00 New Revision: 0a0cc3c58a74f9574d9f4df244e3bd0a8e805945 URL: https://github.com/llvm/llvm-project/commit/0a0cc3c58a74f9574d9f4df244e3bd0a8e805945 DIFF: https://github.com/llvm/llvm-project/commit/0a0cc3c58a74f9574d9f4df244e3bd0a8e805945.diff

[clang] 492cb7b - [clang-format] Fix a crash in qualifier alignment

Author: Owen Pan Date: 2022-04-01T17:30:59-07:00 New Revision: 492cb7bf91648058f3fc9ca37f9383786f7ce718 URL: https://github.com/llvm/llvm-project/commit/492cb7bf91648058f3fc9ca37f9383786f7ce718 DIFF: https://github.com/llvm/llvm-project/commit/492cb7bf91648058f3fc9ca37f9383786f7ce718.diff

[clang] eaef54f - [clang-format] Revert a feature in RemoveBracesLLVM

Author: Owen Pan Date: 2022-02-03T02:56:09-08:00 New Revision: eaef54f21388350ca72d4dadf33728f70566e531 URL: https://github.com/llvm/llvm-project/commit/eaef54f21388350ca72d4dadf33728f70566e531 DIFF: https://github.com/llvm/llvm-project/commit/eaef54f21388350ca72d4dadf33728f70566e531.diff

[clang] 35f7dd6 - [clang-format][NFC] Fix a bug in setting type FunctionLBrace

Author: Owen Pan Date: 2022-02-04T11:36:30-08:00 New Revision: 35f7dd601d33219fafa2c0d308e187df3e36847a URL: https://github.com/llvm/llvm-project/commit/35f7dd601d33219fafa2c0d308e187df3e36847a DIFF: https://github.com/llvm/llvm-project/commit/35f7dd601d33219fafa2c0d308e187df3e36847a.diff

[clang] 7cd441f - [clang][NFC] Wrap TYPE_SWITCH in "do while (0)" in the interpreter

Author: Owen Pan Date: 2022-01-24T09:05:27-08:00 New Revision: 7cd441ff537e00c743236658bfbcfc16c30ce031 URL: https://github.com/llvm/llvm-project/commit/7cd441ff537e00c743236658bfbcfc16c30ce031 DIFF: https://github.com/llvm/llvm-project/commit/7cd441ff537e00c743236658bfbcfc16c30ce031.diff

[clang] f465a48 - [clang-format] Fix segmentation fault when formatting nested namespaces

Author: Arkadiy Yudintsev Date: 2023-09-05T11:12:14-07:00 New Revision: f465a482caa94d01a2dd74e4c673adeb1f222f2f URL: https://github.com/llvm/llvm-project/commit/f465a482caa94d01a2dd74e4c673adeb1f222f2f DIFF:

[clang] 4146b30 - Revert "[Format] Modernize SpaceBeforeParensCustom (NFC)"

Author: Owen Pan Date: 2023-09-05T12:03:14-07:00 New Revision: 4146b30785fb5db6fa4da47e6198f7bd961559c5 URL: https://github.com/llvm/llvm-project/commit/4146b30785fb5db6fa4da47e6198f7bd961559c5 DIFF: https://github.com/llvm/llvm-project/commit/4146b30785fb5db6fa4da47e6198f7bd961559c5.diff

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

@@ -3369,9 +3369,13 @@ bool clang::format::UnwrappedLineParser::parseRequires() { case tok::kw_volatile: case tok::kw_const: case tok::comma: - FormatTok = Tokens->setPosition(StoredPosition); - parseRequiresExpression(RequiresToken); - return

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9ae41a1 - [clang-format][doc] Fix a '' (in c669541c969c) that meant to be ``

Author: Owen Pan Date: 2023-09-10T12:52:49-07:00 New Revision: 9ae41a1472b2529a9028d003ca0e8e3812348742 URL: https://github.com/llvm/llvm-project/commit/9ae41a1472b2529a9028d003ca0e8e3812348742 DIFF: https://github.com/llvm/llvm-project/commit/9ae41a1472b2529a9028d003ca0e8e3812348742.diff

[clang] b908123 - [clang-format][NFC] Minor cleanup of token annotator and test cases

Author: Owen Pan Date: 2023-09-11T00:18:57-07:00 New Revision: b908123c3c1934c03b5183318a47d321fb796260 URL: https://github.com/llvm/llvm-project/commit/b908123c3c1934c03b5183318a47d321fb796260 DIFF: https://github.com/llvm/llvm-project/commit/b908123c3c1934c03b5183318a47d321fb796260.diff

[clang] c22c0c4 - [clang-format][NFC] Change conjunction of isNot() with one !isOneOf()

Author: Owen Pan Date: 2023-09-07T00:20:02-07:00 New Revision: c22c0c4769da8084378675fe58fd033dfa73ad1e URL: https://github.com/llvm/llvm-project/commit/c22c0c4769da8084378675fe58fd033dfa73ad1e DIFF: https://github.com/llvm/llvm-project/commit/c22c0c4769da8084378675fe58fd033dfa73ad1e.diff

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/65933: Fixes #65877. >From 86b83692a9f13b8c608190f6abc3111719583730 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 11 Sep 2023 01:00:24 -0700 Subject: [PATCH] [clang-format] Fix a bug in annotating '&&' enclosed

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

https://github.com/owenca review_requested https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating `&&` enclosed in `<` and `>` (PR #65933)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/65933: >From 70aafbc4717264205796fa2ea67d78482f9f2a0d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 11 Sep 2023 01:00:24 -0700 Subject: [PATCH] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&`

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66354: See https://reviews.llvm.org/D136154#3890747 for context. Fixes part of #58592. >From 9a15ec3256e2d380d5eb70f0751ea1bb457895dd Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 14 Sep 2023 02:59:43 -0700

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From 83b81df954391c38c123a116ab5c39acd29a3a87 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66569 None >From d570d3bb4d0bf9a49b51c25857958988329d398f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

@@ -370,9 +364,9 @@ bool UnwrappedLineParser::parseLevel(const FormatToken *OpeningBrace, else if (FormatTok->getType() == TT_MacroBlockEnd) kind = tok::r_brace; -auto ParseDefault = [this, OpeningBrace, NextLevelLBracesType, IfKind, +auto ParseDefault =

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

@@ -1135,6 +1145,14 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresExpressions) { EXPECT_TOKEN(Tokens[3], tok::kw_requires, TT_RequiresExpression); EXPECT_TOKEN(Tokens[4], tok::l_paren, TT_RequiresExpressionLParen); EXPECT_TOKEN(Tokens[14], tok::l_brace,

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause);

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause);

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/owenca commented: Nits. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH 1/2] [clang-format][NFC] Clean up signatures of some parser functions

[clang] 58c67e7 - [clang-format] Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

Author: Galen Elias Date: 2023-08-31T14:21:19-07:00 New Revision: 58c67e724f718be06ea43c766871135a338c2d55 URL: https://github.com/llvm/llvm-project/commit/58c67e724f718be06ea43c766871135a338c2d55 DIFF: https://github.com/llvm/llvm-project/commit/58c67e724f718be06ea43c766871135a338c2d55.diff

[clang] a8fbc16 - Revert "[git-clang-format] Fix typo in help message"

Author: Owen Pan Date: 2023-09-07T15:05:46-07:00 New Revision: a8fbc16ebebedce98d06782680fcafae0cf06e7d URL: https://github.com/llvm/llvm-project/commit/a8fbc16ebebedce98d06782680fcafae0cf06e7d DIFF: https://github.com/llvm/llvm-project/commit/a8fbc16ebebedce98d06782680fcafae0cf06e7d.diff

[clang] 210e7b3 - [clang-format] Improve line-breaking in LambdaBodyIndentation: OuterScope

Author: Jon Phillips Date: 2023-09-08T14:34:00-07:00 New Revision: 210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc URL: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc DIFF: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc.diff

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

@@ -1599,6 +1600,15 @@ unsigned ContinuationIndenter::moveStateToNextToken(LineState , State.Column += Current.ColumnWidth; State.NextToken = State.NextToken->Next; + // Verilog case labels are are on the same unwrapped lines as the statements + // that follow.

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 14feca5 - [clang-format][NFC] Replace EXPECT_EQ() with verifyFormat()

Author: Owen Pan Date: 2023-08-30T14:55:26-07:00 New Revision: 14feca5d14f1b158f468f01039302da2ca396b14 URL: https://github.com/llvm/llvm-project/commit/14feca5d14f1b158f468f01039302da2ca396b14 DIFF: https://github.com/llvm/llvm-project/commit/14feca5d14f1b158f468f01039302da2ca396b14.diff

[clang] 0863051 - Reland "[clang-format] Annotate constructor/destructor names"

Author: Owen Pan Date: 2023-08-29T13:14:52-07:00 New Revision: 0863051208870b284a1ee899defc0ba2b6e53fc4 URL: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4 DIFF: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4.diff

[clang] 77b2fc8 - [clang-format][NFC] Reformat and fix file mode

Author: Owen Pan Date: 2023-08-30T18:35:24-07:00 New Revision: 77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec URL: https://github.com/llvm/llvm-project/commit/77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec DIFF: https://github.com/llvm/llvm-project/commit/77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec.diff

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66354: >From 73669f7d04070feade2282384478e96b8bc6d727 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 14 Sep 2023 02:59:43 -0700 Subject: [PATCH] [clang-format] Fix a bug in ContinuationIndenter See

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

@@ -2237,15 +2237,10 @@ ContinuationIndenter::createBreakableToken(const FormatToken , LineState , bool AllowBreak) { unsigned StartColumn = State.Column - Current.ColumnWidth; if (Current.isStringLiteral()) { -// Strings in

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

@@ -2783,17 +2783,17 @@ the configuration (without a prefix: ``Auto``). const char* x = "veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; - In C#, Java, and JavaScript: + In C# and Java: .. code-block:: c++ true: - var x =

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

@@ -3497,6 +3497,15 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const { Tok->setType(TT_TrailingReturnArrow); break; } +if (Tok->isNot(TT_TrailingAnnotation)) owenca wrote: Because

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/69249 Skip TrailingAnnotation when looking for TrailingReturnArrow. Fixes #69234. >From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 16 Oct 2023 13:38:09 -0700 Subject:

[clang] [clang-format] Fix a bug in mis-annotating arrows (PR #67780)

owenca wrote: See #69249. https://github.com/llvm/llvm-project/pull/67780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/69249 >From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 16 Oct 2023 13:38:09 -0700 Subject: [PATCH 1/2] [clang-format] Fix a bug in annotating TrailingReturnArrow Skip

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

owenca wrote: > This allows git-clang-format to be used on a Windows terminal without > manually needing to find the path and invoke the python interpreter. We have > a similar script for `scan-build`. Can you open an issue and link to it from here? It seems `git clang-format` works in

[clang] [clang-format][NFC] Annotate control statement r_braces (PR #68621)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align comments over scopes (PR #68743)

=?utf-8?q?Björn_Schäpers?= Message-ID: In-Reply-To: @@ -182,7 +182,7 @@ TEST_F(FormatTestComments, UnderstandsSingleLineComments) { "int a; // This is unrelated")); EXPECT_EQ("class C {\n" " void f() { // This does something ..\n" -

[clang] 23d6a6d - [clang-format] Fix the version for a newly added option

Author: Owen Pan Date: 2023-10-25T05:45:32-07:00 New Revision: 23d6a6dfc1bc6e79bdcc48a59a0698a5b79262e9 URL: https://github.com/llvm/llvm-project/commit/23d6a6dfc1bc6e79bdcc48a59a0698a5b79262e9 DIFF: https://github.com/llvm/llvm-project/commit/23d6a6dfc1bc6e79bdcc48a59a0698a5b79262e9.diff

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b2f50b4 - [clang-format][NFC] Use UnwrappedLineParser::eof() for consistency

Author: Owen Pan Date: 2023-10-19T13:38:49-07:00 New Revision: b2f50b49a8c45305d27f0393ee6248e3e8851788 URL: https://github.com/llvm/llvm-project/commit/b2f50b49a8c45305d27f0393ee6248e3e8851788 DIFF: https://github.com/llvm/llvm-project/commit/b2f50b49a8c45305d27f0393ee6248e3e8851788.diff

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool ExpectClassBody) { SmallVector LBraceStack; assert(Tok->is(tok::l_brace)); do { -// Get next non-comment token. -FormatToken *NextTok; -do { - NextTok = Tokens->getNextToken(); -

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

owenca wrote: @mydeveloperday what do you think? https://github.com/llvm/llvm-project/pull/69228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

owenca wrote: > Here's my solution to one of the regressions I caused (#68404) I don't think it's a regression. On the contrary, it actually exposed another bug. :) https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

owenca wrote: IMO, the new behavior is consistent with the [documentation](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#columnlimit) for `ColumnLimt: 0`. https://github.com/llvm/llvm-project/pull/69871 ___ cfe-commits mailing list

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

@@ -794,6 +794,7 @@ clang-format - Add ``AllowBreakBeforeNoexceptSpecifier`` option. - Add ``AllowShortCompoundRequirementOnASingleLine`` option. +- Change ``BreakAfterAttributes`` from ``Never`` to ``Leave`` in LLVM style owenca wrote: Full stop

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

@@ -26179,7 +26179,7 @@ TEST_F(FormatTest, RemoveSemicolon) { TEST_F(FormatTest, BreakAfterAttributes) { FormatStyle Style = getLLVMStyle(); - EXPECT_EQ(Style.BreakAfterAttributes, FormatStyle::ABS_Never); + EXPECT_EQ(Style.BreakAfterAttributes, FormatStyle::ABS_Leave);

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/70360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/70360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9299ace - [clang-format][NFC] Remove extraneous newlines in remaining unit tests

Author: Owen Pan Date: 2023-10-27T03:42:16-07:00 New Revision: 9299ace0a20d3ea4d921c033a49364ea6f24263e URL: https://github.com/llvm/llvm-project/commit/9299ace0a20d3ea4d921c033a49364ea6f24263e DIFF: https://github.com/llvm/llvm-project/commit/9299ace0a20d3ea4d921c033a49364ea6f24263e.diff

[clang] 6c3bc91 - [clang-format][NFC] Remove more extraneous newlines in unit tests

Author: Owen Pan Date: 2023-10-27T02:22:36-07:00 New Revision: 6c3bc910588f962e49470098ccc3b13c29cae493 URL: https://github.com/llvm/llvm-project/commit/6c3bc910588f962e49470098ccc3b13c29cae493 DIFF: https://github.com/llvm/llvm-project/commit/6c3bc910588f962e49470098ccc3b13c29cae493.diff

  1   2   3   4   5   6   7   8   9   10   >