Re: [PATCH] D12036: We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

2015-08-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245304: We shouldn't need to pass -fno-strict-aliasing when building clang with clang. (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D12036?vs=32349id=32420#toc Repository:

Re: [PATCH] D12240: [AArch64] Define the macro __ARM_FP16_ARGS

2015-08-24 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245833: [AArch64] Define the macro __ARM_FP16_ARGS (authored by kwalker). Changed prior to commit: http://reviews.llvm.org/D12240?vs=32832id=32938#toc Repository: rL LLVM

Re: [PATCH] D10016: Refactor: Simplify boolean conditional return statements in lib/Frontend

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38309. LegalizeAdulthood added a comment. Update to latest http://reviews.llvm.org/D10016 Files: lib/Frontend/VerifyDiagnosticConsumer.cpp Index: lib/Frontend/VerifyDiagnosticConsumer.cpp

Re: [PATCH] D10025: Refactor: Simplify boolean conditional return statements in clang-apply-replacements

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. I do not have commit access; someone will need to commit this for me. http://reviews.llvm.org/D10025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D10025: Refactor: Simplify boolean conditional return statements in clang-apply-replacements

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38313. LegalizeAdulthood added a comment. Update to latest http://reviews.llvm.org/D10025 Files: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp Index: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp

Re: [PATCH] D10024: Refactor: Simplify boolean conditional return statements in tools/libclang

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38315. LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Update to latest. Update from comments. I don't have commit access. http://reviews.llvm.org/D10024 Files: tools/libclang/CIndex.cpp

Re: [PATCH] D10020: Refactor: Simplify boolean conditional return statements in lib/Serialization

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38310. LegalizeAdulthood added a comment. Update to latest http://reviews.llvm.org/D10020 Files: lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp Index: lib/Serialization/ASTWriter.cpp

Re: [PATCH] D10020: Refactor: Simplify boolean conditional return statements in lib/Serialization

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. This changeset needs review, but I'm unsure of who to add as explicit reviewers. http://reviews.llvm.org/D10020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D10021: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Checkers

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38311. LegalizeAdulthood added a comment. Update to latest. This changeset needs review; I am unsure who to add as specific reviewers. http://reviews.llvm.org/D10021 Files: lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp

Re: [PATCH] D14011: [AST] Re-add TypeLocs and NestedNameSpecifierLocs to the ParentMap.

2015-10-23 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251101: [AST] Re-add TypeLocs and NestedNameSpecifierLocs to the ParentMap. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D14011?vs=38216=38220#toc Repository: rL LLVM

Re: [PATCH] D10022: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Core

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:692-693 @@ -691,4 +691,2 @@ CXXBasePaths Paths(false, false, false); - if (RD->lookupInBases( - [DeclName](const CXXBaseSpecifier *Specifier, CXXBasePath ) {

Re: [PATCH] D10014: Refactor: Simplify boolean conditional return statements in lib/Edit

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. In http://reviews.llvm.org/D10014#178294, @calabrese wrote: > I like the idea of all of these changes (this change list and the others), > but just a suggestion -- it looks like when the branch of the original > condition returns false, as was the case in the

Re: [PATCH] D10010: Refactor: Simplify boolean conditional return statements in lib/AST

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38321. LegalizeAdulthood added a comment. Update from latest. I do not have commit access. http://reviews.llvm.org/D10010 Files: lib/AST/ASTContext.cpp lib/AST/ASTDiagnostic.cpp lib/AST/Decl.cpp lib/AST/DeclCXX.cpp lib/AST/Expr.cpp

Re: [PATCH] D10019: Refactor: Simplify boolean conditional return statements in lib/Sema

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38324. LegalizeAdulthood added a comment. Update from latest. Update from comments. I do not have commit access. http://reviews.llvm.org/D10019 Files: lib/Sema/SemaChecking.cpp lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaDecl.cpp

Re: [PATCH] D10012: Refactor: Simplify boolean conditional return statements in lib/CodeGen

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38317. LegalizeAdulthood added a comment. Update to latest. I do not have commit access. http://reviews.llvm.org/D10012 Files: lib/CodeGen/BranchFolding.cpp lib/CodeGen/CodeGenPrepare.cpp lib/CodeGen/LiveDebugVariables.cpp

Re: [PATCH] D10011: Refactor: Simplify boolean conditional return statements in lib/Basic

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38318. LegalizeAdulthood added a comment. Update to latest. I do not have commit access. http://reviews.llvm.org/D10011 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

Re: [PATCH] D10022: Refactor: Simplify boolean conditional return statements in lib/StaticAnalyzer/Core

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38319. LegalizeAdulthood added a comment. Update from latest http://reviews.llvm.org/D10022 Files: lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp lib/StaticAnalyzer/Core/SValBuilder.cpp lib/StaticAnalyzer/Core/SymbolManager.cpp Index:

Re: [PATCH] D10014: Refactor: Simplify boolean conditional return statements in lib/Edit

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38323. LegalizeAdulthood added a comment. Update from latest. I do not have commit access. http://reviews.llvm.org/D10014 Files: lib/Edit/RewriteObjCFoundationAPI.cpp Index: lib/Edit/RewriteObjCFoundationAPI.cpp

Re: [PATCH] D10017: Refactor: Simplify boolean conditional return statements in lib/Lex

2015-10-24 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 38322. LegalizeAdulthood added a comment. Update to latest. I do not have commit access. http://reviews.llvm.org/D10017 Files: lib/Lex/PPDirectives.cpp lib/Lex/PPMacroExpansion.cpp Index: lib/Lex/PPMacroExpansion.cpp

Re: [PATCH] D13946: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

2015-10-21 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250905: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64). (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13946?vs=38023=38024#toc Repository: rL LLVM

Re: [PATCH] D13976: [AST] Store Decl* and Stmt* directly into the ParentMap.

2015-10-22 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251008: [AST] Store Decl* and Stmt* directly into the ParentMap. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13976?vs=38105=38110#toc Repository: rL LLVM

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

2015-10-27 Thread Will Wilson via cfe-commits
choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information Did anyone find a non-invasive workaround or is the patch still the way to go? Thanks, Will. On 5 October 2015 at 13:39, Manuel Klimek via cfe-commits < cfe-comm

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

2015-10-27 Thread Will Wilson via cfe-commits
on the Visual C++ > Help menu, or open the Technical Support help file for more information > > > Did anyone find a non-invasive workaround or is the patch still the way to > go? > > Thanks, > Will. > > On 5 October 2015 at 13:39, Manuel Klimek via cfe-commi

r251415 - [MSVC] Workaround for ICE in cl.exe when compiling ASTContext.cpp in Release Win32

2015-10-27 Thread Will Wilson via cfe-commits
Author: lantictac Date: Tue Oct 27 12:01:10 2015 New Revision: 251415 URL: http://llvm.org/viewvc/llvm-project?rev=251415=rev Log: [MSVC] Workaround for ICE in cl.exe when compiling ASTContext.cpp in Release Win32 Microsoft connect bug:

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

2015-10-27 Thread Will Wilson via cfe-commits
things again. > > On Tue, Oct 27, 2015 at 7:49 AM, Will Wilson via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I've ended up using the simplified fix described on the MS connect bug >> report for this issue: >> >> https://connect.microsoft.com

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

2015-10-27 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. In http://reviews.llvm.org/D7639#275504, @sbenza wrote: > Just fyi, I am looking at this diff. It is very large with a lot of rounds of > comments and I didn't have the context. > I don't know if I should giving comments at this point of the change, but >

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

2015-10-27 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. I mean, look at this review. I created it on Feb 13th 2015. It's been getting ground through the review process for 8 months. Why can't we move forward? http://reviews.llvm.org/D7639 ___ cfe-commits mailing

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

2015-10-23 Thread Richard via cfe-commits
LegalizeAdulthood marked 17 inline comments as done. LegalizeAdulthood added a comment. Can we get this committed? I've addressed all comments. http://reviews.llvm.org/D7639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13931: [Tooling] Add a utility function to replace one nested name with another.

2015-10-22 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251022: [Tooling] Add a utility function to replace one nested name with another. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13931?vs=38130=38131#toc Repository: rL LLVM

[PATCH] D14548: Make test/Driver/biarch.c use FileCheck instead of grep

2015-11-10 Thread A. Skrobov via cfe-commits
tyomitch created this revision. tyomitch added reviewers: joerg, rengolin, dougk, yaron.keren. tyomitch added a subscriber: cfe-commits. For clarity and ease of maintenance, I suggest porting this test to use the same tooling as the rest of the tests. http://reviews.llvm.org/D14548 Files:

Re: [PATCH] D14548: Make test/Driver/biarch.c use FileCheck instead of grep

2015-11-11 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252720: Make test/Driver/biarch.c use FileCheck instead of grep (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D14548?vs=39840=39889#toc Repository: rL LLVM

[PATCH] D14570: Handle ARMv6KZ naming

2015-11-11 Thread A. Skrobov via cfe-commits
tyomitch created this revision. tyomitch added reviewers: rengolin, joerg, bogden. tyomitch added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Update for clang tests for D14568 http://reviews.llvm.org/D14570 Files: test/Driver/arm-cortex-cpus.c

Re: [PATCH] D14484: Formatting constructor initializer lists by putting them always on different lines

2015-11-08 Thread JVApen via cfe-commits
JVApen added a comment. In http://reviews.llvm.org/D14484#284767, @djasper wrote: > Please read > > http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options > > Does your style option qualify? - Is it used by a project of significant size? Yes, we use the

Re: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-16 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253207: Handle ARMv6KZ naming (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D14570?vs=39901=40280#toc Repository: rL LLVM http://reviews.llvm.org/D14570 Files:

Re: [PATCH] D14578: Cull non-standard variants of ARM architectures (NFC)

2015-11-12 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252904: Cull non-standard variants of ARM architectures (NFC) (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D14578?vs=39943=40052#toc Repository: rL LLVM

Re: [PATCH] D14570: Handle ARMv6KZ naming

2015-11-12 Thread A. Skrobov via cfe-commits
tyomitch added a comment. In http://reviews.llvm.org/D14570#288022, @joerg wrote: > The specific CPU was only chosen to match what the backend supported at the > time. As long as the feature set is identical, it doesn't really matter. The feature set isn't quite identical; default ARMv6 CPU

[PATCH] D14578: Cull non-standard variants of ARM architectures (NFC)

2015-11-11 Thread A. Skrobov via cfe-commits
tyomitch created this revision. tyomitch added a reviewer: rengolin. tyomitch added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Clang-side update, corresponding to D14577 http://reviews.llvm.org/D14578 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

Re: [PATCH] D14311: [Clang] Fix some Clang-tidy modernize warnings, other minor fixes

2015-11-04 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252081: Fix some Clang-tidy modernize warnings, other minor fixes. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D14311?vs=39134=39252#toc Repository: rL LLVM

Re: [PATCH] D14384: [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles

2015-11-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252175: [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles: (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D14384?vs=39370=39373#toc Repository: rL LLVM

[PATCH] D14484: Formatting constructor initializer lists by putting them always on different lines

2015-11-08 Thread JVApen via cfe-commits
JVApen created this revision. JVApen added a reviewer: djasper. JVApen added a subscriber: cfe-commits. JVApen set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. Hi all, I've been playing around with the clang for a while now and really enjoy it. Unfortunately

Re: [PATCH] D14205: [x86] Front-end part of MCU psABI support

2015-11-02 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251786: [x86] Front-end part of MCU psABI support (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D14205?vs=38814=38878#toc Repository: rL LLVM

Re: [PATCH] D13959: Fix crash in EmitDeclMetadata mode

2015-11-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252229: Fix crash in EmitDeclMetadata mode (authored by kfischer). Changed prior to commit: http://reviews.llvm.org/D13959?vs=38049=39426#toc Repository: rL LLVM http://reviews.llvm.org/D13959

Re: [PATCH] D14440: [tsan] Add Clang frontend support for TSan on OS X

2015-11-06 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252310: [tsan] Add Clang frontend support for TSan on OS X (authored by kuba.brecka). Changed prior to commit: http://reviews.llvm.org/D14440?vs=39524=39526#toc Repository: rL LLVM

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

2015-10-18 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. In http://reviews.llvm.org/D7639#266332, @Eugene.Zelenko wrote: > What is preventing to add this check to Clang-tidy? Just found another piece > of fresh C++ code in LLDB with (void) as argument list... To be honest, I don't know. This review had taken

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

2015-10-18 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 37717. http://reviews.llvm.org/D7639 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantVoidArgCheck.cpp clang-tidy/readability/RedundantVoidArgCheck.h

Re: [PATCH] D13304: Avoid inlining in throw statement

2015-10-08 Thread via cfe-commits
the callee size right before the inliner. I may add the noinline only when the constructor is large enough. > On Wed, Oct 7, 2015 at 3:10 PM, Jun Bum Lim via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> junbuml added a comment. >> >> Thanks Richard f

Re: [PATCH] D13861: [x86] fix wrong maskload/store intrinsic definitions in avxintrin.h (follow up of D13776).

2015-10-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250816: [x86] Fix maskload/store intrinsic definitions in avxintrin.h (authored by adibiagio). Changed prior to commit: http://reviews.llvm.org/D13861?vs=37741=37852#toc Repository: rL LLVM

Re: [PATCH] D13474: [VFS] Port tooling to use the in-memory file system.

2015-10-09 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249815: [VFS] Port tooling to use the in-memory file system. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13474?vs=36632=36929#toc Repository: rL LLVM

Re: [PATCH] D13658: [VFS] Let the user decide if they want path normalization.

2015-10-12 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250060: [VFS] Let the user decide if they want path normalization. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13658?vs=37124=37125#toc Repository: rL LLVM

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

2015-10-12 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250064: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D13399?vs=36897=37127#toc Repository: rL

Re: [PATCH] D11433: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference events.

2015-08-27 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246182: [Static Analyzer] Make NonNullParamChecker emit implicit null dereference… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D11433?vs=5id=33344#toc Repository: rL

Re: [PATCH] D11468: [Static Analyzer] The first implementation of nullability checker.

2015-08-26 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246105: [Static Analyzer] Checks to catch nullability related issues. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D11468?vs=33239id=33267#toc Repository: rL LLVM

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

2015-08-31 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246438: PR17829: Proper diagnostic of mangled names conflicts (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D11297?vs=33401=33577#toc Repository: rL LLVM

Re: [PATCH] D12444: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610)

2015-09-01 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246618: [Sema] Avoid crash on tag-type mismatch (Fixes PR24610) (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D12444?vs=33623=33777#toc Repository: rL LLVM

[PATCH] D12684: [INSTALL.txt] Fix formatting - 80 character line

2015-09-07 Thread beltex via cfe-commits
beltex created this revision. beltex added a subscriber: cfe-commits. http://reviews.llvm.org/D12684 Files: INSTALL.txt Index: INSTALL.txt === --- INSTALL.txt +++ INSTALL.txt @@ -44,6 +44,6 @@ compiler and header files into the

Re: [PATCH] D12002: Initial WebAssembly support in clang

2015-09-03 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246814: [WebAssembly] Initial WebAssembly support in clang (authored by djg). Changed prior to commit: http://reviews.llvm.org/D12002?vs=33637=33985#toc Repository: rL LLVM

Re: [PATCH] D12684: [INSTALL.txt] Fix formatting - 80 character line

2015-09-13 Thread beltex via cfe-commits
beltex added a comment. Thanks! My first patch! :) http://reviews.llvm.org/D12684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12684: [INSTALL.txt] Fix formatting - 80 character line

2015-09-13 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247530: [docs] NFC: Fix line formatting in INSTALL.txt (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D12684?vs=34178=34650#toc Repository: rL LLVM

[PATCH] D12840: [cfe-dev] Enabling ThreadSanitizer on PPC64(BE/LE) plarforms

2015-09-14 Thread Simone via cfe-commits
simoatze created this revision. simoatze added reviewers: kbarton, nemanjai, wschmidt. simoatze added a subscriber: cfe-commits. Enabling ThreadSanitizer on PPC64(BE/LE) platforms. The current patch will enable the flag "-fsanitize=thread" on Clang on PPC64 systems.

Re: [PATCH] D12381: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type Propagation checker.

2015-09-13 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247532: [Static Analyzer] Merge the Objective-C Generics Checker into Dynamic Type… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12381?vs=34606=34651#toc Repository: rL

Re: [PATCH] D12862: [WebAssembly] Define the atomic type sizes

2015-09-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247624: [WebAssembly] Define the atomic type sizes (authored by djg). Changed prior to commit: http://reviews.llvm.org/D12862?vs=34731=34739#toc Repository: rL LLVM http://reviews.llvm.org/D12862

Re: [PATCH] D12858: [Static Analyzer] Turn on some nullability checks by default.

2015-09-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247614: [Static Analyzer] Turn on some nullability checks by default. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12858?vs=34720=34726#toc Repository: rL LLVM

Re: [PATCH] D12848: [Static Analyzer] Nullability checker optimization.

2015-09-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247612: [Static Analyzer] Nullability checker optimization. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12848?vs=34693=34725#toc Repository: rL LLVM

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

2015-09-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247619: PR24595: Ignore calling convention modifiers for structors in MS ABI. (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D12402?vs=34477=34735#toc Repository: rL LLVM

Re: [PATCH] D12861: [WebAssembly] Use "long long" for int_fast64_t and int_least64_t on wasm64

2015-09-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247622: [WebAssembly] Use "long long" for int_fast64_t and int_least64_t on wasm64 (authored by djg). Changed prior to commit: http://reviews.llvm.org/D12861?vs=34727=34738#toc Repository: rL LLVM

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-11 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247426: [Static Analyzer] Lambda support. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12652?vs=34498=34555#toc Repository: rL LLVM http://reviews.llvm.org/D12652 Files:

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

2015-09-11 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247437: [test] Specify exception object type in two tests (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D12743?vs=34408=34560#toc Repository: rL LLVM

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

2015-09-16 Thread strager via cfe-commits
strager updated this revision to Diff 34946. strager marked 2 inline comments as done. strager added a comment. Address @djasper's comments. http://reviews.llvm.org/D11693 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-09-16 Thread strager via cfe-commits
strager updated this revision to Diff 34947. strager added a comment. Rebase. http://reviews.llvm.org/D10370 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp

Re: [PATCH] D10371: clang-format: Support @synchronized.

2015-09-16 Thread strager via cfe-commits
strager updated this revision to Diff 34957. strager added a comment. Rebase. Fix style issues. http://reviews.llvm.org/D10371 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

2015-09-16 Thread strager via cfe-commits
strager marked 4 inline comments as done. Comment at: lib/Format/UnwrappedLineParser.cpp:1057-1058 @@ +1056,4 @@ + while (!eof()) { +// FIXME: Once we have an expression parser in the UnwrappedLineParser, +// replace this by using parseAssigmentExpression()

[PATCH] D12921: clang-format: Support 'template<>' (no space).

2015-09-16 Thread strager via cfe-commits
strager created this revision. strager added a reviewer: djasper. strager added subscribers: cfe-commits, abdulras, sas. Herald added a subscriber: klimek. Some styles don't put a space between 'template' and the opening '<'. Introduce SpaceAfterTemplateKeyword which, when set to false, causes

[PATCH] D12938: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

2015-09-17 Thread A. Skrobov via cfe-commits
tyomitch created this revision. tyomitch added reviewers: labrinea, rengolin. tyomitch added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Currently, the availability of DSP instructions (ACLE 6.4.7) is handled in a hand-rolled tricky condition block in

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

2015-09-17 Thread strager via cfe-commits
strager marked 2 inline comments as done. Comment at: lib/Format/UnwrappedLineParser.cpp:1060-1061 @@ +1059,4 @@ + nextToken(); + while (!eof()) { +// FIXME: Once we have an expression parser in the UnwrappedLineParser, +// replace this by using

Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

2015-09-17 Thread strager via cfe-commits
strager added a comment. Should we remove `ObjCSpaceBeforeProtocolList`? It has the same problem as the `SpaceAfterTemplateKeyword` I am introducing. http://reviews.llvm.org/D12921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D1623: Support __builtin_ms_va_list.

2015-09-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247941: Support __builtin_ms_va_list. (authored by cdavis). Changed prior to commit: http://reviews.llvm.org/D1623?vs=34728=35036#toc Repository: rL LLVM http://reviews.llvm.org/D1623 Files:

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-09-17 Thread strager via cfe-commits
strager updated this revision to Diff 35038. strager added a comment. Fix missing IsDefinition check in ContinuationIndenter::canBreak. http://reviews.llvm.org/D10370 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-09-17 Thread strager via cfe-commits
strager added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:221-235 @@ -220,3 +220,17 @@ -**AlwaysBreakAfterDefinitionReturnType** (``DefinitionReturnTypeBreakingStyle``) +**AlwaysBreakAfterDeclarationReturnType** (``ReturnTypeBreakingStyle``) + The function

Re: [PATCH] D10881: [Sema] Catch a case when 'volatile' qualifier is dropped while binding

2015-09-17 Thread ~paul via cfe-commits
cynecx added a comment. Hi :), First of all, I would like to say that I am new into all the clang stuff (software architecture/internal concepts) but I wanted to start hacking clang so I went here to check out some ##trivial## clang bugs to fix so I can learn internal stuff about clang, with

Re: [PATCH] D12852: [Static Analyzer] Moving nullability checkers to a top level package.

2015-09-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247590: [Static Analyzer] Moving nullability checkers to a top level package. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12852?vs=34705=34713#toc Repository: rL LLVM

Re: [PATCH] D12818: [Static Analyzer] Relaxing a caching out related assert.

2015-09-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247598: [Static Analyzer] Relaxing a caching out related assert. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12818?vs=34579=34719#toc Repository: rL LLVM

Re: [PATCH] D11700: Added remove taint support to ProgramState.

2015-10-03 Thread Francisco via cfe-commits
franchiotta added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:444-448 @@ +443,7 @@ + + SymbolRef + getSymbolFromStmt(const Stmt *S, const LocationContext *LCtx) const; + + const MemRegion* + getRegionFromStmt(const Stmt *S,

Re: [PATCH] D11700: Added remove taint support to ProgramState.

2015-10-03 Thread Francisco via cfe-commits
franchiotta updated the summary for this revision. franchiotta updated this revision to Diff 36431. franchiotta added a comment. Some changes made based on the received suggestions. http://reviews.llvm.org/D11700 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h

Re: [PATCH] D13421: Fix makefile build on OSX when ARM targets are not enabled

2015-10-04 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249281: Fix makefile build on OSX when ARM targets are not enabled (authored by kfischer). Changed prior to commit: http://reviews.llvm.org/D13421?vs=36462=36473#toc Repository: rL LLVM

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

2015-10-02 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249140: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64]… (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D12633?vs=35628=36367#toc Repository: rL

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

2015-09-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248021: [analyzer] A fix for substraction of an integer from a pointer. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12725?vs=34423=35122#toc Repository: rL LLVM

[PATCH] D13105: [OpenCL] Enable program scope variables for OpenCL2.0

2015-09-23 Thread Anastasia via cfe-commits
Anastasia created this revision. Anastasia added a reviewer: pekka.jaaskelainen. Anastasia added a subscriber: cfe-commits. I would like to commit this change that enables program scope variables (PSVs) – an OpenCL2.0 feature (Section 6.5.1). There are three major changes in this patch. First

Re: [PATCH] D12916: [Static Analyzer] Use generics related information to infer dynamic types.

2015-09-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248002: [Static Analyzer] Use generics related information to infer dynamic types. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12916?vs=35027=35095#toc Repository: rL LLVM

Re: [PATCH] D12938: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

2015-09-21 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248154: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D12938?vs=35001=35244#toc Repository: rL LLVM

Re: [PATCH] D13113: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

2015-09-23 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248442: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures… (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D13113?vs=35538=35567#toc Repository:

Re: [PATCH] D13217: [ARM] The Driver does not set the +strict-align flag when targeting armv6m + netbsd

2015-10-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249308: The Driver does not set the +strict-align flag when targeting (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D13217?vs=35883=36507#toc Repository: rL LLVM

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

2015-10-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249316: [VFS] Add working directories to every virtual file system. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13430?vs=36509=36515#toc Repository: rL LLVM

Re: [PATCH] D15311: [Clang] Use range loops and autos in lib/Serialization/ASTWriter.cpp

2015-12-08 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255033: Use range loops and autos in lib/Serialization/ASTWriter.cpp. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D15311?vs=42112=42190#toc Repository: rL LLVM

Re: [PATCH] D15313: [Clang] Use range loops and autos in utils/TableGen/ClangAttrEmitter.cpp

2015-12-08 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255042: Use range loops and autos in utils/TableGen/ClangAttrEmitter.cpp and… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D15313?vs=42192=42197#toc Repository: rL

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

2015-12-01 Thread Richard via cfe-commits
LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. I'm wondering if there isn't an existing module that would be a good fit for this check. Why not in the modernize module? http://reviews.llvm.org/D15121

Re: [PATCH] D15007: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414.

2015-12-04 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254718: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D15007?vs=41494=41876#toc Repository: rL LLVM

[PATCH] Add ObjCBoxable handling to ObjCMigrator

2015-12-05 Thread AlexDenisov via cfe-commits
Extend ObjCMigrator to cover automatic migration from message sending to boxable literals, e.g.: ```before typedef struct __attribute__((objc_boxable)) CGRect CGRect; /// ... CGRect rect; [NSValue valueWithBytes: objCType:@encode(CGRect)]; [NSValue valueWithCGPoint:functionReturningCGPoint()];

Re: [PATCH] D15254: Fix crash when dumping NamedDecl with NULL getQualifier().

2015-12-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254867: Fix crash in ASTDumper when dumping NamedDecl with NULL getQualifier(). (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D15254?vs=41968=41996#toc Repository: rL LLVM

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

2015-12-10 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255236: [analyzer] Fix symbolic element index lifetime. (authored by dergachev). Changed prior to commit: http://reviews.llvm.org/D12726?vs=37267=42400#toc Repository: rL LLVM

Re: [PATCH] D15586: [WebAssembly] Initial linking support.

2015-12-16 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255848: [WebAssembly] Initial linking support. (authored by djg). Changed prior to commit: http://reviews.llvm.org/D15586?vs=43059=43075#toc Repository: rL LLVM http://reviews.llvm.org/D15586

  1   2   3   4   5   6   7   8   9   10   >