This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG60c9b5f35cae: [AArch64][SVE] Improve codegen for dupq SVE
ACLE intrinsics (authored by bsmith).
Repository:
rG LLVM Github Monorepo
CHANGES
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103082/new/
https://reviews.llvm.org/D103082
bsmith updated this revision to Diff 349827.
bsmith marked an inline comment as done.
bsmith added a comment.
- Remove unnecessary complexity when zero-extending dupq operands into a vector.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103082/new/
efriedma added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9068
+VecOps.push_back(llvm::ConstantInt::get(
+EltTy, cast(Ops[I])->getZExtValue()));
+ else
Constant doesn't imply ConstantInt. (For example, it could be the
bsmith updated this revision to Diff 349525.
bsmith added a comment.
- Use !isZero() in place of getZExtValue() != 0
- Add end to end tests for ptrue transformation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103082/new/
efriedma added a comment.
Can we add a few end-to-end tests of bool svdupq with constant operands to
acle_sve_dupq.c? The pattern matching to create ptrue seems a bit fragile, so
I want to make sure we don't break it by accident.
Comment at:
bsmith updated this revision to Diff 349241.
bsmith retitled this revision from "[AArch64][SVE] Optimize svbool dupq ACLE
intrinsic to fixed predicate patterns" to "[AArch64][SVE] Improve codegen for
dupq SVE ACLE intrinsics".
bsmith edited the summary of this revision.
bsmith added a comment.
