[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith added a comment. The tests in this are broken for windows, which I've fixed in 45e102a173680fd3c90def79a7f0766ed2786ff0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26f56438e3da: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +… (authored by bsmith). Repository: rG LLVM Github

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:82-88 +if (Feature == "sve2") + Features.push_back("+sve"); +else if (Feature ==

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:82-88 +if (Feature == "sve2") + Features.push_back("+sve"); +else if (Feature == "sve2-bitperm" || Feature == "sve2-sha3" || + Feature == "sve2-aes" || Feature ==

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:82-88 +if (Feature == "sve2") + Features.push_back("+sve"); +else if (Feature == "sve2-bitperm" || Feature == "sve2-sha3" || + Feature == "sve2-aes" || Feature ==

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith updated this revision to Diff 387900. bsmith added a comment. - Use more brute force approach to ensure ordering is accounted for - This massively simplifies things and removes what was becoming very confusing logic - Add tests for missing cases Repository: rG LLVM Github Monorepo

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:73 static bool DecodeAArch64Features(const Driver , StringRef text, std::vector , llvm::AArch64::ArchKind ArchKind) {

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:73 static bool DecodeAArch64Features(const Driver , StringRef text, std::vector , llvm::AArch64::ArchKind ArchKind) {

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:73 static bool DecodeAArch64Features(const Driver , StringRef text, std::vector , llvm::AArch64::ArchKind ArchKind) {

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

mgabka added inline comments. Comment at: clang/test/Driver/aarch64-implied-sve-features.c:28 + +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosve2-bitperm %s -### |& FileCheck %s --check-prefix=NOSVE2-BITPERM +// NOSVE2-BITPERM-NOT: "-target-feature"

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith updated this revision to Diff 387212. bsmith edited the summary of this revision. bsmith added a comment. Herald added a subscriber: kristof.beyls. - Fix duplicate arch feature in unit test - Use enum class instead of plain enum with typedef Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

peterwaller-arm added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:908 + AArch64::AEK_I8MM | AArch64::AEK_SVE | + AArch64::AEK_SVE2 | AArch64::AEK_SVE2BITPERM |

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

tschuett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:66 +typedef enum { Unset, True, False } OptState; +bool isUnset(OptState State) { return State == OptState::Unset; } This is almost an enum class. ``` enum class OptState

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, sdesmalen. Herald added subscribers: psnobl, tschuett. Herald added a reviewer: efriedma. bsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,