https://github.com/vincent-mailhol edited
https://github.com/llvm/llvm-project/pull/88489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -245,6 +245,13 @@ Modified Compiler Flags
f3 *c = (f3 *)x;
}
+- Added a new diagnostic flag ``-Wpointer-integer-ordered-compare`` which is
+ grouped under ``-Wpointer-integer-compare`` and moved previously
+ ungrouped diagnostics
https://github.com/vincent-mailhol approved this pull request.
As far as my understanding of the LLVM project goes, this change looks good to
me. I am not an expert of this project, but regardless and for what it is
worth, here is my approval (with one nitpick).
11happy wrote:
Humble ping!
https://github.com/llvm/llvm-project/pull/88489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,30 @@
+// RUN: %clang_cc1 -Wno-pointer-integer-compare
-Wpointer-integer-ordered-compare -fsyntax-only -verify=pointer-integer-ordered
%s
+// RUN: %clang_cc1 -Wpointer-integer-compare
-Wno-pointer-integer-ordered-compare -fsyntax-only -verify=pointer-integer %s
+
@@ -245,6 +245,12 @@ Modified Compiler Flags
f3 *c = (f3 *)x;
}
+- Added a new diagnostic flag ``-Wpointer-integer-ordered-compare`` which is
+ grouped under ``-Wpointer-integer-compare`` and moved previously
+ ungrouped diagnostics
@@ -714,10 +714,11 @@ def HeaderHygiene : DiagGroup<"header-hygiene">;
def DuplicateDeclSpecifier : DiagGroup<"duplicate-decl-specifier">;
def CompareDistinctPointerType : DiagGroup<"compare-distinct-pointer-types">;
def GNUUnionCast : DiagGroup<"gnu-union-cast">;
+def
11happy wrote:
humble reminder @AaronBallman , @shafik
https://github.com/llvm/llvm-project/pull/88489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
11happy wrote:
Hello @vincent-mailhol thank you for the review I have made the suggested
changed.
https://github.com/llvm/llvm-project/pull/88489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/11happy updated
https://github.com/llvm/llvm-project/pull/88489
>From bc08f479ba483e1582304ca103dbd92481108f12 Mon Sep 17 00:00:00 2001
From: 11happy
Date: Fri, 12 Apr 2024 14:56:42 +0530
Subject: [PATCH 1/3] add new flag -Wpointer-integer-ordered-compare
Signed-off-by:
@@ -245,6 +245,12 @@ Modified Compiler Flags
f3 *c = (f3 *)x;
}
+- Added a new diagnostic flag ``-Wpointer-integer-ordered-compare`` which is
+ grouped under ``-Wpointer-integer-compare`` and moved previously
+ ungrouped diagnostics
https://github.com/vincent-mailhol commented:
Thanks for taking care of the issue I created.
For what it is worth, here is my review. I am not a contributor of the llvm
project, so I only left superficial nitpicks.
https://github.com/llvm/llvm-project/pull/88489
@@ -714,10 +714,11 @@ def HeaderHygiene : DiagGroup<"header-hygiene">;
def DuplicateDeclSpecifier : DiagGroup<"duplicate-decl-specifier">;
def CompareDistinctPointerType : DiagGroup<"compare-distinct-pointer-types">;
def GNUUnionCast : DiagGroup<"gnu-union-cast">;
+def
@@ -0,0 +1,30 @@
+// RUN: %clang_cc1 -Wno-pointer-integer-compare
-Wpointer-integer-ordered-compare -fsyntax-only -verify=pointer-integer-ordered
%s
+// RUN: %clang_cc1 -Wpointer-integer-compare
-Wno-pointer-integer-ordered-compare -fsyntax-only -verify=pointer-integer %s
+
https://github.com/vincent-mailhol edited
https://github.com/llvm/llvm-project/pull/88489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/11happy updated
https://github.com/llvm/llvm-project/pull/88489
>From bc08f479ba483e1582304ca103dbd92481108f12 Mon Sep 17 00:00:00 2001
From: 11happy
Date: Fri, 12 Apr 2024 14:56:42 +0530
Subject: [PATCH 1/2] add new flag -Wpointer-integer-ordered-compare
Signed-off-by:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Bhuminjay Soni (11happy)
Changes
**Overview:**
This pull request fixes #88090 where a false negative issue related to
`-Wpointer-integer-compare` failing on comparison between a pointer and zero.
**Testing:**
- Tested the updated code.
-
https://github.com/11happy created
https://github.com/llvm/llvm-project/pull/88489
**Overview:**
This pull request fixes #88090 where a false negative issue related to
`-Wpointer-integer-compare` failing on comparison between a pointer and zero.
**Testing:**
- Tested the updated code.
-
18 matches
Mail list logo
